Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-7871 | fix: Mandatory fields should enter interactive mode if not provided #2104

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

chenz4027
Copy link
Contributor

Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 27.01%. Comparing base (cb97232) to head (a8e7b20).
Report is 65 commits behind head on master.

Files Patch % Lines
pkg/externalauthprovider/flags.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2104      +/-   ##
==========================================
+ Coverage   26.67%   27.01%   +0.33%     
==========================================
  Files         152      153       +1     
  Lines       21400    21690     +290     
==========================================
+ Hits         5708     5859     +151     
- Misses      15267    15398     +131     
- Partials      425      433       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

… provided

Signed-off-by: Maggie Chen <magchen@redhat.com>

add tests

Signed-off-by: Maggie Chen <magchen@redhat.com>
@willkutler
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2024
@gdbranco
Copy link
Contributor

gdbranco commented Jun 6, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Jun 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenz4027, gdbranco, willkutler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD fdfe4a5 and 2 for PR HEAD a8e7b20 in total

@chenz4027
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3feb790 and 1 for PR HEAD a8e7b20 in total

Copy link
Contributor

openshift-ci bot commented Jun 7, 2024

@chenz4027: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 7b0e276 into openshift:master Jun 7, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants