-
Notifications
You must be signed in to change notification settings - Fork 2k
deploy-konflux-operator: Add support for disconnected environments #72711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
deploy-konflux-operator: Add support for disconnected environments #72711
Conversation
Enhance the deploy-konflux-operator step to support deployment in
disconnected/air-gapped OpenShift environments with the following changes:
- Add DISCONNECTED flag to enable disconnected mode operation
- Support registry proxy configuration via USE_REGISTRY_PROXY flag
- Add configurable registry proxy host/port (REGISTRY_PROXY_HOST/PORT)
- Allow deriving proxy URL from mirror registry or explicit configuration
- Add mirror registry credential handling (MIRROR_REGISTRY_DIR/CREDS)
- Remove obsolete install_secret function (pull secret handling). This
is handled directly in the deploy-operator.sh script.
The step now supports two disconnected scenarios:
1. Direct mirror registry access with authentication
2. Registry proxy with custom or derived proxy endpoint
Environment variables added:
- DISCONNECTED (default: false)
- USE_REGISTRY_PROXY (default: false)
- REGISTRY_PROXY_HOST (optional, derived if not set)
- REGISTRY_PROXY_PORT (required with REGISTRY_PROXY_HOST)
- REGISTRY_PROXY_CREDENTIALS (optional, uses mirror creds if not set)
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mgencur The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/hold Depends on ajaggapa/deploy-konflux-operator#2 |
| declare -r REGISTRY_PROXY_CREDENTIALS="${REGISTRY_PROXY_CREDENTIALS:-"${MIRROR_REGISTRY_CREDS}"}" | ||
| declare -r REGISTRY_PROXY_HOST="${REGISTRY_PROXY_HOST:-""}" | ||
| declare -r REGISTRY_PROXY_PORT="${REGISTRY_PROXY_PORT:-""}" | ||
| declare -r DEPLOY_KONFLUX_OPERATOR_VERSION=v7.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need to be changed once ajaggapa/deploy-konflux-operator#2 is merged and a new tag created.
|
[REHEARSALNOTIFIER]
A total of 48 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@mgencur: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
https://issues.redhat.com/browse/OCPQE-31326
Depends on ajaggapa/deploy-konflux-operator#2
Enhance the deploy-konflux-operator step to support deployment in
disconnected/air-gapped OpenShift environments with the following changes:
The step now supports two disconnected scenarios:
Environment variables added:
This code has been tested in #72521 with registry proxy running on port 6003 in bare metal environment.