Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release: update logic for fetching clients from the mirrors #6973

Merged
merged 1 commit into from
Feb 4, 2020
Merged

release: update logic for fetching clients from the mirrors #6973

merged 1 commit into from
Feb 4, 2020

Conversation

stevekuznetsov
Copy link
Contributor

A dynamic process to grab the latest clients we can from the mirrors
allows these jobs to be batch-processed by a machine when we branch.

Signed-off-by: Steve Kuznetsov skuznets@redhat.com

/assign @smarterclayton

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 31, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2020
@stevekuznetsov stevekuznetsov force-pushed the skuznets/fetch-floating-oc branch from 3705261 to 25b10a1 Compare January 31, 2020 22:33
smarterclayton
smarterclayton reviewed Jan 31, 2020
View reviewed changes
ci-operator/jobs/openshift/release/openshift-release-release-4.4-periodics.yaml Outdated
@@ -407,7 +412,12 @@ periodics:
mkdir $HOME/.docker/
cp /usr/local/pull-secret/.dockerconfigjson $HOME/.docker/config.json
mkdir $HOME/bin
curl https://mirror.openshift.com/pub/openshift-v4/clients/ocp-dev-preview/4.4.0-0.nightly-2019-12-19-100131/openshift-client-linux-4.4.0-0.nightly-2019-12-19-100131.tar.gz 2>/dev/null | tar xzf - -C /tmp/bin/ oc
base="https://mirror.openshift.com/pub/openshift-v4/clients/ocp-dev-preview/latest-4.4/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can’t you make these look the ones that grabbed latest 4.4?

@stevekuznetsov
release: update logic for fetching clients from the mirrors
00ee56a 
A dynamic process to grab the latest clients we can from the mirrors
allows these jobs to be batch-processed by a machine when we branch.

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov stevekuznetsov force-pushed the skuznets/fetch-floating-oc branch from 25b10a1 to 00ee56a Compare February 4, 2020 16:56
@smarterclayton
Copy link
Contributor

/lgtm

thanks

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 27a5d05 into openshift:master Feb 4, 2020
@openshift-ci-robot
Copy link
Contributor

@stevekuznetsov: Updated the following 2 configmaps:

  • job-config-4.5 configmap in namespace ci at cluster default using the following files:
    • key openshift-release-release-4.5-periodics.yaml using file ci-operator/jobs/openshift/release/openshift-release-release-4.5-periodics.yaml
  • job-config-4.4 configmap in namespace ci at cluster default using the following files:
    • key openshift-release-release-4.4-periodics.yaml using file ci-operator/jobs/openshift/release/openshift-release-release-4.4-periodics.yaml

In response to this:

A dynamic process to grab the latest clients we can from the mirrors
allows these jobs to be batch-processed by a machine when we branch.

Signed-off-by: Steve Kuznetsov skuznets@redhat.com

/assign @smarterclayton

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@stevekuznetsov: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/release-openshift-origin-installer-old-rhcos-e2e-aws-4.5 00ee56a link /test pj-rehearse
ci/rehearse/release-openshift-origin-installer-e2e-azure-upgrade-4.5 00ee56a link /test pj-rehearse
ci/rehearse/release-openshift-origin-installer-e2e-azure-upgrade-4.4 00ee56a link /test pj-rehearse
ci/rehearse/release-openshift-origin-installer-e2e-gcp-upgrade-4.5 00ee56a link /test pj-rehearse
ci/rehearse/release-openshift-origin-installer-e2e-aws-upgrade-4.4-stable-to-4.5-ci 00ee56a link /test pj-rehearse
ci/rehearse/release-openshift-origin-installer-e2e-aws-upgrade-rollback-4.5 00ee56a link /test pj-rehearse
ci/rehearse/release-openshift-origin-installer-e2e-aws-upgrade-rollback-4.4-to-4.5 00ee56a link /test pj-rehearse
ci/rehearse/release-openshift-origin-installer-old-rhcos-e2e-aws-4.4 00ee56a link /test pj-rehearse
ci/rehearse/release-openshift-origin-installer-e2e-gcp-upgrade-4.4 00ee56a link /test pj-rehearse
ci/rehearse/release-openshift-origin-installer-e2e-aws-upgrade-4.3-stable-to-4.4-ci 00ee56a link /test pj-rehearse
ci/prow/pj-rehearse 00ee56a link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarterclayton smarterclayton smarterclayton left review comments

@bbguimaraes bbguimaraes Awaiting requested review from bbguimaraes

@petr-muller petr-muller Awaiting requested review from petr-muller

Assignees

@smarterclayton smarterclayton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stevekuznetsov @smarterclayton @openshift-ci-robot @openshift-bot @openshift-merge-robot