Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDCICD-146: Add imageset test jobs #6956

Merged
merged 2 commits into from
Feb 5, 2020
Merged

SDCICD-146: Add imageset test jobs #6956

merged 2 commits into from
Feb 5, 2020

Conversation

jeefy
Copy link
Contributor

@jeefy jeefy commented Jan 31, 2020

Do not merge or look at rehearsals until openshift/osde2e#211 has been merged. WIP'd just to be safe

Also: Found two more crontab instances that didn't have an explicit minute set, so slipped that in as well.

/assign @meowfaceman

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 31, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2020
@jeefy jeefy changed the title WIP: SDCICD-146: Add imageset test jobs SDCICD-146: Add imageset test jobs Jan 31, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2020
@jeefy
Copy link
Contributor Author

jeefy commented Jan 31, 2020

/retest

@mdwn
Copy link
Contributor

mdwn commented Feb 5, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeefy, meowfaceman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit ce3af82 into openshift:master Feb 5, 2020
@openshift-ci-robot
Copy link
Contributor

@jeefy: Updated the job-config-master configmap in namespace ci at cluster default using the following files:

  • key openshift-osde2e-master-periodics.yaml using file ci-operator/jobs/openshift/osde2e/openshift-osde2e-master-periodics.yaml

In response to this:

Do not merge or look at rehearsals until openshift/osde2e#211 has been merged. WIP'd just to be safe

Also: Found two more crontab instances that didn't have an explicit minute set, so slipped that in as well.

/assign @meowfaceman

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyeder jeremyeder Awaiting requested review from jeremyeder

@mdwn mdwn Awaiting requested review from mdwn

Assignees

@mdwn mdwn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeefy @mdwn @openshift-ci-robot @openshift-merge-robot