Skip to content

Conversation

@grokspawn
Copy link
Contributor

@grokspawn grokspawn commented Sep 4, 2025

o-f/operator-lifecycle-manager and o-f/operator-registry contribute to historically distant openshift releases, but switched release machinery many releases ago so that they no longer do so.

As a result, they shouldn't be subject to the new ART verified machinery.

(Note: the delta is the removal of the verified label requirements. Additional changes are relocation & whitespace-only changes mandated by CI)

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 4, 2025
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2025
Signed-off-by: grokspawn <jordan@nimblewidget.com>
@grokspawn grokspawn force-pushed the misplaced-verify-labels branch from 2c1805d to 7d9762f Compare September 4, 2025 16:32
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@grokspawn: no rehearsable tests are affected by this change

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 4, 2025

@grokspawn: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jianzhangbjz
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn, jianzhangbjz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 3cdce7c into openshift:master Sep 5, 2025
10 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 5, 2025

@grokspawn: Updated the config configmap in namespace ci at cluster app.ci using the following files:

  • key core-services-prow-02_config-operator-framework-operator-lifecycle-manager-_prowconfig.yaml using file core-services/prow/02_config/operator-framework/operator-lifecycle-manager/_prowconfig.yaml
  • key core-services-prow-02_config-operator-framework-operator-registry-_prowconfig.yaml using file core-services/prow/02_config/operator-framework/operator-registry/_prowconfig.yaml

In response to this:

o-f/operator-lifecycle-manager and o-f/operator-registry contribute to historically distant openshift releases, but switched release machinery many releases ago so that they no longer do so.

As a result, they shouldn't be subject to the new ART verified machinery.

(Note: the delta is the removal of the verified label requirements. Additional changes are relocation & whitespace-only changes mandated by CI)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

xiaojiey pushed a commit to xiaojiey/release that referenced this pull request Sep 25, 2025
Signed-off-by: grokspawn <jordan@nimblewidget.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants