Skip to content

Conversation

@grokspawn
Copy link
Contributor

@grokspawn grokspawn commented Mar 26, 2025

@grokspawn grokspawn changed the title add operator-framework/operator-controller tide config OPRUN-3742: add operator-framework/operator-controller tide config Mar 26, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 26, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 26, 2025

@grokspawn: This pull request references OPRUN-3742 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Solves

Adds prow/tide config to the repo so we can support separate reviewer/approver tiers.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2025
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 26, 2025
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 26, 2025
@grokspawn grokspawn force-pushed the tide-op-con branch 4 times, most recently from c35d8f9 to 9c4280f Compare March 26, 2025 20:48
@grokspawn
Copy link
Contributor Author

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@grokspawn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@grokspawn
Copy link
Contributor Author

/pj-rehearse pull-ci-operator-framework-operator-controller-main-build

@openshift-ci-robot
Copy link
Contributor

@grokspawn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@grokspawn grokspawn changed the title OPRUN-3742: add operator-framework/operator-controller tide config WIP: OPRUN-3742: add operator-framework/operator-controller tide config Mar 27, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 27, 2025
@grokspawn
Copy link
Contributor Author

/pj-rehearse pull-ci-operator-framework-operator-controller-main-build

@openshift-ci-robot
Copy link
Contributor

@grokspawn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@grokspawn
Copy link
Contributor Author

/pj-rehearse pull-ci-operator-framework-operator-controller-main-build

@openshift-ci-robot
Copy link
Contributor

@grokspawn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@grokspawn
Copy link
Contributor Author

/pj-rehearse skip

@openshift-ci-robot
Copy link
Contributor

@grokspawn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 27, 2025
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 27, 2025
@grokspawn
Copy link
Contributor Author

/pj-rehearse pull-ci-operator-framework-operator-controller-main-build

@openshift-ci-robot
Copy link
Contributor

@grokspawn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 1, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 1, 2025

@grokspawn: This pull request references OPRUN-3742 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Solves

Adds prow/tide config to the repo so we can support separate reviewer/approver tiers.

Apologies for the churn. I initially attempted to include ci-operator in prow, but rolled it back. We'll handle this separately/later if we want to pursue it further.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 1, 2025

@grokspawn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/operator-framework/operator-controller/main/unit 9c4280f link unknown /pj-rehearse pull-ci-operator-framework-operator-controller-main-unit
ci/rehearse/operator-framework/operator-controller/main/e2e-upgrade 9c4280f link unknown /pj-rehearse pull-ci-operator-framework-operator-controller-main-e2e-upgrade
ci/rehearse/operator-framework/operator-controller/main/e2e 9c4280f link unknown /pj-rehearse pull-ci-operator-framework-operator-controller-main-e2e
ci/rehearse/operator-framework/operator-controller/main/verify 9c4280f link unknown /pj-rehearse pull-ci-operator-framework-operator-controller-main-verify
ci/rehearse/operator-framework/operator-controller/main/build e582490 link unknown /pj-rehearse pull-ci-operator-framework-operator-controller-main-build

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@grokspawn grokspawn changed the title WIP: OPRUN-3742: add operator-framework/operator-controller tide config OPRUN-3742: add operator-framework/operator-controller tide config Apr 1, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 1, 2025
@grokspawn grokspawn changed the title OPRUN-3742: add operator-framework/operator-controller tide config WIP: OPRUN-3742: add operator-framework/operator-controller tide config Apr 8, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 8, 2025
@grokspawn grokspawn changed the title WIP: OPRUN-3742: add operator-framework/operator-controller tide config OPRUN-3742: add operator-framework/operator-controller tide config Apr 10, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 10, 2025
this implements only branch merge admission and CI coordination, not any
ci-operator CI

Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
@grokspawn
Copy link
Contributor Author

now rebased to master/HEAD

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@grokspawn: no rehearsable tests are affected by this change

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@grokspawn: no rehearsable tests are affected by this change

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

- do-not-merge/hold
- do-not-merge/invalid-owners-file
- do-not-merge/work-in-progress
- jira/invalid-bug
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have jira integration?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That plugin is not enabled here.
I didn't figure that we needed to ignore/omit the label, since these are "do not merge if present" label lists.

@dtfranz
Copy link
Contributor

dtfranz commented May 5, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtfranz, grokspawn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit d5aff16 into openshift:master May 5, 2025
10 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 5, 2025

@grokspawn: Updated the following 2 configmaps:

  • plugins configmap in namespace ci at cluster app.ci using the following files:
    • key core-services-prow-02_config-operator-framework-operator-controller-_pluginconfig.yaml using file core-services/prow/02_config/operator-framework/operator-controller/_pluginconfig.yaml
  • config configmap in namespace ci at cluster app.ci using the following files:
    • key core-services-prow-02_config-operator-framework-operator-controller-_prowconfig.yaml using file core-services/prow/02_config/operator-framework/operator-controller/_prowconfig.yaml

In response to this:

Solves

Adds prow/tide config to the repo so we can support separate reviewer/approver tiers.

Apologies for the churn. I initially attempted to include ci-operator in prow, but rolled it back. We'll handle this separately/later if we want to pursue it further.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tbuskey pushed a commit to tbuskey/release that referenced this pull request May 19, 2025
…penshift#63229)

* add operator-framework/operator-controller tide config

this implements only branch merge admission and CI coordination, not any
ci-operator CI

Signed-off-by: Jordan Keister <jordan@nimblewidget.com>

* review resolution

Signed-off-by: Jordan Keister <jordan@nimblewidget.com>

---------

Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants