Skip to content

[operator-controller-release]: remove catalogd/testdata #61681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2025
Merged

[operator-controller-release]: remove catalogd/testdata #61681

merged 1 commit into from
Feb 20, 2025

Conversation

@camilamacedo86
Copy link
Contributor

No description provided.

@camilamacedo86 camilamacedo86 mentioned this pull request Feb 14, 2025
Merged
tmshort
tmshort approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@tmshort
Copy link
Contributor

tmshort commented Feb 14, 2025

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@tmshort: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 14, 2025
@camilamacedo86
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-operator-framework-operator-controller-main-openshift-e2e-aws

@openshift-ci-robot
Copy link
Contributor

@camilamacedo86: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tmshort
Copy link
Contributor

tmshort commented Feb 17, 2025

This needs to wait for operator-framework/operator-controller#1780 to downstream
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2025
@LalatenduMohanty
Copy link
Member

/retest

@camilamacedo86
Copy link
Contributor Author

/hold cancel

We can move now

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 19, 2025
@camilamacedo86
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-operator-framework-operator-controller-main-openshift-e2e-aws

@openshift-ci-robot
Copy link
Contributor

@camilamacedo86: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tmshort
Copy link
Contributor

tmshort commented Feb 19, 2025

/pj-rehearse pull-ci-openshift-operator-framework-operator-controller-main-openshift-e2e-aws

@openshift-ci-robot
Copy link
Contributor

@tmshort: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@camilamacedo86 camilamacedo86 force-pushed the remove-testdata-catalogd branch from 87f7878 to 575e89c Compare February 19, 2025 17:22
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2025
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@camilamacedo86: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-operator-framework-operator-controller-main-images openshift/operator-framework-operator-controller presubmit Ci-operator config changed
pull-ci-openshift-operator-framework-operator-controller-main-okd-scos-e2e-aws-ovn openshift/operator-framework-operator-controller presubmit Ci-operator config changed
pull-ci-openshift-operator-framework-operator-controller-main-okd-scos-images openshift/operator-framework-operator-controller presubmit Ci-operator config changed
pull-ci-openshift-operator-framework-operator-controller-main-openshift-e2e-aws openshift/operator-framework-operator-controller presubmit Ci-operator config changed
pull-ci-openshift-operator-framework-operator-controller-main-unit openshift/operator-framework-operator-controller presubmit Ci-operator config changed
pull-ci-openshift-operator-framework-operator-controller-main-verify openshift/operator-framework-operator-controller presubmit Ci-operator config changed
pull-ci-openshift-operator-framework-operator-controller-main-verify-commits openshift/operator-framework-operator-controller presubmit Ci-operator config changed
pull-ci-openshift-operator-framework-operator-controller-main-verify-deps openshift/operator-framework-operator-controller presubmit Ci-operator config changed
pull-ci-openshift-operator-framework-operator-controller-release-4.20-images openshift/operator-framework-operator-controller presubmit Ci-operator config changed
pull-ci-openshift-operator-framework-operator-controller-release-4.20-openshift-e2e-aws openshift/operator-framework-operator-controller presubmit Ci-operator config changed
pull-ci-openshift-operator-framework-operator-controller-release-4.20-unit openshift/operator-framework-operator-controller presubmit Ci-operator config changed
pull-ci-openshift-operator-framework-operator-controller-release-4.20-verify openshift/operator-framework-operator-controller presubmit Ci-operator config changed
pull-ci-openshift-operator-framework-operator-controller-release-4.20-verify-commits openshift/operator-framework-operator-controller presubmit Ci-operator config changed
pull-ci-openshift-operator-framework-operator-controller-release-4.20-verify-deps openshift/operator-framework-operator-controller presubmit Ci-operator config changed
pull-ci-openshift-operator-framework-operator-controller-release-4.19-images openshift/operator-framework-operator-controller presubmit Ci-operator config changed
pull-ci-openshift-operator-framework-operator-controller-release-4.19-openshift-e2e-aws openshift/operator-framework-operator-controller presubmit Ci-operator config changed
pull-ci-openshift-operator-framework-operator-controller-release-4.19-unit openshift/operator-framework-operator-controller presubmit Ci-operator config changed
pull-ci-openshift-operator-framework-operator-controller-release-4.19-verify openshift/operator-framework-operator-controller presubmit Ci-operator config changed
pull-ci-openshift-operator-framework-operator-controller-release-4.19-verify-commits openshift/operator-framework-operator-controller presubmit Ci-operator config changed
pull-ci-openshift-operator-framework-operator-controller-release-4.19-verify-deps openshift/operator-framework-operator-controller presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@tmshort
Copy link
Contributor

tmshort commented Feb 19, 2025

/pj-rehearse pull-ci-openshift-operator-framework-operator-controller-main-openshift-e2e-aws

@openshift-ci-robot
Copy link
Contributor

@tmshort: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tmshort
Copy link
Contributor

tmshort commented Feb 19, 2025

I don't believe you need to modify files in openshift-priv...

@tmshort
Copy link
Contributor

tmshort commented Feb 19, 2025

Looks as though the upstream e2e passed, but still have to get through the rest of it.

@tmshort
Copy link
Contributor

tmshort commented Feb 19, 2025

Since this now changes 4.19/4.20/main...
/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@tmshort: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tmshort
Copy link
Contributor

tmshort commented Feb 20, 2025

/pj-rehearse pull-ci-openshift-operator-framework-operator-controller-main-okd-scos-e2e-aws-ovn

@openshift-ci-robot
Copy link
Contributor

@tmshort: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tmshort
Copy link
Contributor

tmshort commented Feb 20, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tmshort
Copy link
Contributor

tmshort commented Feb 20, 2025 •
edited
Loading

The ci/rehearse/openshift/operator-framework-operator-controller/main/okd-scos-e2e-aws-ovn failure seems related to checking certificates (there's a special test for it, and I believe it's flakey), and it shouldn't be required?
All other rehearsals are passing.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 20, 2025

@tmshort: The label(s) /label rehearsal-ack cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

The ci/rehearse/openshift/operator-framework-operator-controller/main/okd-scos-e2e-aws-ovn failure seems related to checking certificates (there's a special test for it, and I believe it's flakey), and it shouldn't be required?
/label rehearsal-ack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tmshort
Copy link
Contributor

tmshort commented Feb 20, 2025

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@tmshort: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 20, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit ed9149d into openshift:master Feb 20, 2025
17 of 18 checks passed
lihongyan1 pushed a commit to lihongyan1/release that referenced this pull request Feb 20, 2025
@camilamacedo86 @lihongyan1
[operator-controller-release]: remove catalogd/testdata (openshift#61681
dca60d9 
)
@camilamacedo86 camilamacedo86 deleted the remove-testdata-catalogd branch February 20, 2025 09:05
phani2898 pushed a commit to phani2898/release that referenced this pull request Feb 26, 2025
@camilamacedo86 @phani2898
[operator-controller-release]: remove catalogd/testdata (openshift#61681
7e45b02 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hector-vido hector-vido Awaiting requested review from hector-vido

@oceanc80 oceanc80 Awaiting requested review from oceanc80

1 more reviewer

@tmshort tmshort tmshort approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tmshort tmshort

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@camilamacedo86 @tmshort @openshift-ci-robot @LalatenduMohanty