Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OCP 4.19 chain upgrade jobs - part 1 #59758

Merged

Conversation

JianLi-RH
Copy link
Contributor

@JianLi-RH JianLi-RH commented Dec 11, 2024

JIRA card: https://issues.redhat.com/browse/OCPQE-27546

In this PR, I added 4.17 -> 4.19 nightly upgrade jobs.
Once OCP 4.18 is GAed, I will submit another PR to:

  1. Move ocp 4.18 chain upgrade jobs to 4.19
  2. Add a 4.17 -> 4.19 stable upgrade job.

OCP 4.19 chain upgrade test matrix can be found in https://docs.google.com/spreadsheets/d/12NAZtZas0cHBjO3BlpdM_AuUaoYin7Na68K7SrEHvkA/edit?gid=1856920494#gid=1856920494

/cc @jhou1 @jiajliu @dis016 @jianlinliu @liangxia

@JianLi-RH
Copy link
Contributor Author

/pj-rehears periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-4.19-upgrade-from-stable-4.17-ibmcloud-ipi-ovn-ipsec-f28

@JianLi-RH
Copy link
Contributor Author

/pj-rehears periodic-ci-openshift-openshift-tests-private-release-4.19-arm64-nightly-4.19-upgrade-from-stable-4.17-baremetal-upi-ovn-ipv4-f28

@JianLi-RH
Copy link
Contributor Author

/pj-rehears periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-4.19-upgrade-from-stable-4.17-ibmcloud-ipi-ovn-ipsec-f28

1 similar comment
@JianLi-RH
Copy link
Contributor Author

/pj-rehears periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-4.19-upgrade-from-stable-4.17-ibmcloud-ipi-ovn-ipsec-f28

@JianLi-RH
Copy link
Contributor Author

/pj-rehears periodic-ci-openshift-openshift-tests-private-release-4.19-arm64-nightly-4.19-upgrade-from-stable-4.17-baremetal-upi-ovn-ipv4-f28

@JianLi-RH
Copy link
Contributor Author

/pj-rehears periodic-ci-openshift-openshift-tests-private-release-4.19-multi-nightly-4.19-upgrade-from-stable-4.17-azure-ipi-sno-etcd-encryption-arm-f28

@JianLi-RH
Copy link
Contributor Author

/pj-rehears periodic-ci-openshift-openshift-tests-private-release-4.19-arm64-nightly-4.19-upgrade-from-stable-4.17-baremetal-upi-ovn-ipv4-f28

@JianLi-RH
Copy link
Contributor Author

/pj-rehears periodic-ci-openshift-openshift-tests-private-release-4.19-multi-nightly-4.19-upgrade-from-stable-4.17-azure-ipi-sno-etcd-encryption-arm-f28

@JianLi-RH
Copy link
Contributor Author

/pj-rehears periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-4.19-upgrade-from-stable-4.17-ibmcloud-ipi-ovn-ipsec-f28

@JianLi-RH
Copy link
Contributor Author

hi all, I don't know why rehears jobs could not be triggered, but I think this PR do not really need to run test jobs, so could we merge this without a test job?

@JianLi-RH
Copy link
Contributor Author

/assign @jhou1 @jiajliu @dis016 @jianlinliu @liangxia

@liangxia
Copy link
Member

hi all, I don't know why rehears jobs could not be triggered, but I think this PR do not really need to run test jobs, so could we merge this without a test job?

I think there is a typo in your comment. It should be /pj-rehearse job-name-here

@JianLi-RH
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.19-arm64-nightly-4.19-upgrade-from-stable-4.17-baremetal-upi-ovn-ipv4-f28

@openshift-ci-robot
Copy link
Contributor

@JianLi-RH: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@JianLi-RH
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.19-multi-nightly-4.19-upgrade-from-stable-4.17-azure-ipi-sno-etcd-encryption-arm-f28

@openshift-ci-robot
Copy link
Contributor

@JianLi-RH: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@JianLi-RH
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-4.19-upgrade-from-stable-4.17-ibmcloud-ipi-ovn-ipsec-f28

@openshift-ci-robot
Copy link
Contributor

@JianLi-RH: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@JianLi-RH
Copy link
Contributor Author

I think there is a typo in your comment. It should be /pj-rehearse job-name-here

Oh, yes, copied it and missed a e

masters: "3"
workers: "2"
test:
- ref: cucushift-upgrade-setedge-2hops
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same issue as in 4.18 #58626 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I will submit a commit once rehearse jobs finished

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no change.

The reason of your job get passed is that, though cucushift-upgrade-setedge-2hops is setting a wrong arch of target payload (expecting an arm arch payload), cucushift-upgrade-drop-last-hop in openshift-upgrade-qe-test-chainupgrade chain will drop the wrong target payload edge, so the chain upgrade workaround the issue.

While if we run stable -> stable chain upgrade for arm ci, the wrong target payload setting would bring some problems.

The cleanest and ideal solution is something like #58433 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, I see, the target version (final version) in cucushift-upgrade-setedge-2hops is not correct. I will use the original way to run arm jobs.
Thanks @jianlinliu

@JianLi-RH
Copy link
Contributor Author

/retest-required

@JianLi-RH
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@JianLi-RH: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@JianLi-RH: job(s): , ack either don't exist or were not found to be affected, and cannot be rehearsed

@JianLi-RH
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@JianLi-RH: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 13, 2024
@jiajliu
Copy link
Contributor

jiajliu commented Dec 13, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2024
@JianLi-RH JianLi-RH force-pushed the 4.19_chain_upgrade_part1 branch from 657d9fd to 6f59ee1 Compare December 13, 2024 07:35
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2024
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 13, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@JianLi-RH: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-openshift-tests-private-release-4.19-multi-nightly-4.19-upgrade-from-stable-4.17-gcp-ipi-ovn-ipsec-arm-mixarch-f28 N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.19-multi-nightly-4.19-upgrade-from-stable-4.17-aws-ipi-proxy-sts-arm-f28 N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-4.19-upgrade-from-stable-4.17-vsphere-ipi-ovn-dualstack-privmaryv6-f28 N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.19-multi-nightly-4.19-upgrade-from-stable-4.17-azure-ipi-sno-etcd-encryption-arm-f28 N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-4.19-upgrade-from-stable-4.17-nutanix-ipi-proxy-fips-mini-perm-f28 N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.19-multi-nightly-4.19-upgrade-from-stable-4.17-aws-upi-basecap-none-arm-f28 N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.19-arm64-nightly-4.19-upgrade-from-stable-4.17-baremetal-upi-ovn-ipv4-f28 N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-4.19-upgrade-from-stable-4.17-ibmcloud-ipi-ovn-ipsec-f28 N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@JianLi-RH
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@JianLi-RH: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 13, 2024
@jiajliu
Copy link
Contributor

jiajliu commented Dec 13, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2024
Copy link
Contributor

openshift-ci bot commented Dec 13, 2024

@JianLi-RH: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.19-multi-nightly-4.19-upgrade-from-stable-4.17-azure-ipi-sno-etcd-encryption-arm-f28 7e4bfb8 link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.19-multi-nightly-4.19-upgrade-from-stable-4.17-azure-ipi-sno-etcd-encryption-arm-f28
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-4.19-upgrade-from-stable-4.17-ibmcloud-ipi-ovn-ipsec-f28 7e4bfb8 link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-4.19-upgrade-from-stable-4.17-ibmcloud-ipi-ovn-ipsec-f28
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.19-arm64-nightly-4.19-upgrade-from-stable-4.17-baremetal-upi-ovn-ipv4-f28 657d9fd link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.19-arm64-nightly-4.19-upgrade-from-stable-4.17-baremetal-upi-ovn-ipv4-f28

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@JianLi-RH
Copy link
Contributor Author

@jhou1 @liangxia please help review, thanks

@JianLi-RH
Copy link
Contributor Author

@jhou1 @liangxia Please help review it.

@liangxia
Copy link
Member

/approve

Copy link
Contributor

openshift-ci bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiajliu, JianLi-RH, liangxia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit e467067 into openshift:master Dec 16, 2024
15 checks passed
@JianLi-RH JianLi-RH deleted the 4.19_chain_upgrade_part1 branch December 16, 2024 11:15
yingzhanredhat pushed a commit to yingzhanredhat/release that referenced this pull request Dec 18, 2024
yingzhanredhat pushed a commit to yingzhanredhat/release that referenced this pull request Dec 24, 2024
krishvoor pushed a commit to krishvoor/release that referenced this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants