-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OCP 4.19 chain upgrade jobs - part 1 #59758
Add OCP 4.19 chain upgrade jobs - part 1 #59758
Conversation
/pj-rehears periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-4.19-upgrade-from-stable-4.17-ibmcloud-ipi-ovn-ipsec-f28 |
/pj-rehears periodic-ci-openshift-openshift-tests-private-release-4.19-arm64-nightly-4.19-upgrade-from-stable-4.17-baremetal-upi-ovn-ipv4-f28 |
/pj-rehears periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-4.19-upgrade-from-stable-4.17-ibmcloud-ipi-ovn-ipsec-f28 |
1 similar comment
/pj-rehears periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-4.19-upgrade-from-stable-4.17-ibmcloud-ipi-ovn-ipsec-f28 |
/pj-rehears periodic-ci-openshift-openshift-tests-private-release-4.19-arm64-nightly-4.19-upgrade-from-stable-4.17-baremetal-upi-ovn-ipv4-f28 |
/pj-rehears periodic-ci-openshift-openshift-tests-private-release-4.19-multi-nightly-4.19-upgrade-from-stable-4.17-azure-ipi-sno-etcd-encryption-arm-f28 |
/pj-rehears periodic-ci-openshift-openshift-tests-private-release-4.19-arm64-nightly-4.19-upgrade-from-stable-4.17-baremetal-upi-ovn-ipv4-f28 |
/pj-rehears periodic-ci-openshift-openshift-tests-private-release-4.19-multi-nightly-4.19-upgrade-from-stable-4.17-azure-ipi-sno-etcd-encryption-arm-f28 |
/pj-rehears periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-4.19-upgrade-from-stable-4.17-ibmcloud-ipi-ovn-ipsec-f28 |
hi all, I don't know why rehears jobs could not be triggered, but I think this PR do not really need to run test jobs, so could we merge this without a test job? |
/assign @jhou1 @jiajliu @dis016 @jianlinliu @liangxia |
I think there is a typo in your comment. It should be |
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.19-arm64-nightly-4.19-upgrade-from-stable-4.17-baremetal-upi-ovn-ipv4-f28 |
@JianLi-RH: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.19-multi-nightly-4.19-upgrade-from-stable-4.17-azure-ipi-sno-etcd-encryption-arm-f28 |
@JianLi-RH: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-4.19-upgrade-from-stable-4.17-ibmcloud-ipi-ovn-ipsec-f28 |
@JianLi-RH: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Oh, yes, copied it and missed a |
masters: "3" | ||
workers: "2" | ||
test: | ||
- ref: cucushift-upgrade-setedge-2hops |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same issue as in 4.18 #58626 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I will submit a commit once rehearse jobs finished
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jianlinliu @liangxia @jiajliu Do we have any change on arm arch? Following job is using cucushift-upgrade-setedge-2hops
and seems work fine:
https://qe-private-deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gs/qe-private-deck/pr-logs/pull/openshift_release/59758/rehearse-59758-periodic-ci-openshift-openshift-tests-private-release-4.19-arm64-nightly-4.19-upgrade-from-stable-4.17-baremetal-upi-ovn-ipv4-f28/1867028618853486592
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no change.
The reason of your job get passed is that, though cucushift-upgrade-setedge-2hops
is setting a wrong arch of target payload (expecting an arm arch payload), cucushift-upgrade-drop-last-hop
in openshift-upgrade-qe-test-chainupgrade
chain will drop the wrong target payload edge, so the chain upgrade workaround the issue.
While if we run stable -> stable chain upgrade for arm ci, the wrong target payload setting would bring some problems.
The cleanest and ideal solution is something like #58433 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, I see, the target version (final version) in cucushift-upgrade-setedge-2hops is not correct. I will use the original way to run arm jobs.
Thanks @jianlinliu
/retest-required |
/pj-rehearse ack |
@JianLi-RH: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
@JianLi-RH: job(s): , ack either don't exist or were not found to be affected, and cannot be rehearsed |
/pj-rehearse ack |
@JianLi-RH: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/lgtm |
657d9fd
to
6f59ee1
Compare
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
/pj-rehearse ack |
@JianLi-RH: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/lgtm |
@JianLi-RH: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiajliu, JianLi-RH, liangxia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
JIRA card: https://issues.redhat.com/browse/OCPQE-27546
In this PR, I added 4.17 -> 4.19 nightly upgrade jobs.
Once OCP 4.18 is GAed, I will submit another PR to:
OCP 4.19 chain upgrade test matrix can be found in https://docs.google.com/spreadsheets/d/12NAZtZas0cHBjO3BlpdM_AuUaoYin7Na68K7SrEHvkA/edit?gid=1856920494#gid=1856920494
/cc @jhou1 @jiajliu @dis016 @jianlinliu @liangxia