Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stackrox: Add OCP 4.17 ppc64le target and rename existing ones #58043

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mdafsanhossain
Copy link
Contributor

  • Add 4.17 ppc64le target.
  • Rename existing jobs to make them consistent.

Signed-off-by: Afsan Hossain <Mdafsan.Hossain@ibm.com>
Signed-off-by: mdafsanhossain <Mdafsan.Hossain@ibm.com>
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 22, 2024
Copy link
Contributor

openshift-ci bot commented Oct 22, 2024

Hi @mdafsanhossain. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Oct 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mdafsanhossain
Once this PR has been reviewed and has the lgtm label, please assign danalanerh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@mdafsanhossain: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-stackrox-stackrox-master-powervs-4-16-qa-corebpf-e2e-tests stackrox/stackrox presubmit Presubmit changed
pull-ci-stackrox-stackrox-master-powervs-4-17-qa-corebpf-e2e-tests stackrox/stackrox presubmit Presubmit changed
periodic-ci-stackrox-stackrox-master-daily-powervs-416-corebpf-qa-e2e-tests N/A periodic Periodic changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@mdafsanhossain
Copy link
Contributor Author

/cc @davdhacs

@openshift-ci openshift-ci bot requested a review from davdhacs October 23, 2024 06:05
@mdafsanhossain
Copy link
Contributor Author

/uncc @Sau1506mya

@openshift-ci openshift-ci bot removed the request for review from Sau1506mya October 23, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants