Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add approver for hypershift qe directory #53477

Merged
merged 1 commit into from
Jun 20, 2024
Merged

add approver for hypershift qe directory #53477

merged 1 commit into from
Jun 20, 2024

Conversation

heliubj18
Copy link
Contributor

add feilian xie as hypershift qe approver

@heliubj18 heliubj18 changed the title add approver add approver for hypershift qe directory Jun 20, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2024
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 20, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@heliubj18: no rehearsable tests are affected by this change

@YuLi517
Copy link

YuLi517 commented Jun 20, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: heliubj18, YuLi517

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fxierh
Copy link
Contributor

fxierh commented Jun 20, 2024

Thank you both.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 20, 2024

@heliubj18: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 25df558 into openshift:master Jun 20, 2024
12 checks passed
JianLi-RH pushed a commit to JianLi-RH/release that referenced this pull request Jul 2, 2024
@heliubj18 @JianLi-RH
add approver (openshift#53477)
e79e5ca
jtaleric pushed a commit to jtaleric/release that referenced this pull request Jul 15, 2024
@heliubj18
add approver (openshift#53477)
0930771
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiangquanLi930 LiangquanLi930 Awaiting requested review from LiangquanLi930

@xueqzhan xueqzhan Awaiting requested review from xueqzhan

Assignees

@YuLi517 YuLi517

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@heliubj18 @openshift-ci-robot @YuLi517 @fxierh