Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nutanix os image step #52204

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Add nutanix os image step #52204

merged 1 commit into from
Jun 5, 2024

Conversation

sgaoshang
Copy link
Contributor

No description provided.

@sgaoshang
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-nutanix-ipi-proxy-fips-mini-perm-f28

@openshift-ci-robot
Copy link
Contributor

@sgaoshang: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

jianlinliu
jianlinliu reviewed May 20, 2024
View reviewed changes
ci-operator/step-registry/ipi/conf/osimage/nutanix/ipi-conf-osimage-nutanix-commands.sh Outdated

if [[ -z ${CLUSTER_OS_IMAGE} ]]; then
echo "Get default clusterOSImage"
CLUSTER_OS_IMAGE=$(curl -s 'https://raw.githubusercontent.com/openshift/installer/master/data/data/coreos/rhcos.json' | jq -r '.architectures.x86_64.artifacts.nutanix.formats.qcow2.disk.location')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use openshift-install coreos print-stream-json to get the default os image instead of curling in the installer repo's master branch.

@sgaoshang
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-nutanix-ipi-proxy-fips-mini-perm-f28

@openshift-ci-robot
Copy link
Contributor

@sgaoshang: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@sgaoshang, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not determine changed registry steps: could not load step registry: failed to load registry file /var/tmp/gitrepo3195101754/ci-operator/step-registry/ipi/conf/osimage/nutanix/ipi-conf-osimage-nutanix-ref.yaml: error converting YAML to JSON: yaml: line 4: mapping values are not allowed in this context
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@sgaoshang
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-nutanix-ipi-proxy-fips-mini-perm-f28

@openshift-ci-robot
Copy link
Contributor

@sgaoshang: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

jianlinliu
jianlinliu reviewed May 20, 2024
View reviewed changes
ci-operator/step-registry/ipi/conf/osimage/nutanix/ipi-conf-osimage-nutanix-commands.sh Outdated

if [[ -z ${CLUSTER_OS_IMAGE} ]]; then
echo "Get default clusterOSImage"
CLUSTER_OS_IMAGE=$(openshift-install coreos print-stream-json | jq -r '.architectures.x86_64.artifacts.nutanix.formats.qcow2.disk.location')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you need to use python command to load the json file to workaround jq missing issue in installer image, something like

release/ci-operator/step-registry/aws-load-balancer/pre-install-rosa/aws-load-balancer-pre-install-rosa-commands.sh

Line 75 in e747ed8

cat ${CI_REGISTRY_PULL_SECRET} | python3 -c 'import json,sys

But one more concern is if we always use the default boot image from installer to customize the cluster OS image, I did not see the difference compared with the case that we did not set any value for cluster OS image. I think installer always use the same way to get the OS image to boot the cluster installation when no any customization setting.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to cover the clusterOSImage field in install config, the logic is different by setting it or not, the value of it doesn't matter to much. Or what would you suggest, maintain an httpd server for downloading it? is there existing ones?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the logic is different by setting it or not, the value of it doesn't matter to much

If not set, what is the default os image? From my understanding, if not setting, installer would going to download the same version of disk as the output of openshift-install coreos print-stream-json.

Or what would you suggest, maintain an httpd server for downloading it.

I guess you are focus on testing where to download the image, but actually I am concerning what version of disk is being downloading. Just like what I explained, openshift-install coreos print-stream-json would print out different version of disk image by different version of installer, that means, the disk image version vary time by time. If you want to test clusterOSImage, I would suggest always need to set CLUSTER_OS_IMAGE on the job when the step is referenced, but never feed a default value. E.g: get a disk image url from openshift-install coreos print-stream-json using an older version of installer.

@sgaoshang
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-verification-tests-master-installation-nightly-4.16-nutanix-ipi-zones-single-f28

@openshift-ci-robot
Copy link
Contributor

@sgaoshang: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@sgaoshang
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-verification-tests-master-installation-nightly-4.16-nutanix-ipi-zones-single-f28

@openshift-ci-robot
Copy link
Contributor

@sgaoshang: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

jianlinliu
jianlinliu reviewed May 22, 2024
View reviewed changes
...cushift/installer/check/nutanix/os-image/cucushift-installer-check-nutanix-os-image-ref.yaml Outdated
cpu: 10m
memory: 100Mi
env:
- name: SINGLE_ZONE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not need this env, right ?

@sgaoshang
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-verification-tests-master-installation-nightly-4.16-nutanix-ipi-zones-single-f28

@openshift-ci-robot
Copy link
Contributor

@sgaoshang: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@sgaoshang
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-verification-tests-master-installation-nightly-4.16-nutanix-ipi-zones-single-f28

@openshift-ci-robot
Copy link
Contributor

@sgaoshang: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@sgaoshang
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-verification-tests-master-installation-nightly-4.16-nutanix-ipi-zones-single-f28

@openshift-ci-robot
Copy link
Contributor

@sgaoshang: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@sgaoshang
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-verification-tests-master-installation-nightly-4.16-nutanix-ipi-zones-single-f28

@openshift-ci-robot
Copy link
Contributor

@sgaoshang: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@sgaoshang sgaoshang marked this pull request as draft May 22, 2024 05:59
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 22, 2024
@sgaoshang
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-verification-tests-master-installation-nightly-4.16-nutanix-ipi-zones-single-f28

@openshift-ci openshift-ci bot requested review from gpei and jianlinliu June 4, 2024 03:08
@openshift-ci-robot
Copy link
Contributor

@sgaoshang: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@sgaoshang
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-verification-tests-master-installation-nightly-4.16-nutanix-ipi-zones-single-f28

@openshift-ci-robot
Copy link
Contributor

@sgaoshang: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@sgaoshang
Copy link
Contributor Author

sgaoshang commented Jun 4, 2024 •
edited
Loading

@jianlinliu pls help to review it, thanks. Now it will use rhcos version specified in job env and check it later.

- as: nutanix-ipi-zones-single-f28
  cluster: build01
  cron: 27 16 16 * *
  steps:
    cluster_profile: nutanix-qe-zone
    env:
      CLUSTER_OS_IMAGE: https://rhcos.mirror.openshift.com/art/storage/prod/streams/4.16-9.4/builds/416.94.202405171948-0/x86_64/rhcos-416.94.202405171948-0-nutanix.x86_64.qcow2

@sgaoshang
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-verification-tests-master-installation-nightly-4.16-nutanix-ipi-zones-single-f28

@openshift-ci-robot
Copy link
Contributor

@sgaoshang: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

jianlinliu
jianlinliu reviewed Jun 4, 2024
View reviewed changes
...shift/verification-tests/openshift-verification-tests-master__installation-nightly-4.16.yaml
@@ -303,6 +303,7 @@ tests:
steps:
cluster_profile: nutanix-qe-zone
env:
CLUSTER_OS_IMAGE: https://rhcos.mirror.openshift.com/art/storage/prod/streams/4.16-9.4/builds/416.94.202405171948-0/x86_64/rhcos-416.94.202405171948-0-nutanix.x86_64.qcow2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest to rename job name to reflect the coverage for your test point.

@jianlinliu
Copy link
Contributor

Do we have a passed job now?

@sgaoshang
Copy link
Contributor Author

Do we have a passed job now?
yes, see here https://qe-private-deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gs/qe-private-deck/pr-logs/pull/openshift_release/52204/rehearse-52204-periodic-ci-openshift-verification-tests-master-installation-nightly-4.16-nutanix-ipi-zones-single-f28/1797828462392643584

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@sgaoshang: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-nutanix-ipi-zones-f14-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-nutanix-ipi-zones-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.17-amd64-nightly-nutanix-ipi-zones-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-4.16-upgrade-from-stable-4.16-nutanix-ipi-zones-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.15-amd64-nightly-nutanix-ipi-zones-f14 N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-master-installation-nightly-4.16-nutanix-ipi-zones-single-os-image-f28 N/A periodic Periodic changed
periodic-ci-openshift-verification-tests-master-installation-nightly-4.15-nutanix-ipi-zones-single-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-4.16-upgrade-from-stable-4.15-nutanix-ipi-zones-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.15-amd64-nightly-nutanix-ipi-zones-f14-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.17-amd64-nightly-nutanix-ipi-zones-f14-destructive N/A periodic Registry content changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@sgaoshang
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-verification-tests-master-installation-nightly-4.16-nutanix-ipi-zones-single-os-image-f28

@openshift-ci-robot
Copy link
Contributor

@sgaoshang: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jianlinliu
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jianlinliu, sgaoshang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2024
@sgaoshang
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-verification-tests-master-installation-nightly-4.16-nutanix-ipi-zones-single-os-image-f28

@openshift-ci-robot
Copy link
Contributor

@sgaoshang: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@sgaoshang
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@sgaoshang: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 5, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 5, 2024

@sgaoshang: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-nutanix-ipi-proxy-fips-mini-perm-f28 e747ed8 link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-nutanix-ipi-proxy-fips-mini-perm-f28
ci/rehearse/periodic-ci-openshift-verification-tests-master-installation-nightly-4.15-nutanix-ipi-zones-single-f28 b9a0fb3 link unknown /pj-rehearse periodic-ci-openshift-verification-tests-master-installation-nightly-4.15-nutanix-ipi-zones-single-f28
ci/rehearse/periodic-ci-openshift-verification-tests-master-installation-nightly-4.16-nutanix-ipi-zones-single-f28 707b802 link unknown /pj-rehearse periodic-ci-openshift-verification-tests-master-installation-nightly-4.16-nutanix-ipi-zones-single-f28

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 8263ae7 into openshift:master Jun 5, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianlinliu jianlinliu jianlinliu left review comments

@jinyunma jinyunma Awaiting requested review from jinyunma

@gpei gpei Awaiting requested review from gpei

Assignees

@jianlinliu jianlinliu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sgaoshang @openshift-ci-robot @jianlinliu