Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add rosa hcp cilium CNI support #49181

Merged
merged 5 commits into from
Feb 28, 2024
Merged

add rosa hcp cilium CNI support #49181

merged 5 commits into from
Feb 28, 2024

Conversation

heliubj18
Copy link
Contributor

support rosa hcp cilium CNI

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 26, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 26, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@heliubj18
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.15-amd64-nightly-aws-rosa-sts-hcp-cilium-stage-full-f2

@openshift-ci-robot
Copy link
Contributor

@heliubj18: job(s): either don't exist or were not found to be affected, and cannot be rehearsed

@heliubj18 heliubj18 force-pushed the cilium-hcp-ci-support branch 2 times, most recently from e19d125 to 109c1f7 Compare February 26, 2024 06:56
@heliubj18
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.15-amd64-nightly-aws-rosa-sts-hcp-cilium-stage-full-f2

@heliubj18
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.15-amd64-nightly-aws-rosa-sts-hcp-cilium-stage-full-f2

@heliubj18
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.15-amd64-nightly-aws-rosa-sts-hcp-cilium-stage-full-f2

@heliubj18 heliubj18 marked this pull request as ready for review February 26, 2024 12:50
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 26, 2024
@heliubj18
Copy link
Contributor Author

@yasun1 could you please help to review this pr? cc @YiqinZhang @LiangquanLi930

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 28, 2024
@openshift-ci-robot
Copy link
Contributor

@heliubj18, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't rebase candidate onto master: %!w(<nil>)
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@heliubj18
Copy link
Contributor Author

/hold
update by comments

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 28, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 28, 2024
@heliubj18
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.15-amd64-nightly-aws-rosa-sts-hcp-cilium-stage-full-f2

@heliubj18
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.15-amd64-nightly-aws-rosa-non-sts-advanced-f7

@heliubj18
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.15-amd64-nightly-aws-rosa-sts-hcp-cilium-stage-full-f2

@heliubj18
Copy link
Contributor Author

/pj-rehearse abort

@heliubj18
Copy link
Contributor Author

@yasun1 could you please help to continue to review it? thx

@heliubj18
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 28, 2024
@heliubj18
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 28, 2024
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 28, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@heliubj18: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-rosa-4.12-nightly-x86-cluster-density-v2-3nodes openshift-qe/ocp-qe-perfscale-ci presubmit Registry content changed
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-rosa-4.12-nightly-x86-data-path-9nodes openshift-qe/ocp-qe-perfscale-ci presubmit Registry content changed
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-rosa-4.13-nightly-x86-control-plane-3nodes openshift-qe/ocp-qe-perfscale-ci presubmit Registry content changed
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-rosa-4.13-nightly-x86-node-density-heavy-3nodes openshift-qe/ocp-qe-perfscale-ci presubmit Registry content changed
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-rosa-4.13-nightly-x86-router-perf-3nodes openshift-qe/ocp-qe-perfscale-ci presubmit Registry content changed
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-rosa_hcp-4.15-ec-x86-control-plane-24nodes openshift-qe/ocp-qe-perfscale-ci presubmit Registry content changed
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-rosa_hcp-4.15-ec-x86-node-density-heavy-24nodes openshift-qe/ocp-qe-perfscale-ci presubmit Registry content changed
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-rosa_hcp-4.15-ec-x86-node-density-cni-24nodes openshift-qe/ocp-qe-perfscale-ci presubmit Registry content changed
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-rosa_hcp-4.15-nightly-x86-control-plane-3nodes openshift-qe/ocp-qe-perfscale-ci presubmit Registry content changed
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-rosa_hcp-4.15-ec-x86-data-path-9nodes openshift-qe/ocp-qe-perfscale-ci presubmit Registry content changed
pull-ci-CSPI-QE-MSI-single-cluster-smoke-v4.14-single-cluster-rosa-4-14-candidate-smoke CSPI-QE/MSI presubmit Registry content changed
pull-ci-openshift-aws-load-balancer-operator-main-e2e-aws-rosa-operator openshift/aws-load-balancer-operator presubmit Registry content changed
pull-ci-openshift-aws-load-balancer-operator-release-1.0-e2e-aws-rosa-operator openshift/aws-load-balancer-operator presubmit Registry content changed
pull-ci-openshift-aws-load-balancer-operator-release-1.1-e2e-aws-rosa-operator openshift/aws-load-balancer-operator presubmit Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-aws-rosa-sts-hcp-int-full-f7 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.15-amd64-nightly-aws-rosa-sts-hcp-private-link-int-full-f7 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-aws-rosa-sts-f360 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-aws-rosa-sts-shared-vpc-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-aws-rosa-sts-hcp-advanced-int-full-f360 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-master-rosacli-aws-rosa-hcp-e2e-f3 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-stable-aws-rosa-non-sts-advanced-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-ec-aws-rosa-non-sts-advanced-f7 N/A periodic Registry content changed
periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-rosa_hcp-4.15-nightly-x86-node-density-heavy-24nodes N/A periodic Registry content changed
periodic-ci-rhpit-interop-tests-main-web-terminal-hypershift-4.13-lp-rosa-hypershift-web-terminal-aws-rosa-hypershift N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.15-amd64-nightly-aws-rosa-sts-advanced-f7 N/A periodic Registry content changed

A total of 195 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@yasun1
Copy link
Contributor

yasun1 commented Feb 28, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2024
@heliubj18
Copy link
Contributor Author

heliubj18 commented Feb 28, 2024 •
edited
Loading

@liangxia Could you please help to review it? Thanks!
btw, the reason to set it f2 is that it is a critical task recently and I will change it to f7 or other available time slots in April.

@heliubj18
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 28, 2024
@liangxia
Copy link
Member

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: heliubj18, liangxia, yasun1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit d6704ad into openshift:master Feb 28, 2024
20 checks passed
memodi pushed a commit to memodi/release that referenced this pull request Mar 14, 2024
@heliubj18 @memodi
add rosa hcp cilium CNI support (openshift#49181)
7d86e57 
* add hcp cilium support

* update by comments

* make job after rebase upstream

* fix shell-check error

* update description
BradLugo pushed a commit to BradLugo/openshift-release that referenced this pull request Jun 13, 2024
@heliubj18 @BradLugo
add rosa hcp cilium CNI support (openshift#49181)
51fb642 
* add hcp cilium support

* update by comments

* make job after rebase upstream

* fix shell-check error

* update description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yasun1 yasun1 yasun1 left review comments

@LiangquanLi930 LiangquanLi930 Awaiting requested review from LiangquanLi930

@rioliu-rh rioliu-rh Awaiting requested review from rioliu-rh

Assignees

@yasun1 yasun1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@heliubj18 @openshift-ci-robot @yasun1 @liangxia @openshift-merge-robot