-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] keda e2e makefile target #46762
Conversation
/pj-rehearse pull-ci-jkyros-keda-e2e-makefile-target-keda-e2e-aws-ovn |
1 similar comment
/pj-rehearse pull-ci-jkyros-keda-e2e-makefile-target-keda-e2e-aws-ovn |
b670c42
to
6821fbb
Compare
/pj-rehearse pull-ci-jkyros-keda-e2e-makefile-target-keda-e2e-aws-ovn |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jkyros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
well that was unlucky and totally unrelated. Cluster just didn't finish. Let's try again. |
Kafka tests failed, haven't seen that before. I suppose it could be a 4.16 thing, but maybe a flake. |
so the kafka test is at least flaky. Let's see how flaky: |
6821fbb
to
8a7e9f8
Compare
kafka seemed fine, but had to split the targets because we use em in both the operator and the operand |
one more time before I PR the keda half |
/test yamllint |
/pj-rehearse pull-ci-jkyros-keda-e2e-makefile-target-keda-e2e-aws-ovn |
8a7e9f8
to
a46a1cd
Compare
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
/pj-rehearse pull-ci-jkyros-keda-e2e-makefile-target-keda-e2e-aws-ovn |
1 similar comment
/pj-rehearse pull-ci-jkyros-keda-e2e-makefile-target-keda-e2e-aws-ovn |
@jkyros: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/pj-rehearse pull-ci-jkyros-keda-e2e-makefile-target-keda-e2e-aws-ovn |
This was hackery against my jkyros branch, the real one merged in openshift/kedacore-keda#19, closing this. |
Ignore for now, just checking to see if it works against my branch.
Right now if we want to fix tests and then maybe add or remove them (which is something we may be doing a lot more of as we start supporting new scalers) we have to put up a CI PR because of how I configured the targets.
This:
Which should let us get instant feedback on test changes when we put up a keda PR instead of having to change in in keda, then come back here and change it.