Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] keda e2e makefile target #46762

Closed
wants to merge 1 commit into from

Conversation

jkyros
Copy link
Contributor

@jkyros jkyros commented Dec 13, 2023

Ignore for now, just checking to see if it works against my branch.

Right now if we want to fix tests and then maybe add or remove them (which is something we may be doing a lot more of as we start supporting new scalers) we have to put up a CI PR because of how I configured the targets.

This:

  • Uses our carried "openshift-test-e2e" Makefile target to run the tests
  • Uses the Dockerfile.tests dockerfile in the keda repo instead of the inlined Dockerfile

Which should let us get instant feedback on test changes when we put up a keda PR instead of having to change in in keda, then come back here and change it.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 13, 2023
@jkyros
Copy link
Contributor Author

jkyros commented Dec 13, 2023

/pj-rehearse pull-ci-jkyros-keda-e2e-makefile-target-keda-e2e-aws-ovn

1 similar comment
@jkyros
Copy link
Contributor Author

jkyros commented Dec 13, 2023

/pj-rehearse pull-ci-jkyros-keda-e2e-makefile-target-keda-e2e-aws-ovn

@jkyros
Copy link
Contributor Author

jkyros commented Dec 13, 2023

/pj-rehearse pull-ci-jkyros-keda-e2e-makefile-target-keda-e2e-aws-ovn

Copy link
Contributor

openshift-ci bot commented Dec 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkyros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2023
@jkyros
Copy link
Contributor Author

jkyros commented Dec 14, 2023

well that was unlucky and totally unrelated. Cluster just didn't finish. Let's try again.
/pj-rehearse pull-ci-jkyros-keda-e2e-makefile-target-keda-e2e-aws-ovn

@jkyros
Copy link
Contributor Author

jkyros commented Dec 14, 2023

Kafka tests failed, haven't seen that before. I suppose it could be a 4.16 thing, but maybe a flake.
/pj-rehearse pull-ci-jkyros-keda-e2e-makefile-target-keda-e2e-aws-ovn

@jkyros
Copy link
Contributor Author

jkyros commented Dec 14, 2023

so the kafka test is at least flaky. Let's see how flaky:
/pj-rehearse pull-ci-jkyros-keda-e2e-makefile-target-keda-e2e-aws-ovn

@jkyros
Copy link
Contributor Author

jkyros commented Dec 15, 2023

kafka seemed fine, but had to split the targets because we use em in both the operator and the operand
/pj-rehearse pull-ci-jkyros-keda-e2e-makefile-target-keda-e2e-aws-ovn

@jkyros
Copy link
Contributor Author

jkyros commented Dec 15, 2023

one more time before I PR the keda half
/pj-rehearse pull-ci-jkyros-keda-e2e-makefile-target-keda-e2e-aws-ovn

@jkyros
Copy link
Contributor Author

jkyros commented Dec 15, 2023

/test yamllint

@jkyros
Copy link
Contributor Author

jkyros commented Dec 15, 2023

/pj-rehearse pull-ci-jkyros-keda-e2e-makefile-target-keda-e2e-aws-ovn

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@jkyros: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-jkyros-keda-e2e-makefile-target-clientset-verify jkyros/keda presubmit Presubmit changed
pull-ci-jkyros-keda-e2e-makefile-target-cma-verify-history jkyros/keda presubmit Presubmit changed
pull-ci-jkyros-keda-e2e-makefile-target-gofmt jkyros/keda presubmit Presubmit changed
pull-ci-jkyros-keda-e2e-makefile-target-govet jkyros/keda presubmit Presubmit changed
pull-ci-jkyros-keda-e2e-makefile-target-images jkyros/keda presubmit Presubmit changed
pull-ci-jkyros-keda-e2e-makefile-target-keda-e2e-aws-ovn jkyros/keda presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jkyros
Copy link
Contributor Author

jkyros commented Dec 17, 2023

/pj-rehearse pull-ci-jkyros-keda-e2e-makefile-target-keda-e2e-aws-ovn

1 similar comment
@jkyros
Copy link
Contributor Author

jkyros commented Dec 18, 2023

/pj-rehearse pull-ci-jkyros-keda-e2e-makefile-target-keda-e2e-aws-ovn

Copy link
Contributor

openshift-ci bot commented Dec 18, 2023

@jkyros: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/check-gh-automation a46a1cd link true /test check-gh-automation
ci/prow/config a46a1cd link true /test config
ci/prow/owners a46a1cd link true /test owners

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jkyros
Copy link
Contributor Author

jkyros commented Dec 18, 2023

/pj-rehearse pull-ci-jkyros-keda-e2e-makefile-target-keda-e2e-aws-ovn

@jkyros
Copy link
Contributor Author

jkyros commented Jan 16, 2024

This was hackery against my jkyros branch, the real one merged in openshift/kedacore-keda#19, closing this.

@jkyros jkyros closed this Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants