Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add advanced & private link jobs #45369

Merged

Conversation

heliubj18
Copy link
Contributor

@heliubj18 heliubj18 commented Nov 7, 2023

  1. add a new workflow: rosa-aws-sts-hypershift-sector-private-link
  2. add rosa hosted-cp advanced & private-link full e2e jobs for prod sector env
  3. fix region issue/failure in private link job by enabling region override in bastionhost provision step ci-operator/step-registry/aws/provision/bastionhost/aws-provision-bastionhost-commands.sh
    (in the related bastionhost deprovision step/shell script, the region override has been enabled)

Copy link
Contributor

openshift-ci bot commented Nov 7, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2023
@heliubj18
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-stable-aws-rosa-sts-hypershift-sec-guest-prod-private-link-full-f2

@heliubj18
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-stable-aws-rosa-sts-hypershift-sector-guest-prod-advanced-full-f2

@heliubj18
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-stable-aws-rosa-sts-hypershift-sec-guest-prod-private-link-full-f2

2 similar comments
@heliubj18
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-stable-aws-rosa-sts-hypershift-sec-guest-prod-private-link-full-f2

@heliubj18
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-stable-aws-rosa-sts-hypershift-sec-guest-prod-private-link-full-f2

@heliubj18
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-stable-aws-rosa-sts-hypershift-sec-guest-prod-private-link-full-f2

@openshift-ci-robot
Copy link
Contributor

@heliubj18, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not determine changed registry steps: could not load step registry: Chain cucushift-installer-rehearse-baremetalds-assisted-hypershift-agent-mce-provision contains non-existent chain hypershift-mce-agent-create (xxxxxxxx)
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@heliubj18
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-stable-aws-rosa-sts-hypershift-sec-guest-prod-private-link-full-f2

@openshift-ci-robot
Copy link
Contributor

@heliubj18, pj-rehearse: unable to determine affected jobs ERROR:

could not determine changed registry steps: could not load step registry: Chain cucushift-installer-rehearse-baremetalds-assisted-hypershift-agent-mce-provision contains non-existent chain hypershift-mce-agent-create (xxxxxxxx)

If the problem persists, please contact Test Platform.

@openshift-ci-robot
Copy link
Contributor

@heliubj18, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not determine changed registry steps: could not load step registry: Chain cucushift-installer-rehearse-baremetalds-assisted-hypershift-agent-mce-provision contains non-existent chain hypershift-mce-agent-create (xxxxxxxx)
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@heliubj18 heliubj18 force-pushed the add-rosa-hypershift-prod branch 2 times, most recently from 20462e5 to e9da264 Compare November 14, 2023 04:58
@heliubj18
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-stable-aws-rosa-sts-hypershift-sec-guest-prod-private-link-full-f2

@heliubj18
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-stable-aws-rosa-sts-hypershift-sector-guest-prod-advanced-full-f2

@heliubj18
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-stable-aws-rosa-sts-hypershift-sec-guest-prod-private-link-full-f2

@heliubj18
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-stable-aws-rosa-sts-hypershift-sector-guest-prod-advanced-full-f2

@heliubj18
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-stable-aws-rosa-sts-hypershift-sec-guest-prod-private-link-full-f2

@heliubj18
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-stable-aws-rosa-sts-hypershift-sector-guest-prod-advanced-full-f2

1 similar comment
@heliubj18
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-stable-aws-rosa-sts-hypershift-sector-guest-prod-advanced-full-f2

@openshift-ci-robot
Copy link
Contributor

@heliubj18, pj-rehearse: unable to determine affected jobs ERROR:

could not load configuration from base revision of release repo: could not checkout worktree: '[git checkout 801cd05c6b56766d8868fedd261188c81d6a10b3]' failed with out: fatal: reference is not a tree: 801cd05c6b56766d8868fedd261188c81d6a10b3
and error exit status 128

If the problem persists, please contact Test Platform.

@heliubj18
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-stable-aws-rosa-sts-hypershift-sector-guest-prod-advanced-full-f2

@openshift-ci-robot
Copy link
Contributor

@heliubj18, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not determine changed registry steps: could not load step registry: Workflow rosa-aws-sts-hypershift-sector-private-link contains non-existent reference cucushift-hypeshift-extended-debug
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@heliubj18
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-stable-aws-rosa-sts-hypershift-sector-guest-prod-advanced-full-f2

@openshift-ci-robot
Copy link
Contributor

@heliubj18, pj-rehearse: unable to determine affected jobs ERROR:

could not determine changed registry steps: could not load step registry: Workflow rosa-aws-sts-hypershift-sector-private-link contains non-existent reference cucushift-hypeshift-extended-debug

If the problem persists, please contact Test Platform.

@heliubj18
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-stable-aws-rosa-sts-hypershift-sec-guest-prod-private-link-full-f2

@openshift-ci-robot
Copy link
Contributor

@heliubj18, pj-rehearse: unable to determine affected jobs ERROR:

could not determine changed registry steps: could not load step registry: Workflow rosa-aws-sts-hypershift-sector-private-link contains non-existent reference cucushift-hypeshift-extended-debug

If the problem persists, please contact Test Platform.

@heliubj18 heliubj18 marked this pull request as ready for review November 15, 2023 08:37
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 15, 2023
@heliubj18
Copy link
Contributor Author

/pj-rehearse ack

@heliubj18
Copy link
Contributor Author

private link job case failures are caused by https://issues.redhat.com/browse/OCPBUGS-23300

@openshift-ci-robot
Copy link
Contributor

@heliubj18: job(s): , ack either don't exist or were not found to be affected, and cannot be rehearsed

@heliubj18
Copy link
Contributor Author

/assign @LiangquanLi930 @yasun1

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@heliubj18: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-aws-efs-csi-driver-operator-master-operator-e2e-extended openshift/aws-efs-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-aws-efs-csi-driver-operator-release-4.16-operator-e2e-extended openshift/aws-efs-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-aws-efs-csi-driver-operator-release-4.15-operator-e2e-extended openshift/aws-efs-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-aws-efs-csi-driver-operator-release-4.14-operator-e2e-extended openshift/aws-efs-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-csi-operator-master-e2e-aws-csi-extended openshift/csi-operator presubmit Registry content changed
pull-ci-openshift-csi-operator-release-4.16-e2e-aws-csi-extended openshift/csi-operator presubmit Registry content changed
pull-ci-openshift-csi-operator-release-4.15-e2e-aws-csi-extended openshift/csi-operator presubmit Registry content changed
pull-ci-openshift-aws-ebs-csi-driver-operator-release-4.14-e2e-aws-csi-extended openshift/aws-ebs-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-aws-ebs-csi-driver-master-e2e-aws-csi-extended openshift/aws-ebs-csi-driver presubmit Registry content changed
pull-ci-openshift-aws-ebs-csi-driver-release-4.16-e2e-aws-csi-extended openshift/aws-ebs-csi-driver presubmit Registry content changed
pull-ci-openshift-aws-ebs-csi-driver-release-4.15-e2e-aws-csi-extended openshift/aws-ebs-csi-driver presubmit Registry content changed
pull-ci-openshift-aws-ebs-csi-driver-release-4.14-e2e-aws-csi-extended openshift/aws-ebs-csi-driver presubmit Registry content changed
pull-ci-openshift-openshift-tests-private-master-debug-disasterrecovery-aws-ipi openshift/openshift-tests-private presubmit Registry content changed
pull-ci-openshift-openshift-tests-private-release-4.16-debug-disasterrecovery-aws-ipi openshift/openshift-tests-private presubmit Registry content changed
pull-ci-openshift-openshift-tests-private-release-4.15-debug-disasterrecovery-aws-ipi openshift/openshift-tests-private presubmit Registry content changed
pull-ci-openshift-openshift-tests-private-release-4.14-debug-disasterrecovery-aws-ipi openshift/openshift-tests-private presubmit Registry content changed
pull-ci-openshift-openshift-tests-private-release-4.13-debug-disasterrecovery-aws-ipi openshift/openshift-tests-private presubmit Registry content changed
pull-ci-openshift-openshift-tests-private-release-4.12-debug-disasterrecovery-aws-ipi openshift/openshift-tests-private presubmit Registry content changed
pull-ci-openshift-openshift-tests-private-release-4.11-debug-disasterrecovery-aws-ipi openshift/openshift-tests-private presubmit Registry content changed
pull-ci-openshift-openshift-tests-private-release-4.10-debug-disasterrecovery-aws-ipi openshift/openshift-tests-private presubmit Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-arm64-nightly-4.14-upgrade-from-stable-4.13-aws-ipi-disconnected-sts-ep-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.10-amd64-nightly-4.10-upgrade-from-stable-4.9-aws-c2s-ipi-disconnected-private-fips-f360 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.10-amd64-nightly-aws-ipi-disconnected-sts-ep-fips-f360 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-arm64-nightly-aws-ipi-disconnected-sts-basecap-none-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-aws-ipi-disconnected-private-sno-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.11-amd64-nightly-aws-usgov-ipi-private-workers-marketplace-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-aws-ipi-disconnected-mtu-localzone-fips-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-aws-usgov-ipi-disconnected-private-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.15-e2e-aws-ovn-ha-cert-rotation-suspend-30d N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.15-amd64-nightly-aws-ipi-disconnected-sts-basecap-none-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-aws-usgov-ipi-private-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-aws-ipi-disconnected-private-f28-longduration-cloud N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.13-arm64-nightly-4.13-upgrade-from-stable-4.13-aws-ipi-disconnected-sts-ep-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.15-amd64-nightly-aws-ipi-disconnected-sts-basecap-none-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-4.13-upgrade-from-stable-4.12-aws-ipi-disc-sno-baselinecaps-none-f28 N/A periodic Registry content changed

A total of 558 jobs have been affected by this change. The above listing is non-exhaustive and limited to 35 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@heliubj18
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Nov 16, 2023
Copy link
Contributor

openshift-ci bot commented Nov 16, 2023

@heliubj18: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-stable-aws-rosa-sts-hypershift-sector-guest-prod-advanced-full-f2 28d4a4e2619b768675d8f5e2a352eb4982540f91 link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-stable-aws-rosa-sts-hypershift-sector-guest-prod-advanced-full-f2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@LiangquanLi930
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2023
@heliubj18
Copy link
Contributor Author

@yasun1 Could you please help to review it again and approve it. Thanks!

@yasun1
Copy link
Contributor

yasun1 commented Nov 16, 2023

/lgtm

@heliubj18
Copy link
Contributor Author

@yunjiang29 Could you please help to approve it? thanks

@@ -235,6 +235,42 @@ tests:
test:
- chain: openshift-e2e-test-hypershift-qe
workflow: rosa-aws-sts-hypershift-sector
- as: aws-rosa-sts-hypershift-sector-guest-prod-advanced-full-f2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heliubj18, do you really need to test so heavily?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, rosa is GA soon. We need to watch it closely these days. We could consider updating it later after GA.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yunjiang29
Copy link
Contributor

/lgtm

@heliubj18
Copy link
Contributor Author

@liangxia Could you please review and approve it? Thanks!

@liangxia
Copy link
Member

/approve

Copy link
Contributor

openshift-ci bot commented Nov 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: heliubj18, LiangquanLi930, liangxia, yasun1, yunjiang29

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 0af77da into openshift:master Nov 22, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants