add GUEST_KUBECONFIG for ginkgo repo #43435
Conversation
| @@ -12,6 +12,12 @@ export PATH=/usr/local/go/bin:/usr/libexec/origin:/opt/OpenShift4-tools:$PATH | |||
| export REPORT_HANDLE_PATH="/usr/bin" | |||
| export ENABLE_PRINT_EVENT_STDOUT=true | |||
|
|
|||
| # add for hosted kubeconfig in the hosted cluster env | |||
There was a problem hiding this comment.
@heliubj18 please add this to the following step too.
openshift-extended-test-longduration
openshift-extended-test-disruptive
I am not sure if the following also need it:
openshift-extended-upgrade-pre
openshift-extended-upgrade-post
I think it has no side effect to add them into these two files.
There was a problem hiding this comment.
openshift-extended-upgrade-pre
openshift-extended-upgrade-post
are also required for HyperShift
There was a problem hiding this comment.
so, the more 4 steps need it too.
|
[REHEARSALNOTIFIER]
A total of 2658 jobs have been affected by this change. The above listing is non-exhaustive and limited to 35 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@kuiwang02 @LiangquanLi930 I updated all the steps in |
|
btw, I think if this pr is merged later, the openshift-test-private image should be rebuild too. right? thanks |
|
@heliubj18: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/pj-rehearse pull-ci-openshift-openshift-tests-private-release-4.15-debug-disasterrecovery-aws-ipi |
I think the image rebuilt should be done asap whether the PR is merged or not. |
|
by the way, I can approve it now because the code should work. I did it with UT [root@preserve-olm-env2 bin]# touch /tmp/nested_kubeconfig
[root@preserve-olm-env2 bin]# export TT1=/tmp
[root@preserve-olm-env2 bin]# chmod 755 testss.sh
[root@preserve-olm-env2 bin]# ./testss.sh
/tmp/nested_kubeconfig
[root@preserve-olm-env2 bin]# export TT1=/tmp1
[root@preserve-olm-env2 bin]# ./testss.sh
[root@preserve-olm-env2 bin]# cat testss.sh
#!/bin/bash
if test -f "${TT1}/nested_kubeconfig"
then
export GUEST_KUBECONFIG=${TT1}/nested_kubeconfig
fi
echo $GUEST_KUBECONFIG
[root@preserve-olm-env2 bin]#
|
|
do you need to approve it now? |
|
@kuiwang02 yes, thanks for your testing |
|
/pj-rehearse branch-ci-openshift-openshift-tests-private-release-4.14-images-images |
|
@heliubj18: job(s): , branch-ci-openshift-openshift-tests-private-release-4.14-images-images either don't exist or were not found to be affected, and cannot be rehearsed |
|
/lgtm |
|
/pj-rehearse ack |
openshift-ci-robot
added
the
rehearsals-ack
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: heliubj18, kuiwang02 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-robot
merged commit 4db5577
into
openshift:master
use GUEST_KUBECONFIG to set hosted cluster kubeconfig in openshift-tests-private repo