Skip to content

ROX-10613: Use ubi-minimal for scanner-db #32848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 26, 2022

Conversation

janisz
Copy link
Contributor

@janisz janisz commented Oct 4, 2022

@janisz
Copy link
Contributor Author

janisz commented Oct 4, 2022

/cc @RTann

@openshift-ci openshift-ci bot requested a review from RTann October 4, 2022 18:54
@openshift-ci openshift-ci bot requested review from gavin-stackrox and jvdm October 4, 2022 18:56
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2022
@janisz janisz changed the title Use ubi-minimal for scanner-db ROX-10613: Use ubi-minimal for scanner-db Oct 5, 2022
@janisz
Copy link
Contributor Author

janisz commented Oct 19, 2022

@RTann ping

@RTann
Copy link
Contributor

RTann commented Oct 21, 2022

I don't recall the merge order. I think we want to merge the StackRox change first and then this? Going to hold off on lgtm because I think the PR may be automatically merged once I give it

@janisz
Copy link
Contributor Author

janisz commented Oct 21, 2022

Going to hold off on lgtm because I think the PR may be automatically merged once I give it

Correct lets put it on hold then.

I think the merge order does not matter that much. If we merge this PR first then we can rerun scanner test and they should pass. If we merge scanner first then we can run pj-rehearse and it should pass. I don't know how to merge them both in a safe way so two PRs will be green.

@janisz
Copy link
Contributor Author

janisz commented Oct 21, 2022

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2022
@RTann
Copy link
Contributor

RTann commented Oct 26, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 26, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: janisz, RTann

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@janisz
Copy link
Contributor Author

janisz commented Oct 26, 2022

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 26, 2022
@janisz
Copy link
Contributor Author

janisz commented Oct 26, 2022

/retest

@openshift-merge-robot openshift-merge-robot merged commit cadc5e7 into openshift:master Oct 26, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 26, 2022

@janisz: Updated the ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:

  • key stackrox-scanner-master.yaml using file ci-operator/config/stackrox/scanner/stackrox-scanner-master.yaml

In response to this:

Refs: stackrox/scanner#956
Tests: #32858

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@janisz janisz deleted the patch-6 branch October 26, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants