Skip to content

Add ci-ppc test to NTO as part of PAO migration #27342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2022
Merged

Add ci-ppc test to NTO as part of PAO migration #27342

merged 1 commit into from
Apr 11, 2022

Conversation

jlojosnegros
Copy link
Contributor

@jlojosnegros jlojosnegros commented Mar 28, 2022 •
edited
Loading

As part of Performance Addon Operation (PAO) migration to Node Tuning Operator (NTO) (openshift/cluster-node-tuning-operator#322) Performance Profile Creator (PPC) CLI tool is being migrated ( openshift/cluster-node-tuning-operator#325).

This PR add the automatic execution of the PPC unit tests.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 28, 2022
@jlojosnegros jlojosnegros changed the title WIP Add ci-ppc test to NTO as part of PAO migration Add ci-ppc test to NTO as part of PAO migration Mar 28, 2022
@jlojosnegros jlojosnegros marked this pull request as ready for review March 28, 2022 13:57
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 28, 2022
@openshift-ci openshift-ci bot requested review from dagrayvid and jmencak March 28, 2022 14:00
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 28, 2022

@jlojosnegros: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yanirq
Copy link
Contributor

yanirq commented Mar 28, 2022 •
edited
Loading

@jlojosnegros make sure to add this also to 4.11 and 4.12 manifests.
After that you need to run make update to get the auto generated files for jobs.

Also - make sure the makefile target will exist on Node tuning operator.

@jmencak
Copy link
Contributor

jmencak commented Mar 28, 2022

Needs openshift/cluster-node-tuning-operator#325 merged first and as Yanir says, I'm missing mods in 4.11 and 4.12 files.

@jlojosnegros
Copy link
Contributor Author

@jlojosnegros make sure to add this also to 4.11 and 4.12 manifests.
After that you need to run make update to get the auto generated files for jobs.

Ok, I will take care of it

Also - make sure the makefile target will exist on Node tuning operator.
it will be available when openshift/cluster-node-tuning-operator#325 will be merged.

@jlojosnegros
Copy link
Contributor Author

jlojosnegros commented Mar 28, 2022 •
edited
Loading

/hold
do not merge until openshift/cluster-node-tuning-operator#325 is merged as this PR depends on it.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 28, 2022
@jlojosnegros
Copy link
Contributor Author

@jlojosnegros make sure to add this also to 4.11 and 4.12 manifests.
After that you need to run make update to get the auto generated files for jobs.

Added

@yanirq
Copy link
Contributor

yanirq commented Apr 10, 2022

/hold cancel

@jmencak ill leave the final review here for you before approval.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 10, 2022
@yanirq
Copy link
Contributor

yanirq commented Apr 10, 2022

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 10, 2022
@jlojosnegros
Copy link
Contributor Author

rebase to solve conflicts

@jmencak
Copy link
Contributor

jmencak commented Apr 11, 2022

Thank you for the PR, Jose.
/lgtm
/approve

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlojosnegros, jmencak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 11, 2022

@jlojosnegros: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit a510929 into openshift:master Apr 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 11, 2022

@jlojosnegros: Updated the following 6 configmaps:

  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-node-tuning-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/cluster-node-tuning-operator/openshift-cluster-node-tuning-operator-master-presubmits.yaml
  • job-config-4.11 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-node-tuning-operator-release-4.11-presubmits.yaml using file ci-operator/jobs/openshift/cluster-node-tuning-operator/openshift-cluster-node-tuning-operator-release-4.11-presubmits.yaml
  • job-config-4.12 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-node-tuning-operator-release-4.12-presubmits.yaml using file ci-operator/jobs/openshift/cluster-node-tuning-operator/openshift-cluster-node-tuning-operator-release-4.12-presubmits.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-node-tuning-operator-master.yaml using file ci-operator/config/openshift/cluster-node-tuning-operator/openshift-cluster-node-tuning-operator-master.yaml
  • ci-operator-4.11-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-node-tuning-operator-release-4.11.yaml using file ci-operator/config/openshift/cluster-node-tuning-operator/openshift-cluster-node-tuning-operator-release-4.11.yaml
  • ci-operator-4.12-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-node-tuning-operator-release-4.12.yaml using file ci-operator/config/openshift/cluster-node-tuning-operator/openshift-cluster-node-tuning-operator-release-4.12.yaml

In response to this:

As part of Performance Addon Operation (PAO) migration to Node Tuning Operator (NTO) (openshift/cluster-node-tuning-operator#322) Performance Profile Creator (PPC) CLI tool is being migrated ( openshift/cluster-node-tuning-operator#325).

This PR add the automatic execution of the PPC unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmencak jmencak jmencak approved these changes

@dagrayvid dagrayvid Awaiting requested review from dagrayvid

Assignees

@jmencak jmencak

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jlojosnegros @yanirq @jmencak @openshift-merge-robot