Skip to content

Setup ci for redhat-subscription-injection-webhook#12179

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
coreydaley:add_subscription_injection_webhook
Sep 30, 2020
Merged

Setup ci for redhat-subscription-injection-webhook#12179
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
coreydaley:add_subscription_injection_webhook

Conversation

@coreydaley
Copy link

@coreydaley coreydaley commented Sep 23, 2020

Setup CI for openshift/subscription-injection-webhook

@coreydaley coreydaley changed the title add subscription-injection-webhook [WIP] add subscription-injection-webhook Sep 23, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Sep 23, 2020
@coreydaley
Copy link
Author

coreydaley commented Sep 24, 2020

/retest

3 similar comments
@coreydaley
Copy link
Author

coreydaley commented Sep 24, 2020

/retest

@coreydaley
Copy link
Author

coreydaley commented Sep 24, 2020

/retest

@coreydaley
Copy link
Author

coreydaley commented Sep 24, 2020

/retest

@coreydaley
Copy link
Author

coreydaley commented Sep 24, 2020

/assign @adambkaplan @bparees @smarterclayton

@coreydaley coreydaley changed the title [WIP] add subscription-injection-webhook Add subscription-injection-webhook Sep 24, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 24, 2020
@bparees
Copy link
Contributor

bparees commented Sep 24, 2020

only @smarterclayton can approve the mirror update.
only @openshift/openshift-team-developer-productivity-test-platform can approve the plugin part

@coreydaley
Copy link
Author

coreydaley commented Sep 24, 2020

/assign @openshift/openshift-team-developer-productivity-test-platform

@coreydaley
Copy link
Author

coreydaley commented Sep 24, 2020

@openshift/openshift-team-developer-productivity-test-platform ptal

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2020
@coreydaley
Copy link
Author

coreydaley commented Sep 25, 2020

/verify-owners

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2020
@coreydaley
Copy link
Author

coreydaley commented Sep 25, 2020

/verify-owners

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Sep 25, 2020
@coreydaley
Copy link
Author

coreydaley commented Sep 25, 2020

@petr-muller I have resolved the OWNERS file issue.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2020
@smarterclayton
Copy link
Contributor

smarterclayton commented Sep 28, 2020

What does this component do? What kind of subscription is being injected?

@bparees
Copy link
Contributor

bparees commented Sep 28, 2020

What does this component do? What kind of subscription is being injected?

rhel entitlements

@bparees
Copy link
Contributor

bparees commented Sep 28, 2020 •
edited
Loading

@smarterclayton see:
https://github.com/openshift/enhancements/blob/master/enhancements/subscription-content/subscription-content-access.md

for an overview and
https://github.com/openshift/enhancements/blob/master/enhancements/cluster-scope-secret-volumes/csi-driver-host-injections.md
+
openshift/enhancements#389

for some lower level details

@smarterclayton
Copy link
Contributor

smarterclayton commented Sep 29, 2020

The name is a bit too generic at first blush. Is there any other type of subscription that could ever be injected?

@coreydaley
Copy link
Author

coreydaley commented Sep 29, 2020

@adambkaplan would probably have a better handle on the answer to that question.

@adambkaplan
Copy link
Contributor

adambkaplan commented Sep 29, 2020

The name is a bit too generic at first blush. Is there any other type of subscription that could ever be injected?

Not that I'm aware of today. But given that OLM uses similar terminology ("subscription"), I can't rule it out for the future. Perhaps we must rename to redhat-subscription-injection-webhook?

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2020
@coreydaley coreydaley changed the title Add subscription-injection-webhook Add redhat-subscription-injection-webhook Sep 29, 2020
@coreydaley coreydaley changed the title Add redhat-subscription-injection-webhook Setup ci for redhat-subscription-injection-webhook Sep 29, 2020
@coreydaley
Copy link
Author

coreydaley commented Sep 29, 2020

@smarterclayton everything has been updated with the name change, ptal

@smarterclayton
Copy link
Contributor

smarterclayton commented Sep 30, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 30, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coreydaley-redhat, petr-muller, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2020
@openshift-merge-robot openshift-merge-robot merged commit 0e6328c into openshift:master Sep 30, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 30, 2020

@coreydaley-redhat: Updated the following 7 configmaps:

  • image-mirror-mappings configmap in namespace ci at cluster app.ci using the following files:
    • key mapping_origin_4_6 using file core-services/image-mirroring/openshift/mapping_origin_4_6
    • key mapping_origin_4_7 using file core-services/image-mirroring/openshift/mapping_origin_4_7
  • plugins configmap in namespace ci at cluster api.ci using the following files:
    • key plugins.yaml using file core-services/prow/02_config/_plugins.yaml
  • plugins configmap in namespace ci at cluster app.ci using the following files:
    • key plugins.yaml using file core-services/prow/02_config/_plugins.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-redhat-subscription-injection-webhook-master.yaml using file ci-operator/config/openshift/redhat-subscription-injection-webhook/openshift-redhat-subscription-injection-webhook-master.yaml
  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-redhat-subscription-injection-webhook-master-postsubmits.yaml using file ci-operator/jobs/openshift/redhat-subscription-injection-webhook/openshift-redhat-subscription-injection-webhook-master-postsubmits.yaml
    • key openshift-redhat-subscription-injection-webhook-master-presubmits.yaml using file ci-operator/jobs/openshift/redhat-subscription-injection-webhook/openshift-redhat-subscription-injection-webhook-master-presubmits.yaml
  • job-config-master configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-redhat-subscription-injection-webhook-master-postsubmits.yaml using file ci-operator/jobs/openshift/redhat-subscription-injection-webhook/openshift-redhat-subscription-injection-webhook-master-postsubmits.yaml
    • key openshift-redhat-subscription-injection-webhook-master-presubmits.yaml using file ci-operator/jobs/openshift/redhat-subscription-injection-webhook/openshift-redhat-subscription-injection-webhook-master-presubmits.yaml
  • image-mirror-mappings configmap in namespace ci at cluster api.ci using the following files:
    • key mapping_origin_4_6 using file core-services/image-mirroring/openshift/mapping_origin_4_6
    • key mapping_origin_4_7 using file core-services/image-mirroring/openshift/mapping_origin_4_7
Details

In response to this:

Setup CI for openshift/subscription-injection-webhook

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@droslean droslean Awaiting requested review from droslean

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

1 more reviewer

@petr-muller petr-muller petr-muller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@petr-muller petr-muller

@smarterclayton smarterclayton

@adambkaplan adambkaplan

@bparees bparees

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@coreydaley @bparees @smarterclayton @adambkaplan @openshift-ci-robot @petr-muller @openshift-merge-robot