Skip to content

OSD-29167: Testcases pkg account #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

karanjitsingh01
Copy link
Contributor

Contains Test cases for Account package.
Files Tested -
c onsole.go
generate-secet.go
rotate-secret.go

Overall test coverage for package and sub-package:
coverage for account : 15.7% of statements
coverage of account/get/: 29.0% of statements
coverage of account/list/ : 26.3% of statements
coverage of account/mgmt/ : 42.6% of statements
coverage of account/servicequotas/ : 0.0% of statements

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 25, 2025
@karanjitsingh01 karanjitsingh01 changed the title Osd -29167: Testcases pkg account OSD-29167: Testcases pkg account Apr 25, 2025
Copy link
Contributor

openshift-ci bot commented Apr 25, 2025

Hi @karanjitsingh01. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 25, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 25, 2025

@karanjitsingh01: This pull request references OSD-29167 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Contains Test cases for Account package.
Files Tested -
c onsole.go
generate-secet.go
rotate-secret.go

Overall test coverage for package and sub-package:
coverage for account : 15.7% of statements
coverage of account/get/: 29.0% of statements
coverage of account/list/ : 26.3% of statements
coverage of account/mgmt/ : 42.6% of statements
coverage of account/servicequotas/ : 0.0% of statements

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@karanjitsingh01 karanjitsingh01 marked this pull request as ready for review April 28, 2025 05:48
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 28, 2025
@openshift-ci openshift-ci bot requested review from joshbranham and typeid April 28, 2025 05:49
Copy link
Member

@typeid typeid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2025
Copy link
Contributor

openshift-ci bot commented Apr 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karanjitsingh01, typeid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2025
Copy link
Contributor

openshift-ci bot commented Apr 28, 2025

@karanjitsingh01: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 704493b into openshift:master Apr 28, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants