Skip to content

OSD-29159 : Added unit test case for env and swarm packages #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

amitupadh
Copy link
Contributor

This PR enhances test coverage and improves maintainability by adding unit test cases for ENV and Swarm packages.

Coverage Details:
Increased unit test coverage for ENV and Swarm packages.

Verification:
All tests pass successfully, ensuring correctness and improved test coverage.

JIRA Ticket:

OSD-29159

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 16, 2025
Copy link
Contributor

openshift-ci bot commented Apr 16, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@amitupadh
Copy link
Contributor Author

/test all

@amitupadh
Copy link
Contributor Author

/test all

@amitupadh amitupadh marked this pull request as ready for review April 17, 2025 09:00
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 17, 2025
@openshift-ci openshift-ci bot requested review from dustman9000 and fahlmant April 17, 2025 09:01
@petrkotas
Copy link
Member

/retest

1 similar comment
@petrkotas
Copy link
Member

/retest

Copy link
Member

@typeid typeid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2025
Copy link
Contributor

openshift-ci bot commented Apr 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amitupadh, typeid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 52a5e15 and 2 for PR HEAD f84e303 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 704493b and 1 for PR HEAD f84e303 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 704493b and 2 for PR HEAD f84e303 in total

2 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 704493b and 2 for PR HEAD f84e303 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 704493b and 2 for PR HEAD f84e303 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e5eac0f and 1 for PR HEAD f84e303 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e5eac0f and 2 for PR HEAD f84e303 in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e5eac0f and 2 for PR HEAD f84e303 in total

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2025
Copy link
Contributor

openshift-ci bot commented Apr 30, 2025

New changes are detected. LGTM label has been removed.

@amitupadh
Copy link
Contributor Author

/retest test

Copy link
Contributor

openshift-ci bot commented Apr 30, 2025

@amitupadh: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test build
/test images
/test lint
/test test
/test verify-docs

Use /test all to run all jobs.

In response to this:

/retest test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@amitupadh
Copy link
Contributor Author

/test all

@amitupadh
Copy link
Contributor Author

/test test

1 similar comment
@devppratik
Copy link
Contributor

/test test

Copy link
Contributor

openshift-ci bot commented May 21, 2025

@amitupadh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/test 51c6521 link true /test test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@devppratik
Copy link
Contributor

@amitupadh Can you please check the failing test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants