Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish redhat-coreos config sources #413

Merged

Conversation

cgwalters
Copy link
Member

Today the redhat-coreos config git repository (equivalent of https://github.com/coreos/fedora-coreos-config ) lives internally to the RH firewall. This is problematic for many reasons - we're not consistently publishing the sources here, and also inhibits our integration with the upstream OpenShift CI (Prow).

This PR imports the config. I propose we move it to Github canonically.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 9, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2020
@@ -0,0 +1,20 @@
# This file documents currently known-to-fail kola tests. It is consumed by
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should probably be removed.

@miabbott
Copy link
Member

I think we can drop the installer dir in favor of the live dir?

@miabbott
Copy link
Member

@darkmuggle @bh7cw @mike-nguyen @ravanelli This change will likely intersect with some of the pipeline work you folks are responsible for.

@miabbott
Copy link
Member

/approve

The first step is getting things imported; I imagine there are going to be follow-ups to refine this. But as a start, this looks reasonable.

@dustymabe
Copy link
Member

I have no objections. ✔️

@jlebon
Copy link
Member

jlebon commented Oct 13, 2020

Overall
/approve
also from me. Though it looks like this is also adding support for a "CentOS CoreOS" which I think we should consider independently of the "move configs to GitHub" endeavour.

@cgwalters
Copy link
Member Author

Though it looks like this is also adding support for a "CentOS CoreOS" which I think we should consider independently of the "move configs to GitHub" endeavour.

Yeah true, I can try to drop that.

@cgwalters cgwalters marked this pull request as ready for review October 14, 2020 16:04
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 14, 2020
@cgwalters
Copy link
Member Author

OK updated to address comments, dropping draft!

@@ -0,0 +1,143 @@
#!/bin/bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this now that it lives in the MCO?

openshift/machine-config-operator#2011

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just reflecting the state of the internal git repository; let's not try to also change it at the same time.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean if we succeed at this, then we could do a PR to drop that script and have it tested by Prow launching a cluster in Azure!

@miabbott
Copy link
Member

Seems like we are in a good position to move forward.

/approve

@jlebon
Copy link
Member

jlebon commented Oct 15, 2020

OK, tested locally and verified that it's up to date.
Let's merge this! The final switchover happens internally.
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, jlebon, miabbott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cgwalters,jlebon,miabbott]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit a06951c into openshift:master Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants