[release-4.18] OCPBUGS-60201: Revert "40rhcos-fips: include fips.so in initrd"

[mike-nguyen]

This reverts commit f21c511.

This was fixed upstream in in RHEL so this patch is no longer needed.

9.4 - https://issues.redhat.com/browse/RHEL-104864 9.2 - https://issues.redhat.com/browse/RHEL-104863

[openshift-ci-robot]

@mike-nguyen: This pull request references Jira Issue OCPBUGS-60201, which is invalid:

• expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "4.19.z" instead
• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected dependent Jira Issue OCPBUGS-60200 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This reverts commit f21c511.

This was fixed upstream in in RHEL so this patch is no longer needed.

9.4 - https://issues.redhat.com/browse/RHEL-104864 9.2 - https://issues.redhat.com/browse/RHEL-104863

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[mike-nguyen]

/jira refresh

[openshift-ci-robot]

@mike-nguyen: This pull request references Jira Issue OCPBUGS-60201, which is invalid:

• expected dependent Jira Issue OCPBUGS-60200 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[mike-nguyen]

/jira refresh

[openshift-ci-robot]

@mike-nguyen: This pull request references Jira Issue OCPBUGS-60201, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.18.z) matches configured target version for branch (4.18.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-60200 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-60200 targets the "4.19.z" version, which is one of the valid target versions: 4.19.0, 4.19.z
• bug has dependents

Requesting review from QA contact:
/cc @tlbueno

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[mike-nguyen]

/jira backport release-4.17, release-4.16, release-4.15, release-4.14

[jlebon]

Nice! So, there's coreos/coreos-assembler#4181 now which would cover this. Would be really nice to have that test before we do these reverts. So ideally we'd backport the test to 4.13. @travier, was that what you had in mind as well?

[mike-nguyen]

@jlebon -- @aaradhak is going to manually test it, then backport the cosa test to 4.14 (I think 4.13 is EOL) then remove the patch back to 4.14. If there's anything wrong with that plan please let him know.

[aaradhak]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aaradhak, mike-nguyen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [aaradhak,mike-nguyen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jlebon]

@aaradhak To confirm, were you able to verify this?

[jlebon]

/retest

[aaradhak]

Yes, I had manually tested it

Tested on 4.18-9.4 and 4.15-9.2 , kola test fips.failure seem to PASS

There was a jira card for it and I had updated it over there
https://issues.redhat.com/browse/COS-3502?focusedId=27750932&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-27750932

[openshift-ci]

@mike-nguyen: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[aaradhak]

/label backport-risk-assessed

[openshift-ci]

@aaradhak: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-staff-engineers]

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.