Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COS-2508: docs: explain how to enable swap #1490

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jbtrystram
Copy link
Contributor

swap support is now beta2 in kubernetes (as 1.28) and should be stable in 1.30.
Document how to enable the feature on OCP.

Follow #1479

swap support is now beta2 in kubernetes (as 1.28) and
should be stable in 1.30.
Document how to enable the feature on OCP.

Follow openshift#1479
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 18, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 18, 2024

@jbtrystram: This pull request references COS-2507 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

swap support is now beta2 in kubernetes (as 1.28) and should be stable in 1.30.
Document how to enable the feature on OCP.

Follow #1479

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jbtrystram jbtrystram changed the title COS-2507: docs: explain how to enable swap COS-2508: docs: explain how to enable swap Apr 18, 2024
Copy link
Contributor

openshift-ci bot commented Apr 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbtrystram

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 18, 2024

@jbtrystram: This pull request references COS-2508 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

swap support is now beta2 in kubernetes (as 1.28) and should be stable in 1.30.
Document how to enable the feature on OCP.

Follow #1479

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jlebon
Copy link
Member

jlebon commented Apr 18, 2024

It's tempting to add more in-depth docs here, but I would suggest not going too deep into that. That level of depth I think belongs better in the OCP docs. Otherwise we end up with competing docs that need to be maintained in parallel. We have the FAQ, but that's meant to be more shorter answers that ideally link to more comprehensive docs (OCP/RHEL/upstream).

Specifically for this, e.g. we could reformulate it as a FAQ question like:

Q: Does RHCOS support swap?

It's supported as Tech Preview in 4.16. To enable it, first enable the tech preview feature gate, then enable the swapBehavior: LimitedSwap option in a KubeletConfig. swap can be a separate partition (via Ignition), or you can use swap on zram.

Once we have more in-depth docs in the official docs, we can link to that.

@jbtrystram
Copy link
Contributor Author

It's tempting to add more in-depth docs here, but I would suggest not going too deep into that. That level of depth I think belongs better in the OCP docs.

100% agree. My idea was to have a draft so someone from the docs could take over.
Now i realize I should have opened this in the docs repo...

NAME ALGORITHM DISKSIZE DATA COMPR TOTAL STREAMS MOUNTPOINT
/dev/zram0 lzo-rle 4G 4K 80B 12K 4 [SWAP]
```

Copy link
Contributor

@aaradhak aaradhak Apr 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor : may be we can remove these extra lines at the eof?
The remaining content lgtm otherwise

@jlebon
Copy link
Member

jlebon commented Apr 18, 2024

It's tempting to add more in-depth docs here, but I would suggest not going too deep into that. That level of depth I think belongs better in the OCP docs.

100% agree. My idea was to have a draft so someone from the docs could take over. Now i realize I should have opened this in the docs repo...

Normally the docs team adds those and might already be working on it (cc @jldohmann). But yeah, definitely useful to have this written out even just here in PR form as something to start with for the official docs.

@travier
Copy link
Member

travier commented Apr 22, 2024

LGTM overall. Agree with Jonathan. Let's make this proper OCP docs.
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2024
@jbtrystram
Copy link
Contributor Author

@jldohmann was this added to the OCP docs ? I see a couple of PRs but nothing related to ZRAM swap

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants