Augmented AD ldap sync #5086
Augmented AD ldap sync #5086
Conversation
deads2k
force-pushed
the
enhanced-ad
branch
3 times, most recently
from
84b6339 to
871a5a7
Compare
|
Tests added. This is ready for review. |
| ClientConfig *ldaputil.LDAPClientConfig | ||
| Config *api.AugmentedActiveDirectoryConfig | ||
|
|
||
| enhancedADLDAPInterface *ad.EnhancedADLDAPInterface |
There was a problem hiding this comment.
enhanced or augmented?
augmented
|
Looks reasonable |
| @@ -63,7 +63,7 @@ func (s *LDAPGroupSyncer) Sync() ([]*userapi.Group, []error) { | |||
| // get membership data | |||
| memberEntries, err := s.GroupMemberExtractor.ExtractMembers(ldapGroupUID) | |||
| if err != nil { | |||
| fmt.Fprintf(s.Err, "Error determining LDAP group membership for %q: %v. Continuing with the next LDAP group.", ldapGroupUID, err) | |||
| fmt.Fprintf(s.Err, "Error determining LDAP group membership for %q: %v. Continuing with the next LDAP group.\n", ldapGroupUID, err) | |||
There was a problem hiding this comment.
kill ". Continuing with the next LDAP group." globally, I think... there may not be a next group... you'll see status on the next group when it prints
There was a problem hiding this comment.
kill ". Continuing with the next LDAP group." globally, I think... there may not be a next group... you'll see status on the next group when it prints
done.
deads2k
force-pushed
the
enhanced-ad
branch
3 times, most recently
from
aa31a91 to
090e7bd
Compare
|
[test][extended:authentication] |
|
LGTM now. |
|
LGTM |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/5720/) |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/3599/) (Image: devenv-fedora_2464) |
|
infrastructure [merge] |
|
Evaluated for origin merge up to 115cc5d |
|
Evaluated for origin test up to 115cc5d |
Merged by openshift-bot
Adds support for the augmented AD with first-class users, first-class groups, membership on the users, metadata on the groups.
@stevekuznetsov