Skip to content

OCPNODE-4604: allow registry.redhat.io reboot requried test#31383

Open
QiWang19 wants to merge 1 commit into
openshift:mainfrom
QiWang19:add-allow-list
Open

OCPNODE-4604: allow registry.redhat.io reboot requried test#31383
QiWang19 wants to merge 1 commit into
openshift:mainfrom
QiWang19:add-allow-list

Conversation

@QiWang19

@QiWang19 QiWang19 commented Jul 14, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Fix presubmits payload job failure: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/openshift-origin-31324-nightly-5.0-e2e-aws-disruptive-longrunning-techpreview-1of2/2076788709641949184
Back-off pulling image \"registry.redhat.io...

from similar events): Container image \"quay-proxy.ci.openshift.org/openshift/ci@sha256:01b9dcc7e27f1174669d64465c7704a26a1e4fb3b3aaf5a231fffa013bedf8a1\" already present on machine and can be accessed by the pod map[count:49 firstTimestamp:2026-07-14T00:53:02Z lastTimestamp:2026-07-14T01:24:20Z reason:Pulled]}"
time="2026-07-14T01:24:43Z" level=info msg="event interval matches AllowImagePullBackOffFromRedHatRegistry" locator="{Kind map[hmsg:9cbd5bc1d8 namespace:openshift-marketplace node:ip-10-0-53-67.us-east-2.compute.internal pod:redhat-operators-qgrd9]}" message="{BackOff  Back-off pulling image \"registry.redhat.io/redhat/redhat-operator-index:v5.0\" map[count:108 firstTimestamp:2026-07-14T00:59:45Z lastTimestamp:2026-07-14T01:24:43Z reason:BackOff]}"
time="2026-07-14T01:24:46Z" level=info msg="event interval matches AllowImagePullBackOffFromRedHatRegistry" locator="{Kind map[hmsg:2cbaa4df2c namespace:openshift-marketplace node:ip-10-0-53-67.us-east-2.compute.internal pod:community-operators-v9lgp]}" message="{BackOff  Back-off pulling image \"registry.redhat.io/redhat/community-operator-index:v5.0\" map[count:108 firstTimestamp:2026-07-14T00:59:43Z lastTimestamp:2026-07-14T01:24:46Z reason:BackOff]}"
time="2026-07-14T01:24:51Z" level=info msg="event interval matches AllowImagePullBackOffFromRedHatRegistry" locator="{Kind map[hmsg:5c3c2b1a15 namespace:openshift-marketplace node:ip-10-0-53-67.us-east-2.compute.internal pod:certified-operators-fqbx4]}" message="{BackOff  Back-off pulling image \"registry.redhat.io/redhat/certified-operator-index:v5.0\" map[count:109 firstTimestamp:2026-07-14T00:59:42Z lastTimestamp:2026-07-14T01:24:51Z reason:BackOff]}"
  STEP: Creating a kubernetes client @ 07/14/26 00:45:48.472
I0714 00:45:48.474148 6594 framework.go:2330] [precondition-check] checking if cluster is MicroShift
I0714 00:45:48.476826 6594 framework.go:2353] IsMicroShiftCluster: microshift-version configmap not found, not MicroShift
  STEP: Save the original image.config for later restore @ 07/14/26 00:45:48.476
  STEP: Update image.config to add search registry and allowed registries @ 07/14/26 00:45:48.491
  STEP: Wait for worker and master MCP rollout to complete @ 07/14/26 00:45:48.508
I0714 00:45:48.508702 6594 imagepolicy.go:695] Waiting for pool worker to complete
I0714 00:53:54.856755 6594 imagepolicy.go:695] Waiting for pool master to complete
  [FAILED] in [It] - github.com/openshift/origin/test/extended/imagepolicy/imagepolicy.go:710 @ 07/14/26 01:13:54.864
I0714 01:13:54.865054 6594 image_registry_config.go:50] Cleanup: restoring original image.config
I0714 01:13:54.884376 6594 imagepolicy.go:695] Waiting for pool worker to complete
I0714 01:21:15.089361 6594 imagepolicy.go:695] Waiting for pool master to complete
  [INTERRUPTED] in [DeferCleanup (Each)] - github.com/openshift/origin/test/extended/node/node_e2e/image_registry_config.go:49 @ 07/14/26 01:25:48.096
  ------------------------------
  Interrupted by User
  First interrupt received; Ginkgo will run any cleanup and reporting nodes but will skip all remaining specs.  Interrupt again to skip cleanup.
  Here's a current progress report:
    [Suite:openshift/disruptive-longrunning][sig-node][Disruptive] Image registry config [OTP] change container registry config [OCP-44820] (Spec Runtime: 39m59.635s)
      github.com/openshift/origin/test/extended/node/node_e2e/image_registry_config.go:38
      In [DeferCleanup (Each)] (Node Runtime: 11m53.231s)
        github.com/openshift/origin/test/extended/node/node_e2e/image_registry_config.go:49

      Spec Goroutine
      goroutine 487 [select]
        github.com/onsi/gomega/internal.(*AsyncAssertion).match(0x3739c7b0c310, {0x9d54110, 0x3739c989e3f0}, 0x1, {0x0, 0x0, 0x0})
          github.com/onsi/gomega@v1.38.2/internal/async_assertion.go:558
        github.com/onsi/gomega/internal.(*AsyncAssertion).Should(0x3739c7b0c310, {0x9d54110, 0x3739c989e3f0}, {0x0, 0x0, 0x0})
          github.com/onsi/gomega@v1.38.2/internal/async_assertion.go:145
        github.com/openshift/origin/test/extended/imagepolicy.WaitForMCPConfigSpecChangeAndUpdated(0x3739c9f25200, {0x958a59f, 0x6}, {0x3739c7427290, 0x30})
          github.com/openshift/origin/test/extended/imagepolicy/imagepolicy.go:710
      > github.com/openshift/origin/test/extended/node/node_e2e.init.func2.2.1()
          github.com/openshift/origin/test/extended/node/node_e2e/image_registry_config.go:66
        reflect.Value.call({0x83bc880?, 0x3739cb6f9290?, 0x13?}, {0x9584bae, 0x4}, {0x10d372a0, 0x0, 0x0?})
          reflect/value.go:586
        reflect.Value.Call({0x83bc880?, 0x3739cb6f9290?, 0x0?}, {0x10d372a0?, 0x3739c6f85e98?, 0x0?})
          reflect/value.go:369
        github.com/onsi/ginkgo/v2/internal.NewCleanupNode.func3()
          github.com/onsi/ginkgo/v2@v2.25.1/internal/node.go:646
        github.com/onsi/ginkgo/v2/internal.extractBodyFunction.func3({0x0?, 0x0?})
          github.com/onsi/ginkgo/v2@v2.25.1/internal/node.go:524
        github.com/onsi/ginkgo/v2/internal.(*Suite).runNode.func3()
          github.com/onsi/ginkgo/v2@v2.25.1/internal/suite.go:949
        github.com/onsi/ginkgo/v2/internal.(*Suite).runNode in goroutine 239
          github.com/onsi/ginkgo/v2@v2.25.1/internal/suite.go:914
  ------------------------------

fail [github.com/openshift/origin/test/extended/imagepolicy/imagepolicy.go:710]: Timed out after 1200.002s.
Expected
    <bool>: false
to be true
failed: (40m0s) 2026-07-14T01:25:48 "[Suite:openshift/disruptive-longrunning][sig-node][Disruptive] Image registry config [OTP] change container registry config [OCP-44820] [Serial]"

Summary by CodeRabbit

  • Tests
    • Updated end-to-end registry configuration coverage to include registry.redhat.io as an allowed image registry.
    • Continued validating registry settings across cluster nodes after configuration rollout.

@QiWang19
allow registry.redhat.io reboot requried test
bfd0e97 
Signed-off-by: Qi Wang <qiwan@redhat.com>
@openshift-merge-bot

openshift-merge-bot Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@coderabbitai

coderabbitai Bot commented Jul 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Walkthrough

The image registry configuration test now includes registry.redhat.io in the cluster-wide allowed registry list while retaining the existing rollout and node configuration validation flow.

Changes

Registry Configuration

Layer / File(s) Summary
Expand allowed registry set
test/extended/node/node_e2e/image_registry_config.go		 Adds registry.redhat.io to AllowedRegistries in the cluster image configuration test.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Single Node Openshift (Sno) Test Compatibility ⚠️ Warning The test requires pure worker nodes via GetReadySchedulableWorkerNodes and asserts the list is non-empty; on SNO that helper returns none, and there is no SNO skip. Add a [Skipped:SingleReplicaTopology] label or guard with exutil.IsSingleNode()/skipOnSingleNodeTopology() before selecting worker nodes.
✅ Passed checks (14 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The only Ginkgo title in the changed test is a static string; the PR only alters registry allowlist contents, not test names.
Test Structure And Quality ✅ Passed PASS: The test is focused, uses BeforeEach/DeferCleanup, includes bounded Eventually and 20m MCP waits, and follows existing assertion patterns.
Microshift Test Compatibility ✅ Passed The test is already guarded by exutil.IsMicroShiftCluster() and g.Skip(), so MicroShift-incompatible APIs like MachineConfigPool are not a compatibility issue.
Topology-Aware Scheduling Compatibility ✅ Passed Only a test updates allowed registries; no pod specs, nodeSelectors, anti-affinity, spread constraints, or replica logic were introduced.
Ote Binary Stdout Contract ✅ Passed No process-level stdout writes were added; the file only uses e2e.Logf inside It/DeferCleanup blocks, with no init/TestMain/BeforeSuite/AfterSuite output.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The test only updates image.config and verifies node files; no hardcoded IPv4s or direct network calls. registry.redhat.io appears only as config data.
No-Weak-Crypto ✅ Passed The only code change adds registry.redhat.io to an allowlist; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons appear in the diff.
Container-Privileges ✅ Passed Only a Go test registry list changed; no manifests or privilege-related fields (privileged, hostPID, hostNetwork, etc.) were added.
No-Sensitive-Data-In-Logs ✅ Passed The patch only adds registry.redhat.io to allowed registries; existing log lines and hostnames were unchanged.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title references the registry.redhat.io test change and matches the main intent, despite the typo.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot requested review from cpmeadors and sairameshv July 14, 2026 05:36
@openshift-ci

openshift-ci Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: QiWang19
Once this PR has been reviewed and has the lgtm label, please assign cpmeadors for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@QiWang19

QiWang19 commented Jul 14, 2026

Copy link
Copy Markdown
Member Author

/payload-job periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-disruptive-longrunning-techpreview-1of2

@openshift-ci

openshift-ci Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

@QiWang19: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-disruptive-longrunning-techpreview-1of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fe107b40-7f45-11f1-9142-021f56125872-0

@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Jul 14, 2026
@QiWang19 QiWang19 changed the title allow registry.redhat.io reboot requried test OCPNODE-4604: allow registry.redhat.io reboot requried test Jul 14, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 14, 2026 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown

@QiWang19: This pull request references OCPNODE-4604 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Fix presubmits payload job failure: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/openshift-origin-31324-nightly-5.0-e2e-aws-disruptive-longrunning-techpreview-1of2/2076788709641949184
Back-off pulling image \"registry.redhat.io...

from similar events): Container image \"quay-proxy.ci.openshift.org/openshift/ci@sha256:01b9dcc7e27f1174669d64465c7704a26a1e4fb3b3aaf5a231fffa013bedf8a1\" already present on machine and can be accessed by the pod map[count:49 firstTimestamp:2026-07-14T00:53:02Z lastTimestamp:2026-07-14T01:24:20Z reason:Pulled]}"
time="2026-07-14T01:24:43Z" level=info msg="event interval matches AllowImagePullBackOffFromRedHatRegistry" locator="{Kind map[hmsg:9cbd5bc1d8 namespace:openshift-marketplace node:ip-10-0-53-67.us-east-2.compute.internal pod:redhat-operators-qgrd9]}" message="{BackOff  Back-off pulling image \"registry.redhat.io/redhat/redhat-operator-index:v5.0\" map[count:108 firstTimestamp:2026-07-14T00:59:45Z lastTimestamp:2026-07-14T01:24:43Z reason:BackOff]}"
time="2026-07-14T01:24:46Z" level=info msg="event interval matches AllowImagePullBackOffFromRedHatRegistry" locator="{Kind map[hmsg:2cbaa4df2c namespace:openshift-marketplace node:ip-10-0-53-67.us-east-2.compute.internal pod:community-operators-v9lgp]}" message="{BackOff  Back-off pulling image \"registry.redhat.io/redhat/community-operator-index:v5.0\" map[count:108 firstTimestamp:2026-07-14T00:59:43Z lastTimestamp:2026-07-14T01:24:46Z reason:BackOff]}"
time="2026-07-14T01:24:51Z" level=info msg="event interval matches AllowImagePullBackOffFromRedHatRegistry" locator="{Kind map[hmsg:5c3c2b1a15 namespace:openshift-marketplace node:ip-10-0-53-67.us-east-2.compute.internal pod:certified-operators-fqbx4]}" message="{BackOff  Back-off pulling image \"registry.redhat.io/redhat/certified-operator-index:v5.0\" map[count:109 firstTimestamp:2026-07-14T00:59:42Z lastTimestamp:2026-07-14T01:24:51Z reason:BackOff]}"
 STEP: Creating a kubernetes client @ 07/14/26 00:45:48.472
I0714 00:45:48.474148 6594 framework.go:2330] [precondition-check] checking if cluster is MicroShift
I0714 00:45:48.476826 6594 framework.go:2353] IsMicroShiftCluster: microshift-version configmap not found, not MicroShift
 STEP: Save the original image.config for later restore @ 07/14/26 00:45:48.476
 STEP: Update image.config to add search registry and allowed registries @ 07/14/26 00:45:48.491
 STEP: Wait for worker and master MCP rollout to complete @ 07/14/26 00:45:48.508
I0714 00:45:48.508702 6594 imagepolicy.go:695] Waiting for pool worker to complete
I0714 00:53:54.856755 6594 imagepolicy.go:695] Waiting for pool master to complete
 [FAILED] in [It] - github.com/openshift/origin/test/extended/imagepolicy/imagepolicy.go:710 @ 07/14/26 01:13:54.864
I0714 01:13:54.865054 6594 image_registry_config.go:50] Cleanup: restoring original image.config
I0714 01:13:54.884376 6594 imagepolicy.go:695] Waiting for pool worker to complete
I0714 01:21:15.089361 6594 imagepolicy.go:695] Waiting for pool master to complete
 [INTERRUPTED] in [DeferCleanup (Each)] - github.com/openshift/origin/test/extended/node/node_e2e/image_registry_config.go:49 @ 07/14/26 01:25:48.096
 ------------------------------
 Interrupted by User
 First interrupt received; Ginkgo will run any cleanup and reporting nodes but will skip all remaining specs.  Interrupt again to skip cleanup.
 Here's a current progress report:
   [Suite:openshift/disruptive-longrunning][sig-node][Disruptive] Image registry config [OTP] change container registry config [OCP-44820] (Spec Runtime: 39m59.635s)
     github.com/openshift/origin/test/extended/node/node_e2e/image_registry_config.go:38
     In [DeferCleanup (Each)] (Node Runtime: 11m53.231s)
       github.com/openshift/origin/test/extended/node/node_e2e/image_registry_config.go:49

     Spec Goroutine
     goroutine 487 [select]
       github.com/onsi/gomega/internal.(*AsyncAssertion).match(0x3739c7b0c310, {0x9d54110, 0x3739c989e3f0}, 0x1, {0x0, 0x0, 0x0})
         github.com/onsi/gomega@v1.38.2/internal/async_assertion.go:558
       github.com/onsi/gomega/internal.(*AsyncAssertion).Should(0x3739c7b0c310, {0x9d54110, 0x3739c989e3f0}, {0x0, 0x0, 0x0})
         github.com/onsi/gomega@v1.38.2/internal/async_assertion.go:145
       github.com/openshift/origin/test/extended/imagepolicy.WaitForMCPConfigSpecChangeAndUpdated(0x3739c9f25200, {0x958a59f, 0x6}, {0x3739c7427290, 0x30})
         github.com/openshift/origin/test/extended/imagepolicy/imagepolicy.go:710
     > github.com/openshift/origin/test/extended/node/node_e2e.init.func2.2.1()
         github.com/openshift/origin/test/extended/node/node_e2e/image_registry_config.go:66
       reflect.Value.call({0x83bc880?, 0x3739cb6f9290?, 0x13?}, {0x9584bae, 0x4}, {0x10d372a0, 0x0, 0x0?})
         reflect/value.go:586
       reflect.Value.Call({0x83bc880?, 0x3739cb6f9290?, 0x0?}, {0x10d372a0?, 0x3739c6f85e98?, 0x0?})
         reflect/value.go:369
       github.com/onsi/ginkgo/v2/internal.NewCleanupNode.func3()
         github.com/onsi/ginkgo/v2@v2.25.1/internal/node.go:646
       github.com/onsi/ginkgo/v2/internal.extractBodyFunction.func3({0x0?, 0x0?})
         github.com/onsi/ginkgo/v2@v2.25.1/internal/node.go:524
       github.com/onsi/ginkgo/v2/internal.(*Suite).runNode.func3()
         github.com/onsi/ginkgo/v2@v2.25.1/internal/suite.go:949
       github.com/onsi/ginkgo/v2/internal.(*Suite).runNode in goroutine 239
         github.com/onsi/ginkgo/v2@v2.25.1/internal/suite.go:914
 ------------------------------

fail [github.com/openshift/origin/test/extended/imagepolicy/imagepolicy.go:710]: Timed out after 1200.002s.
Expected
   <bool>: false
to be true
failed: (40m0s) 2026-07-14T01:25:48 "[Suite:openshift/disruptive-longrunning][sig-node][Disruptive] Image registry config [OTP] change container registry config [OCP-44820] [Serial]"

Summary by CodeRabbit

  • Tests
  • Updated end-to-end registry configuration coverage to include registry.redhat.io as an allowed image registry.
  • Continued validating registry settings across cluster nodes after configuration rollout.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 14, 2026
@openshift-merge-bot

openshift-merge-bot Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes
@cpmeadors cpmeadors Awaiting requested review from cpmeadors
@sairameshv sairameshv Awaiting requested review from sairameshv

Assignees

No one assigned

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@QiWang19 @openshift-ci-robot