Skip to content

[wip] Update code to correctly count flakes #30032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[wip] Update code to correctly count flakes #30032

wants to merge 1 commit into from

Conversation

stbenjam
Copy link
Member

The counting code assumed all tests were retried, meaning tests that failed and didn't get retried might not be reported correctly.

@stbenjam
Copy link
Member Author

/test e2e-aws-ovn

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 30, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 30, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2025
@stbenjam
Copy link
Member Author

/test e2e-aws-ovn

@stbenjam stbenjam force-pushed the ote-failure branch 4 times, most recently from 95337f8 to 1c94757 Compare July 31, 2025 02:04
@stbenjam stbenjam marked this pull request as ready for review July 31, 2025 02:06
@openshift-ci openshift-ci bot requested review from p0lyn0mial and sjenning July 31, 2025 02:06
@stbenjam
Clean up code to correctly handle test results
0ad4c77 
The counting code assumed all tests were retried, meaning tests that
failed and didn't get retried might not be reported correctly
count-wise.

This also ensures we handle informing-lifecycle OTE tests correctly.
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 31, 2025

@stbenjam: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn 0ad4c77 link false /test e2e-aws-ovn
ci/prow/e2e-vsphere-ovn 0ad4c77 link true /test e2e-vsphere-ovn
ci/prow/e2e-aws-disruptive 0ad4c77 link false /test e2e-aws-disruptive
ci/prow/e2e-aws-ovn-kube-apiserver-rollout 0ad4c77 link false /test e2e-aws-ovn-kube-apiserver-rollout
ci/prow/okd-scos-e2e-aws-ovn 0ad4c77 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-metal-ipi-virtualmedia 0ad4c77 link false /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-aws-ovn-cgroupsv2 0ad4c77 link false /test e2e-aws-ovn-cgroupsv2
ci/prow/e2e-agnostic-ovn-cmd 0ad4c77 link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-aws-ovn-fips 0ad4c77 link true /test e2e-aws-ovn-fips
ci/prow/e2e-gcp-ovn 0ad4c77 link true /test e2e-gcp-ovn
ci/prow/e2e-metal-ipi-serial-2of2 0ad4c77 link false /test e2e-metal-ipi-serial-2of2
ci/prow/e2e-gcp-ovn-techpreview 0ad4c77 link false /test e2e-gcp-ovn-techpreview
ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout 0ad4c77 link false /test e2e-metal-ipi-ovn-kube-apiserver-rollout
ci/prow/e2e-azure 0ad4c77 link false /test e2e-azure
ci/prow/e2e-metal-ipi-ovn-dualstack 0ad4c77 link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-aws-ovn-edge-zones 0ad4c77 link true /test e2e-aws-ovn-edge-zones
ci/prow/e2e-metal-ipi-serial-ovn-ipv6-1of2 0ad4c77 link false /test e2e-metal-ipi-serial-ovn-ipv6-1of2
ci/prow/e2e-gcp-ovn-rt-upgrade 0ad4c77 link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-openstack-ovn 0ad4c77 link false /test e2e-openstack-ovn
ci/prow/e2e-aws-proxy 0ad4c77 link false /test e2e-aws-proxy
ci/prow/e2e-aws-ovn-single-node 0ad4c77 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-metal-ipi-ovn-dualstack-local-gateway 0ad4c77 link false /test e2e-metal-ipi-ovn-dualstack-local-gateway
ci/prow/e2e-aws-ovn-serial-2of2 0ad4c77 link true /test e2e-aws-ovn-serial-2of2
ci/prow/e2e-hypershift-conformance 0ad4c77 link false /test e2e-hypershift-conformance
ci/prow/e2e-vsphere-ovn-upi 0ad4c77 link true /test e2e-vsphere-ovn-upi
ci/prow/e2e-aws-ovn-single-node-upgrade 0ad4c77 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-metal-ipi-ovn 0ad4c77 link false /test e2e-metal-ipi-ovn
ci/prow/e2e-gcp-ovn-upgrade 0ad4c77 link true /test e2e-gcp-ovn-upgrade
ci/prow/e2e-metal-ipi-serial-ovn-ipv6-2of2 0ad4c77 link false /test e2e-metal-ipi-serial-ovn-ipv6-2of2
ci/prow/e2e-metal-ipi-serial-1of2 0ad4c77 link false /test e2e-metal-ipi-serial-1of2
ci/prow/e2e-metal-ipi-ovn-ipv6 0ad4c77 link true /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 9, 2025
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

@sjenning sjenning Awaiting requested review from sjenning

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stbenjam @openshift-merge-robot