OCPEDGE-1969: add recovery tests for TNA #30022
Conversation
Signed-off-by: nhamza <nhamza@redhat.com>
openshift-ci-robot
added
the
jira/valid-reference
|
@Neilhamza: This pull request references OCPEDGE-1969 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Signed-off-by: nhamza <nhamza@redhat.com>
|
Job Failure Risk Analysis for sha: 1bac549
|
|
@Neilhamza Are you splitting out the code in common.go to make it reusable by Arbiter only ? |
i have splitted the code because it can be reused by any test not just arbiter |
|
/lgtm |
|
/test e2e-metal-ovn-two-node-arbiter |
|
@Neilhamza: This pull request references OCPEDGE-1969 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Signed-off-by: nhamza <nhamza@redhat.com>
|
/lgtm Holding for now until the API gets updated with Arbiter GA |
openshift-ci
bot
added
the
do-not-merge/hold
|
/unhold API change has been merged in |
openshift-ci
bot
removed
the
do-not-merge/hold
| }) | ||
| }) | ||
|
|
||
| var _ = g.Describe("[sig-etcd][apigroup:config.openshift.io][OCPFeatureGate:HighlyAvailableArbiter][Suite:openshift/two-node][Disruptive] Recovery when arbiter node is down and master nodes restart", func() { |
There was a problem hiding this comment.
Where did this run? I did not see this in the two-node arbitor job.
There was a problem hiding this comment.
@xueqzhan these tests will be ran on a separate lane most possibly alone
So once this gets merged ill create the lane
There was a problem hiding this comment.
Good question, these tests are designed to be run as part of the two-node suite. So they won't show up on the regular runs, @Neilhamza will be creating some lanes to utilize them
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhensel-rh, eggfoobar, Neilhamza, xueqzhan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/hold Revision 9881db2 was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest-required |
2 similar comments
|
/retest-required |
|
/retest-required |
|
@Neilhamza: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
|
Job Failure Risk Analysis for sha: 9881db2
|
add recovery tests for TNA
update common.go
arbiter e2e run