Skip to content

Add PreconfiguredUDNAddresses FG tests #30010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

RamLavi
Copy link

@RamLavi RamLavi commented Jul 22, 2025

This PR adds tests to check the PreconfiguredUDNAddresses FG:

  • create VM with Preconfigured IPs, then restart.
  • create VM with Preconfigured MAC, then restart.
  • create VM with IPs and MAC, then migrate
  • create VM with Preconfigured IPs, assert you can't have IP collision
  • create VM with Preconfigured MAC, assert you can't have MAC collision

@openshift-ci openshift-ci bot requested review from trozet and tssurya July 22, 2025 14:22
Copy link
Contributor

@maiqueb maiqueb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is really nice, thanks for that.

I just have some questions, nits, nothing big.

Let's see how this fares on CI. Fingers crossed.

Comment on lines 159 to 160
expectedIPs := strings.Split(netConfig.preconfiguredIP, ",")
for _, expectedIP := range expectedIPs {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this is opinionated; couldn't you inline these ? like

Suggested change
expectedIPs := strings.Split(netConfig.preconfiguredIP, ",")
for _, expectedIP := range expectedIPs {
for _, expectedIP := range strings.Split(netConfig.preconfiguredIP, ",") {

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

Comment on lines 181 to 182
ShouldNot(BeEmpty())
Expect(actualMAC).To(Equal(netConfig.preconfiguredMAC))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't it make sense to actually mix these two up ?

Something like

Suggested change
ShouldNot(BeEmpty())
Expect(actualMAC).To(Equal(netConfig.preconfiguredMAC))
Should(Equal(netConfig.preconfiguredMAC))

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

totally.

Comment on lines 210 to 215
GinkgoHelper()

var err error
postMigrationMAC, err = obtainMAC(virtClient, vmName)
g.Expect(err).NotTo(HaveOccurred(), "Failed to obtain MAC address for VM after migration")
return postMigrationMAC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you can export this into an helper func ? which would be re-used in the other test - AFAIU, the only difference at play is the name of the variable where you put the MAC addr.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DONE

Comment on lines 502 to 536
func macFromStatus(cli *kubevirt.Client, vmName string) (string, error) {
macStr, err := cli.GetJSONPath("vmi", vmName, "{@.status.interfaces[0].mac}")
if err != nil {
return "", fmt.Errorf("failed to extract the MAC address from VM %q: %w", vmName, err)
}
return macStr, nil
}

func obtainMAC(virtClient *kubevirt.Client, vmName string) (string, error) {
return macFromStatus(virtClient, vmName)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we have these 2 fns ? one just calls the other.

Copy link
Author

@RamLavi RamLavi Jul 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was following the IP obtain function

func obtainAddresses(virtClient *kubevirt.Client, vmName string) ([]string, error) {
	return addressFromStatus(virtClient, vmName)
}

but might as well unify the calls into one. DONE.

return macStr, nil
}

func obtainMAC(virtClient *kubevirt.Client, vmName string) (string, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we already have a function to extract the VM's MAC address from the status @qinqon ?

@@ -93,6 +93,29 @@ func (c *Client) GetJSONPath(resource, name, jsonPath string) (string, error) {
}
return strings.TrimSuffix(strings.TrimPrefix(output, `"`), `"`), nil
}

func (c *Client) GetPodsByLabel(labelKey, labelValue string) ([]string, error) {
output, err := c.oc.AsAdmin().Run("get").Args("pods", "-n", c.oc.Namespace(), "-l", fmt.Sprintf("%s=%s", labelKey, labelValue), "-o", "jsonpath={.items[*].metadata.name}").Output()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: do we really need to be "admin" for this ? I assume yes, since we're entering arbitrary namespaces though.

Copy link
Author

@RamLavi RamLavi Jul 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume so, will check once I have a cluster running.

duplicateVMName := vmName + "-duplicate"
By(fmt.Sprintf("Duplicating VM %s/%s to %s/%s", vmNamespace, vmName, vmNamespace, duplicateVMName))

vmiSpecJSON, err := cli.GetJSONPath("vmi", vmName, "{.spec}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldn't you do this without reading from the API ? I mean, just do some oldVMI.DeepCopy() kind of thing ?

I think you'd need to turn duplicateVM into an higher order function though - you'd pass the VM from the test into the function returned by this higher order fn.

Opinionated nit.

Copy link
Author

@RamLavi RamLavi Jul 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, the thing is - If I want to reuse this DescribeTable - I need the function to fit opCmd:

opCmd func(cli *kubevirt.Client, vmNamespace, vmName string)

So in order to do so I had to duplicate the VM with only these params.

I kinda think it's keeps things tidy, but if you prefer I can copy this big DescribeTable to a standalone test where I can create the duplicate VM is a more standard way.
When I tried it I had to create a bunch of helpers to try and avoid duplicate code from the current test, and it ended up less nice and tidy than the current way imo..

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's keep it as is then.

return []string{}
}

virtLauncherPodName := podNames[0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, we're "safe" in the sense we won't see > 1 pod here since your get pods by label function checks pods in the test's namespace, right ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that, and the fact that I don't expect this VM to be migrating.

@RamLavi RamLavi force-pushed the add_PreconfiguredUDNAddresses_FG_e2e branch from 3ad3231 to 8d6569e Compare July 22, 2025 18:40
@RamLavi
Copy link
Author

RamLavi commented Jul 22, 2025

Change: address @maiqueb 's review

@maiqueb
Copy link
Contributor

maiqueb commented Jul 22, 2025

/test e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview

Copy link

openshift-trt bot commented Jul 22, 2025

Job Failure Risk Analysis for sha: 8d6569e

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-etcd-scaling Medium
[sig-architecture] platform pods in ns/openshift-etcd should not exit an excessive amount of times
Potential external regression detected for High Risk Test analysis

Open Bugs
etcd platform pod exist test failing on etcd-scaling jobs
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift-serial Low
[sig-storage] CSI Mock selinux on mount metrics and SELinuxWarningController SELinuxMount metrics [LinuxOnly] [Feature:SELinux] [Serial] error is bumped on two Pods with a different context on RWOP volume [FeatureGate:SELinuxMountReadWriteOncePod] [Beta] [FeatureGate:SELinuxChangePolicy] [Beta] [FeatureGate:SELinuxMountReadWriteOncePod] [Beta] [Suite:openshift/conformance/serial] [Suite:k8s]
This test has passed 0.00% of 4 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:standard Network:ovn NetworkStack:ipv4 Owner:eng Platform:aws SecurityMode:default Topology:microshift Upgrade:none] in the last week.
---
[sig-api-machinery] OrderedNamespaceDeletion namespace deletion should delete pod first [Feature:OrderedNamespaceDeletion] [FeatureGate:OrderedNamespaceDeletion] [Beta] [Serial] [Suite:openshift/conformance/serial] [Suite:k8s]
This test has passed 0.00% of 4 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:standard Network:ovn NetworkStack:ipv4 Owner:eng Platform:aws SecurityMode:default Topology:microshift Upgrade:none] in the last week.
---
[sig-storage] CSI Mock selinux on mount metrics and SELinuxWarningController SELinuxMount metrics [LinuxOnly] [Feature:SELinux] [Serial] warning is bumped on two Pods with a different context on RWO volume [FeatureGate:SELinuxMountReadWriteOncePod] [Beta] [FeatureGate:SELinuxChangePolicy] [Beta] [Feature:SELinuxMountReadWriteOncePodOnly] [Suite:openshift/conformance/serial] [Suite:k8s]
This test has passed 0.00% of 4 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:standard Network:ovn NetworkStack:ipv4 Owner:eng Platform:aws SecurityMode:default Topology:microshift Upgrade:none] in the last week.
---
[sig-storage] CSI Mock selinux on mount metrics and SELinuxWarningController SELinuxMount metrics [LinuxOnly] [Feature:SELinux] [Serial] warning is not bumped on two Pods with Recursive policy and a different context on RWO volume [FeatureGate:SELinuxMountReadWriteOncePod] [Beta] [FeatureGate:SELinuxChangePolicy] [Beta] [FeatureGate:SELinuxChangePolicy] [Beta] [Feature:SELinuxMountReadWriteOncePodOnly] [Suite:openshift/conformance/serial] [Suite:k8s]
This test has passed 0.00% of 4 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:standard Network:ovn NetworkStack:ipv4 Owner:eng Platform:aws SecurityMode:default Topology:microshift Upgrade:none] in the last week.
---
Showing 4 of 6 test results
pull-ci-openshift-origin-main-e2e-vsphere-ovn-etcd-scaling Low
[sig-api-machinery] disruption/kube-api apiserver/kube-apiserver connection/new should be available throughout the test
This test has passed 0.00% of 1 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:vsphere SecurityMode:default Topology:ha Upgrade:none] in the last week.
---
[bz-Cloud Compute] clusteroperator/control-plane-machine-set should not change condition/Degraded
This test has passed 0.00% of 1 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:vsphere SecurityMode:default Topology:ha Upgrade:none] in the last week.

Open Bugs
etcd-scaling jobs failing ~60% of the time
---
[bz-kube-storage-version-migrator] clusteroperator/kube-storage-version-migrator should not change condition/Available
This test has passed 0.00% of 1 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:vsphere SecurityMode:default Topology:ha Upgrade:none] in the last week.

Open Bugs
etcd-scaling jobs failing ~60% of the time
[CI] e2e-openstack-ovn-etcd-scaling job permanent fails at many openshift-test tests
---
[sig-api-machinery] disruption/cache-oauth-api apiserver/oauth-apiserver connection/new should be available throughout the test
This test has passed 0.00% of 1 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:vsphere SecurityMode:default Topology:ha Upgrade:none] in the last week.
---
Showing 4 of 5 test results

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: 8d6569e

Job Name New Test Risk
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview High - "[sig-network][OCPFeatureGate:PersistentIPsForVirtualization][Feature:Layer2LiveMigration] Kubevirt Virtual Machines when using openshift ovn-kubernetes with user defined networks and persistent ips configured created using NetworkAttachmentDefinitions [Suite:openshift/network/virtualization] should keep ip [OCPFeatureGate:PreconfiguredUDNAddresses] when the VM with preconfigured IP address is created when the address is already taken" is a new test, was only seen in one job, and failed 1 time(s) against the current commit.
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview High - "[sig-network][OCPFeatureGate:PersistentIPsForVirtualization][Feature:Layer2LiveMigration] Kubevirt Virtual Machines when using openshift ovn-kubernetes with user defined networks and persistent ips configured created using NetworkAttachmentDefinitions [Suite:openshift/network/virtualization] should keep ip [OCPFeatureGate:PreconfiguredUDNAddresses] when the VM with preconfigured IP and MAC attached to a primary UDN is migrated between nodes" is a new test, was only seen in one job, and failed 1 time(s) against the current commit.
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview High - "[sig-network][OCPFeatureGate:PersistentIPsForVirtualization][Feature:Layer2LiveMigration] Kubevirt Virtual Machines when using openshift ovn-kubernetes with user defined networks and persistent ips configured created using NetworkAttachmentDefinitions [Suite:openshift/network/virtualization] should keep ip [OCPFeatureGate:PreconfiguredUDNAddresses] when the VM with preconfigured IPs attached to a primary UDN is restarted" is a new test, was only seen in one job, and failed 1 time(s) against the current commit.
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview High - "[sig-network][OCPFeatureGate:PersistentIPsForVirtualization][Feature:Layer2LiveMigration] Kubevirt Virtual Machines when using openshift ovn-kubernetes with user defined networks and persistent ips configured created using NetworkAttachmentDefinitions [Suite:openshift/network/virtualization] should keep ip [OCPFeatureGate:PreconfiguredUDNAddresses] when the VM with preconfigured MAC address is created when the address is already taken" is a new test, was only seen in one job, and failed 1 time(s) against the current commit.
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview High - "[sig-network][OCPFeatureGate:PersistentIPsForVirtualization][Feature:Layer2LiveMigration] Kubevirt Virtual Machines when using openshift ovn-kubernetes with user defined networks and persistent ips configured created using NetworkAttachmentDefinitions [Suite:openshift/network/virtualization] should keep ip [OCPFeatureGate:PreconfiguredUDNAddresses] when the VM with preconfigured MAC attached to a primary UDN is restarted" is a new test, was only seen in one job, and failed 1 time(s) against the current commit.
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview High - "[sig-network][OCPFeatureGate:PersistentIPsForVirtualization][Feature:Layer2LiveMigration] Kubevirt Virtual Machines when using openshift ovn-kubernetes with user defined networks and persistent ips configured created using [OCPFeatureGate:NetworkSegmentation] UserDefinedNetwork [Suite:openshift/network/virtualization] should keep ip [OCPFeatureGate:PreconfiguredUDNAddresses] when the VM with preconfigured IP address is created when the address is already taken" is a new test, was only seen in one job, and failed 1 time(s) against the current commit.
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview High - "[sig-network][OCPFeatureGate:PersistentIPsForVirtualization][Feature:Layer2LiveMigration] Kubevirt Virtual Machines when using openshift ovn-kubernetes with user defined networks and persistent ips configured created using [OCPFeatureGate:NetworkSegmentation] UserDefinedNetwork [Suite:openshift/network/virtualization] should keep ip [OCPFeatureGate:PreconfiguredUDNAddresses] when the VM with preconfigured IP and MAC attached to a primary UDN is migrated between nodes" is a new test, was only seen in one job, and failed 1 time(s) against the current commit.
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview High - "[sig-network][OCPFeatureGate:PersistentIPsForVirtualization][Feature:Layer2LiveMigration] Kubevirt Virtual Machines when using openshift ovn-kubernetes with user defined networks and persistent ips configured created using [OCPFeatureGate:NetworkSegmentation] UserDefinedNetwork [Suite:openshift/network/virtualization] should keep ip [OCPFeatureGate:PreconfiguredUDNAddresses] when the VM with preconfigured IPs attached to a primary UDN is restarted" is a new test, was only seen in one job, and failed 1 time(s) against the current commit.
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview High - "[sig-network][OCPFeatureGate:PersistentIPsForVirtualization][Feature:Layer2LiveMigration] Kubevirt Virtual Machines when using openshift ovn-kubernetes with user defined networks and persistent ips configured created using [OCPFeatureGate:NetworkSegmentation] UserDefinedNetwork [Suite:openshift/network/virtualization] should keep ip [OCPFeatureGate:PreconfiguredUDNAddresses] when the VM with preconfigured MAC address is created when the address is already taken" is a new test, was only seen in one job, and failed 1 time(s) against the current commit.
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview High - "[sig-network][OCPFeatureGate:PersistentIPsForVirtualization][Feature:Layer2LiveMigration] Kubevirt Virtual Machines when using openshift ovn-kubernetes with user defined networks and persistent ips configured created using [OCPFeatureGate:NetworkSegmentation] UserDefinedNetwork [Suite:openshift/network/virtualization] should keep ip [OCPFeatureGate:PreconfiguredUDNAddresses] when the VM with preconfigured MAC attached to a primary UDN is restarted" is a new test, was only seen in one job, and failed 1 time(s) against the current commit.

New tests seen in this PR at sha: 8d6569e

  • "[sig-network][OCPFeatureGate:PersistentIPsForVirtualization][Feature:Layer2LiveMigration] Kubevirt Virtual Machines when using openshift ovn-kubernetes with user defined networks and persistent ips configured created using NetworkAttachmentDefinitions [Suite:openshift/network/virtualization] should keep ip [OCPFeatureGate:PreconfiguredUDNAddresses] when the VM with preconfigured IP address is created when the address is already taken" [Total: 1, Pass: 0, Fail: 1, Flake: 0]
  • "[sig-network][OCPFeatureGate:PersistentIPsForVirtualization][Feature:Layer2LiveMigration] Kubevirt Virtual Machines when using openshift ovn-kubernetes with user defined networks and persistent ips configured created using NetworkAttachmentDefinitions [Suite:openshift/network/virtualization] should keep ip [OCPFeatureGate:PreconfiguredUDNAddresses] when the VM with preconfigured IP and MAC attached to a primary UDN is migrated between nodes" [Total: 1, Pass: 0, Fail: 1, Flake: 0]
  • "[sig-network][OCPFeatureGate:PersistentIPsForVirtualization][Feature:Layer2LiveMigration] Kubevirt Virtual Machines when using openshift ovn-kubernetes with user defined networks and persistent ips configured created using NetworkAttachmentDefinitions [Suite:openshift/network/virtualization] should keep ip [OCPFeatureGate:PreconfiguredUDNAddresses] when the VM with preconfigured IPs attached to a primary UDN is restarted" [Total: 1, Pass: 0, Fail: 1, Flake: 0]
  • "[sig-network][OCPFeatureGate:PersistentIPsForVirtualization][Feature:Layer2LiveMigration] Kubevirt Virtual Machines when using openshift ovn-kubernetes with user defined networks and persistent ips configured created using NetworkAttachmentDefinitions [Suite:openshift/network/virtualization] should keep ip [OCPFeatureGate:PreconfiguredUDNAddresses] when the VM with preconfigured MAC address is created when the address is already taken" [Total: 1, Pass: 0, Fail: 1, Flake: 0]
  • "[sig-network][OCPFeatureGate:PersistentIPsForVirtualization][Feature:Layer2LiveMigration] Kubevirt Virtual Machines when using openshift ovn-kubernetes with user defined networks and persistent ips configured created using NetworkAttachmentDefinitions [Suite:openshift/network/virtualization] should keep ip [OCPFeatureGate:PreconfiguredUDNAddresses] when the VM with preconfigured MAC attached to a primary UDN is restarted" [Total: 1, Pass: 0, Fail: 1, Flake: 0]
  • "[sig-network][OCPFeatureGate:PersistentIPsForVirtualization][Feature:Layer2LiveMigration] Kubevirt Virtual Machines when using openshift ovn-kubernetes with user defined networks and persistent ips configured created using [OCPFeatureGate:NetworkSegmentation] UserDefinedNetwork [Suite:openshift/network/virtualization] should keep ip [OCPFeatureGate:PreconfiguredUDNAddresses] when the VM with preconfigured IP address is created when the address is already taken" [Total: 1, Pass: 0, Fail: 1, Flake: 0]
  • "[sig-network][OCPFeatureGate:PersistentIPsForVirtualization][Feature:Layer2LiveMigration] Kubevirt Virtual Machines when using openshift ovn-kubernetes with user defined networks and persistent ips configured created using [OCPFeatureGate:NetworkSegmentation] UserDefinedNetwork [Suite:openshift/network/virtualization] should keep ip [OCPFeatureGate:PreconfiguredUDNAddresses] when the VM with preconfigured IP and MAC attached to a primary UDN is migrated between nodes" [Total: 1, Pass: 0, Fail: 1, Flake: 0]
  • "[sig-network][OCPFeatureGate:PersistentIPsForVirtualization][Feature:Layer2LiveMigration] Kubevirt Virtual Machines when using openshift ovn-kubernetes with user defined networks and persistent ips configured created using [OCPFeatureGate:NetworkSegmentation] UserDefinedNetwork [Suite:openshift/network/virtualization] should keep ip [OCPFeatureGate:PreconfiguredUDNAddresses] when the VM with preconfigured IPs attached to a primary UDN is restarted" [Total: 1, Pass: 0, Fail: 1, Flake: 0]
  • "[sig-network][OCPFeatureGate:PersistentIPsForVirtualization][Feature:Layer2LiveMigration] Kubevirt Virtual Machines when using openshift ovn-kubernetes with user defined networks and persistent ips configured created using [OCPFeatureGate:NetworkSegmentation] UserDefinedNetwork [Suite:openshift/network/virtualization] should keep ip [OCPFeatureGate:PreconfiguredUDNAddresses] when the VM with preconfigured MAC address is created when the address is already taken" [Total: 1, Pass: 0, Fail: 1, Flake: 0]
  • "[sig-network][OCPFeatureGate:PersistentIPsForVirtualization][Feature:Layer2LiveMigration] Kubevirt Virtual Machines when using openshift ovn-kubernetes with user defined networks and persistent ips configured created using [OCPFeatureGate:NetworkSegmentation] UserDefinedNetwork [Suite:openshift/network/virtualization] should keep ip [OCPFeatureGate:PreconfiguredUDNAddresses] when the VM with preconfigured MAC attached to a primary UDN is restarted" [Total: 1, Pass: 0, Fail: 1, Flake: 0]

@maiqueb
Copy link
Contributor

maiqueb commented Jul 23, 2025

/testwith e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview openshift/cluster-network-operator#2743 openshift/ovn-kubernetes#2666

Copy link
Contributor

openshift-ci bot commented Jul 23, 2025

@maiqueb, testwith: Error processing request. ERROR:

could not determine job runs: requested job is invalid. needs to be formatted like: <org>/<repo>/<branch>/<variant?>/<job>. instead it was: e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview

@maiqueb
Copy link
Contributor

maiqueb commented Jul 23, 2025

/testwith openshift/origin/main/e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview openshift/cluster-network-operator#2743 openshift/ovn-kubernetes#2666

@kyrtapz
Copy link
Contributor

kyrtapz commented Jul 23, 2025

@kyrtapz
Copy link
Contributor

kyrtapz commented Jul 24, 2025

/testwith openshift/origin/main/e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview openshift/cluster-network-operator#2743 openshift/ovn-kubernetes#2666

@kyrtapz
Copy link
Contributor

kyrtapz commented Jul 25, 2025

/testwith openshift/origin/main/e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview openshift/cluster-network-operator#2743 openshift/ovn-kubernetes#2666

@RamLavi RamLavi force-pushed the add_PreconfiguredUDNAddresses_FG_e2e branch from 8d6569e to be08098 Compare July 27, 2025 10:28
@RamLavi
Copy link
Author

RamLavi commented Jul 27, 2025

Change: fix kubevirt.io/network/addresses annotation expected value format.

@RamLavi
Copy link
Author

RamLavi commented Jul 27, 2025

/testwith openshift/origin/main/e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview openshift/cluster-network-operator#2743 openshift/ovn-kubernetes#2666

Copy link

openshift-trt bot commented Jul 27, 2025

Job Failure Risk Analysis for sha: be08098

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-agnostic-ovn-cmd IncompleteTests
Tests for this run (100) are below the historical average (1818): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-gcp-disruptive IncompleteTests
Tests for this run (12) are below the historical average (147): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-gcp-ovn-techpreview-serial-2of2 Medium
[sig-arch] events should not repeat pathologically for ns/openshift-multus
Potential external regression detected for High Risk Test analysis
---
[sig-arch] events should not repeat pathologically for ns/openshift-network-diagnostics
Potential external regression detected for High Risk Test analysis
pull-ci-openshift-origin-main-e2e-vsphere-ovn-etcd-scaling Low
[sig-api-machinery] disruption/kube-api apiserver/kube-apiserver connection/new should be available throughout the test
This test has passed 0.00% of 1 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:vsphere SecurityMode:default Topology:ha Upgrade:none] in the last week.
---
[sig-api-machinery] disruption/cache-openshift-api apiserver/openshift-apiserver connection/new should be available throughout the test
This test has passed 0.00% of 1 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:vsphere SecurityMode:default Topology:ha Upgrade:none] in the last week.
---
[bz-kube-storage-version-migrator] clusteroperator/kube-storage-version-migrator should not change condition/Available
This test has passed 0.00% of 1 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:vsphere SecurityMode:default Topology:ha Upgrade:none] in the last week.

Open Bugs
etcd-scaling jobs failing ~60% of the time
[CI] e2e-openstack-ovn-etcd-scaling job permanent fails at many openshift-test tests
---
[sig-api-machinery] disruption/cache-oauth-api apiserver/oauth-apiserver connection/new should be available throughout the test
This test has passed 0.00% of 1 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:vsphere SecurityMode:default Topology:ha Upgrade:none] in the last week.
---
Showing 4 of 5 test results

@RamLavi
Copy link
Author

RamLavi commented Jul 27, 2025

@qinqon I dug in the must gather files a bit, could this be relevant to your PR?

/home/ralavi/Downloads/must-gather/registry-build05-ci-openshift-org-ci-op-x9vqhmy1-stable-sha256-3aae3a6466380b0a9dc3da636446807c4554de536d6339bb38b36b93b2e86d4c/namespaces/openshift-ovn-kubernetes/pods/ovnkube-node-rqlgn/ovnkube-controller/ovnkube-controller/logs/current.log:
2025-07-27T13:09:08.272788935Z I0727 13:09:08.270716  149971 event.go:377] Event(v1.ObjectReference{Kind:"Pod", Namespace:"e2e-network-segmentation-e2e-2884", Name:"virt-launcher-myvm-zdvc4", UID:"9d78796d-368e-4ec5-be95-359d8068011b", APIVersion:"v1", ResourceVersion:"88634", FieldPath:""}): type: 'Warning' reason: 'ErrorReconcilingPod' unexpected default NSE namespace "ovn-kubernetes", expected "openshift-ovn-kubernetes"

@qinqon
Copy link
Contributor

qinqon commented Jul 28, 2025

@qinqon I dug in the must gather files a bit, could this be relevant to your PR?

/home/ralavi/Downloads/must-gather/registry-build05-ci-openshift-org-ci-op-x9vqhmy1-stable-sha256-3aae3a6466380b0a9dc3da636446807c4554de536d6339bb38b36b93b2e86d4c/namespaces/openshift-ovn-kubernetes/pods/ovnkube-node-rqlgn/ovnkube-controller/ovnkube-controller/logs/current.log:
2025-07-27T13:09:08.272788935Z I0727 13:09:08.270716  149971 event.go:377] Event(v1.ObjectReference{Kind:"Pod", Namespace:"e2e-network-segmentation-e2e-2884", Name:"virt-launcher-myvm-zdvc4", UID:"9d78796d-368e-4ec5-be95-359d8068011b", APIVersion:"v1", ResourceVersion:"88634", FieldPath:""}): type: 'Warning' reason: 'ErrorReconcilingPod' unexpected default NSE namespace "ovn-kubernetes", expected "openshift-ovn-kubernetes"

This is not related to my PR, this is ipam extensions creating the default-network annotation with wrong namespace, and that means we are missing the openshift virt integratin that configure ipam extensions with "openshift-ovn-kubernetes" namespace instead of "ovn-kubernetes".

@RamLavi
Copy link
Author

RamLavi commented Jul 29, 2025

@qinqon I dug in the must gather files a bit, could this be relevant to your PR?

/home/ralavi/Downloads/must-gather/registry-build05-ci-openshift-org-ci-op-x9vqhmy1-stable-sha256-3aae3a6466380b0a9dc3da636446807c4554de536d6339bb38b36b93b2e86d4c/namespaces/openshift-ovn-kubernetes/pods/ovnkube-node-rqlgn/ovnkube-controller/ovnkube-controller/logs/current.log:
2025-07-27T13:09:08.272788935Z I0727 13:09:08.270716  149971 event.go:377] Event(v1.ObjectReference{Kind:"Pod", Namespace:"e2e-network-segmentation-e2e-2884", Name:"virt-launcher-myvm-zdvc4", UID:"9d78796d-368e-4ec5-be95-359d8068011b", APIVersion:"v1", ResourceVersion:"88634", FieldPath:""}): type: 'Warning' reason: 'ErrorReconcilingPod' unexpected default NSE namespace "ovn-kubernetes", expected "openshift-ovn-kubernetes"

This is not related to my PR, this is ipam extensions creating the default-network annotation with wrong namespace, and that means we are missing the openshift virt integratin that configure ipam extensions with "openshift-ovn-kubernetes" namespace instead of "ovn-kubernetes".

ah. so we need to wait for that in order to make the tests pass.. ACK.

@maiqueb
Copy link
Contributor

maiqueb commented Jul 30, 2025

/testwith openshift/origin/main/e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview openshift/cluster-network-operator#2743 openshift/ovn-kubernetes#2666

@RamLavi RamLavi force-pushed the add_PreconfiguredUDNAddresses_FG_e2e branch from be08098 to 44f8b30 Compare July 31, 2025 09:38
@RamLavi
Copy link
Author

RamLavi commented Jul 31, 2025

Change: rebase

@RamLavi
Copy link
Author

RamLavi commented Jul 31, 2025

/testwith openshift/origin/main/e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview openshift/cluster-network-operator#2743 openshift/ovn-kubernetes#2666

@RamLavi
Copy link
Author

RamLavi commented Jul 31, 2025

/testwith openshift/origin/main/e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview openshift/cluster-network-operator#2743 openshift/ovn-kubernetes#2666

Copy link

openshift-trt bot commented Jul 31, 2025

Job Failure Risk Analysis for sha: 44f8b30

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-agnostic-ovn-cmd IncompleteTests
Tests for this run (104) are below the historical average (1646): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@kyrtapz
Copy link
Contributor

kyrtapz commented Aug 1, 2025

Last run was affected by: openshift/machine-config-operator#5213

/testwith openshift/origin/main/e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview openshift/cluster-network-operator#2743 openshift/ovn-kubernetes#2666

@ormergi
Copy link
Contributor

ormergi commented Aug 3, 2025

Last ran failed early on cluster creation, it seems that it was still affected openshift/machine-config-operator#5213

/testwith openshift/origin/main/e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview openshift/cluster-network-operator#2743 openshift/ovn-kubernetes#2666

@ormergi
Copy link
Contributor

ormergi commented Aug 3, 2025

/testwith openshift/origin/main/e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview openshift/cluster-network-operator#2743 openshift/ovn-kubernetes#2666

@RamLavi
Copy link
Author

RamLavi commented Aug 4, 2025

cluster failed to create.
/testwith openshift/origin/main/e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview openshift/cluster-network-operator#2743 openshift/ovn-kubernetes#2666

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2025
Copy link
Contributor

openshift-ci bot commented Aug 7, 2025

New changes are detected. LGTM label has been removed.

@RamLavi
Copy link
Author

RamLavi commented Aug 7, 2025

Change: refactor to not use pointer when variadic param is already used.

@RamLavi
Copy link
Author

RamLavi commented Aug 7, 2025

/testwith openshift/origin/main/e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview openshift/cluster-network-operator#2743 openshift/ovn-kubernetes#2666

@RamLavi RamLavi force-pushed the add_PreconfiguredUDNAddresses_FG_e2e branch from 94416d4 to 4ee6f4f Compare August 7, 2025 13:56
@RamLavi
Copy link
Author

RamLavi commented Aug 7, 2025

Change: Fix location of kubevirt.io/addresses annotation
Thanks @qinqon !

@RamLavi
Copy link
Author

RamLavi commented Aug 7, 2025

/testwith openshift/origin/main/e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview openshift/cluster-network-operator#2743 openshift/ovn-kubernetes#2666

@RamLavi RamLavi force-pushed the add_PreconfiguredUDNAddresses_FG_e2e branch from 4ee6f4f to 7c16f26 Compare August 7, 2025 19:37
@RamLavi
Copy link
Author

RamLavi commented Aug 7, 2025

Change: Attempt to fix annotation output

@RamLavi
Copy link
Author

RamLavi commented Aug 7, 2025

/testwith openshift/origin/main/e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview openshift/cluster-network-operator#2743 openshift/ovn-kubernetes#2666

@RamLavi RamLavi force-pushed the add_PreconfiguredUDNAddresses_FG_e2e branch from 7c16f26 to 32a45e5 Compare August 7, 2025 22:02
@RamLavi
Copy link
Author

RamLavi commented Aug 7, 2025

/testwith openshift/origin/main/e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview openshift/cluster-network-operator#2743 openshift/ovn-kubernetes#2666

Copy link

openshift-trt bot commented Aug 8, 2025

Job Failure Risk Analysis for sha: 32a45e5

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-disruptive High
[sig-network] pods should successfully create sandboxes by writing network status
This test has passed 99.63% of 3257 runs on release 4.20 [Overall] in the last week.
---
[sig-node] static pods should start after being created
This test has passed 99.42% of 3257 runs on release 4.20 [Overall] in the last week.
---
[bz-Etcd] clusteroperator/etcd should not change condition/Available
This test has passed 99.66% of 3257 runs on release 4.20 [Overall] in the last week.

@RamLavi RamLavi force-pushed the add_PreconfiguredUDNAddresses_FG_e2e branch from 32a45e5 to 62304a5 Compare August 8, 2025 05:32
@RamLavi
Copy link
Author

RamLavi commented Aug 8, 2025

/testwith openshift/origin/main/e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview openshift/cluster-network-operator#2743 openshift/ovn-kubernetes#2666

@RamLavi
Copy link
Author

RamLavi commented Aug 8, 2025

Change: Remove ipv6 instance from static ip test to check if reason of failure is ipv6 not supported

Copy link

openshift-trt bot commented Aug 8, 2025

Job Failure Risk Analysis for sha: 62304a5

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-disruptive High
[sig-arch] events should not repeat pathologically for ns/openshift-kube-apiserver-operator
This test has passed 99.82% of 3253 runs on release 4.20 [Overall] in the last week.
---
[sig-node] node-lifecycle detects unexpected not ready node
This test has passed 99.79% of 3260 runs on release 4.20 [Overall] in the last week.

Open Bugs
node-lifecycle detects unexpected not ready node failing on azure serial and upgrade jobs
Node not ready failures on azure due to networking issue
---
[sig-node] static pods should start after being created
This test has passed 99.42% of 3258 runs on release 4.20 [Overall] in the last week.
---
[sig-arch] events should not repeat pathologically
This test has passed 99.32% of 3253 runs on release 4.20 [Overall] in the last week.

Open Bugs
[CI][OpenStack][sig-arch] events should not repeat pathologically for ns/openshift-machine-api
[CI] e2e-openstack-ovn-etcd-scaling job permanent fails at many openshift-test tests
Backport TRT-596 to release-4.12
Component Readiness: [Machine Config Operator] vsphere techpreview-serial test regressed - events should not repeat pathologically for ns/openshift-machine-config-operator
---
Showing 4 of 6 test results

RamLavi added 3 commits August 8, 2025 13:49
Validates that KubeVirt VMs with preconfigured IP addresses maintain
those addresses correctly before and after restart operation.

Signed-off-by: Ram Lavi <ralavi@redhat.com>
Validates that KubeVirt VMs with preconfigured MAC addresses maintain
those addresses correctly before and after restart operation.

Signed-off-by: Ram Lavi <ralavi@redhat.com>
Validates that KubeVirt VMs with preconfigured MAC and IP addresses
maintain those addresses correctly before and after live migration
operation.

Signed-off-by: Ram Lavi <ralavi@redhat.com>
@RamLavi RamLavi force-pushed the add_PreconfiguredUDNAddresses_FG_e2e branch from 62304a5 to 18f6d17 Compare August 8, 2025 10:49
@RamLavi
Copy link
Author

RamLavi commented Aug 8, 2025

Change: Add back the ipv6 ip

@RamLavi
Copy link
Author

RamLavi commented Aug 8, 2025

/testwith openshift/origin/main/e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview openshift/cluster-network-operator#2743 openshift/ovn-kubernetes#2666

@maiqueb
Copy link
Contributor

maiqueb commented Aug 8, 2025

Only the conflict detection related tests are failing in this job execution.

Let's try with the updated PR openshift/ovn-kubernetes#2666, which brings along the PR with IP conflict detection. Fingers crossed.

/testwith openshift/origin/main/e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview openshift/cluster-network-operator#2743 openshift/ovn-kubernetes#2666

Copy link

openshift-trt bot commented Aug 8, 2025

Job Failure Risk Analysis for sha: 18f6d17

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-single-node-upgrade IncompleteTests

Validates that KubeVirt VMs with preconfigured MAC and IP addresses
maintain those addresses correctly before and after a vmi with duplicate
IP/MAC request is made, and that the vmi with the duplicate address get
the appropriate address conflict error event.

Signed-off-by: Ram Lavi <ralavi@redhat.com>
@maiqueb maiqueb force-pushed the add_PreconfiguredUDNAddresses_FG_e2e branch from 18f6d17 to 64ee3a6 Compare August 11, 2025 10:47
@maiqueb
Copy link
Contributor

maiqueb commented Aug 11, 2025

/testwith openshift/origin/main/e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview openshift/cluster-network-operator#2743 openshift/ovn-kubernetes#2666

the IP conflict checks were configuring a single static IP in a dual stack cluster, something which (despite my personal thoughts on the matter) will not be allowed in a follow up production code changes to the OVN-K repo.

Copy link
Contributor

openshift-ci bot commented Aug 11, 2025

@RamLavi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview 8d6569e link false /test e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 be08098 link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-vsphere-ovn-etcd-scaling be08098 link false /test e2e-vsphere-ovn-etcd-scaling
ci/prow/e2e-gcp-fips-serial-2of2 be08098 link false /test e2e-gcp-fips-serial-2of2
ci/prow/e2e-aws-ovn-etcd-scaling be08098 link false /test e2e-aws-ovn-etcd-scaling
ci/prow/e2e-gcp-disruptive be08098 link false /test e2e-gcp-disruptive
ci/prow/e2e-gcp-ovn-etcd-scaling be08098 link false /test e2e-gcp-ovn-etcd-scaling
ci/prow/e2e-azure-ovn-etcd-scaling be08098 link false /test e2e-azure-ovn-etcd-scaling
ci/prow/e2e-openstack-serial be08098 link false /test e2e-openstack-serial
ci/prow/e2e-gcp-fips-serial-1of2 be08098 link false /test e2e-gcp-fips-serial-1of2
ci/prow/e2e-azure-ovn-upgrade be08098 link false /test e2e-azure-ovn-upgrade
ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout 64ee3a6 link false /test e2e-metal-ipi-ovn-kube-apiserver-rollout
ci/prow/e2e-metal-ipi-serial-ovn-ipv6-2of2 64ee3a6 link false /test e2e-metal-ipi-serial-ovn-ipv6-2of2
ci/prow/e2e-metal-ipi-ovn-dualstack 64ee3a6 link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-aws-disruptive 64ee3a6 link false /test e2e-aws-disruptive
ci/prow/e2e-gcp-ovn 64ee3a6 link true /test e2e-gcp-ovn
ci/prow/okd-scos-e2e-aws-ovn 64ee3a6 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-metal-ipi-serial-2of2 64ee3a6 link false /test e2e-metal-ipi-serial-2of2
ci/prow/e2e-vsphere-ovn 64ee3a6 link true /test e2e-vsphere-ovn
ci/prow/e2e-metal-ipi-ovn 64ee3a6 link false /test e2e-metal-ipi-ovn
ci/prow/e2e-aws-ovn-single-node-upgrade 64ee3a6 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-microshift 64ee3a6 link true /test e2e-aws-ovn-microshift
ci/prow/e2e-gcp-ovn-techpreview-serial-2of2 64ee3a6 link false /test e2e-gcp-ovn-techpreview-serial-2of2
ci/prow/e2e-gcp-csi 64ee3a6 link false /test e2e-gcp-csi
ci/prow/e2e-gcp-ovn-rt-upgrade 64ee3a6 link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-metal-ipi-ovn-ipv6 64ee3a6 link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-gcp-ovn-techpreview-serial-1of2 64ee3a6 link false /test e2e-gcp-ovn-techpreview-serial-1of2
ci/prow/e2e-aws-proxy 64ee3a6 link false /test e2e-aws-proxy
ci/prow/e2e-metal-ipi-virtualmedia 64ee3a6 link false /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-metal-ipi-ovn-dualstack-local-gateway 64ee3a6 link false /test e2e-metal-ipi-ovn-dualstack-local-gateway
ci/prow/e2e-gcp-ovn-techpreview 64ee3a6 link false /test e2e-gcp-ovn-techpreview
ci/prow/verify 64ee3a6 link true /test verify
ci/prow/e2e-gcp-ovn-upgrade 64ee3a6 link true /test e2e-gcp-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

openshift-trt bot commented Aug 11, 2025

Job Failure Risk Analysis for sha: 64ee3a6

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-gcp-ovn-upgrade IncompleteTests
Tests for this run (104) are below the historical average (1649): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants