Skip to content

NO-JIRA: Allow only including / excluding specific extension images #29980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2025

Conversation

stbenjam
Copy link
Member

When developing on my Mac, I point origin at locally-built binaries so I can run it directly locally. Now that we have many extension binaries, I would have to override each one to make it work as the payload-extracted images are all Linux executables. This adds environment variables for only specifically including or excluding particular image tags, making it easier to iterate on just one extension.

Also migrates docs to the docs folder.

@stbenjam stbenjam changed the title Allow only including / excluding specific extension images NO-JIRA: Allow only including / excluding specific extension images Jul 10, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 10, 2025
@openshift-ci-robot
Copy link

@stbenjam: This pull request explicitly references no jira issue.

In response to this:

When developing on my Mac, I point origin at locally-built binaries so I can run it directly locally. Now that we have many extension binaries, I would have to override each one to make it work as the payload-extracted images are all Linux executables. This adds environment variables for only specifically including or excluding particular image tags, making it easier to iterate on just one extension.

Also migrates docs to the docs folder.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from deads2k and p0lyn0mial July 10, 2025 11:00
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2025
@dgoodwin
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD bb3f979 and 2 for PR HEAD 454e5b4 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 48d56f2 and 2 for PR HEAD 454e5b4 in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 48d56f2 and 2 for PR HEAD 454e5b4 in total

Copy link

openshift-trt bot commented Jul 25, 2025

Job Failure Risk Analysis for sha: 454e5b4

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6 IncompleteTests
Tests for this run (102) are below the historical average (2923): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 48d56f2 and 2 for PR HEAD 454e5b4 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 5ef42f5 and 2 for PR HEAD 454e5b4 in total

2 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 5ef42f5 and 2 for PR HEAD 454e5b4 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 5ef42f5 and 2 for PR HEAD 454e5b4 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 82cfbea and 1 for PR HEAD 454e5b4 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 851e33d and 0 for PR HEAD 454e5b4 in total

@openshift-ci-robot
Copy link

/hold

Revision 454e5b4 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 30, 2025
@stbenjam
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 30, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 851e33d and 2 for PR HEAD 454e5b4 in total

@stbenjam
Copy link
Member Author

/skip

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 30, 2025
When developing on my Mac, I point origin at locally-built binaries so I
can run it directly locally.  Now that we have many extension binaries,
I would have to override each one to make it work as the
payload-extracted images are all Linux executables. This adds
environment variables for only specifically including or excluding
particular image tags, making it easier to iterate on just one
extension.

Also migrates docs to the `docs` folder.
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 1, 2025
Copy link
Contributor

openshift-ci bot commented Aug 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, neisw, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dgoodwin,neisw,stbenjam]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ee7b5a8 and 2 for PR HEAD 01212f3 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 85efd76 and 1 for PR HEAD 01212f3 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 8933dc6 and 0 for PR HEAD 01212f3 in total

@openshift-ci-robot
Copy link

/hold

Revision 01212f3 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 2, 2025
@stbenjam
Copy link
Member Author

stbenjam commented Aug 4, 2025

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b63b144 and 2 for PR HEAD 01212f3 in total

@stbenjam
Copy link
Member Author

stbenjam commented Aug 4, 2025

/skip

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 47c179d and 2 for PR HEAD 01212f3 in total

2 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 47c179d and 2 for PR HEAD 01212f3 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 47c179d and 2 for PR HEAD 01212f3 in total

@stbenjam
Copy link
Member Author

stbenjam commented Aug 5, 2025

/override ci/prow/e2e-aws-ovn-fips

Copy link
Contributor

openshift-ci bot commented Aug 5, 2025

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-aws-ovn-fips

In response to this:

/override ci/prow/e2e-aws-ovn-fips

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 98992d3 and 2 for PR HEAD 01212f3 in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 98992d3 and 2 for PR HEAD 01212f3 in total

Copy link

openshift-trt bot commented Aug 6, 2025

Job Failure Risk Analysis for sha: 01212f3

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-edge-zones Low
[sig-network] Services should be rejected for evicted pods (no endpoints exist) [Suite:openshift/conformance/parallel] [Suite:k8s]
This test has passed 0.00% of 1 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:standard Network:ovn NetworkStack:ipv4 Owner:eng Platform:aws Procedure:none SecurityMode:default Topology:ha Upgrade:none] in the last week.

Open Bugs
Component Readiness: [Networking / cluster-network-operator] [Other] [sig-network] Services should be rejected for evicted pods (no endpoints exist)
Component Readiness: [Networking / cluster-network-operator] [Other] [sig-network] Services should be rejected for evicted pods (no endpoints exist)
---
[sig-instrumentation] Metrics should grab all metrics from kubelet /metrics/resource endpoint [Suite:openshift/conformance/parallel] [Suite:k8s]
This test has passed 0.00% of 1 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:standard Network:ovn NetworkStack:ipv4 Owner:eng Platform:aws Procedure:none SecurityMode:default Topology:ha Upgrade:none] in the last week.

Open Bugs
Component Readiness: [Monitoring] [Other] test regressed

1 similar comment
Copy link

openshift-trt bot commented Aug 6, 2025

Job Failure Risk Analysis for sha: 01212f3

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-edge-zones Low
[sig-network] Services should be rejected for evicted pods (no endpoints exist) [Suite:openshift/conformance/parallel] [Suite:k8s]
This test has passed 0.00% of 1 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:standard Network:ovn NetworkStack:ipv4 Owner:eng Platform:aws Procedure:none SecurityMode:default Topology:ha Upgrade:none] in the last week.

Open Bugs
Component Readiness: [Networking / cluster-network-operator] [Other] [sig-network] Services should be rejected for evicted pods (no endpoints exist)
Component Readiness: [Networking / cluster-network-operator] [Other] [sig-network] Services should be rejected for evicted pods (no endpoints exist)
---
[sig-instrumentation] Metrics should grab all metrics from kubelet /metrics/resource endpoint [Suite:openshift/conformance/parallel] [Suite:k8s]
This test has passed 0.00% of 1 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:standard Network:ovn NetworkStack:ipv4 Owner:eng Platform:aws Procedure:none SecurityMode:default Topology:ha Upgrade:none] in the last week.

Open Bugs
Component Readiness: [Monitoring] [Other] test regressed

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c60cd38 and 1 for PR HEAD 01212f3 in total

Copy link
Contributor

openshift-ci bot commented Aug 6, 2025

@stbenjam: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-serial-publicnet-2of2 454e5b4 link false /test e2e-aws-ovn-serial-publicnet-2of2
ci/prow/e2e-aws-ovn-serial-publicnet-1of2 454e5b4 link false /test e2e-aws-ovn-serial-publicnet-1of2
ci/prow/e2e-gcp-fips-serial-2of2 454e5b4 link false /test e2e-gcp-fips-serial-2of2
ci/prow/e2e-aws-ovn-etcd-scaling 454e5b4 link false /test e2e-aws-ovn-etcd-scaling
ci/prow/e2e-azure-ovn-etcd-scaling 454e5b4 link false /test e2e-azure-ovn-etcd-scaling
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 454e5b4 link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-openstack-serial 454e5b4 link false /test e2e-openstack-serial
ci/prow/e2e-vsphere-ovn-etcd-scaling 454e5b4 link false /test e2e-vsphere-ovn-etcd-scaling
ci/prow/okd-e2e-gcp 454e5b4 link false /test okd-e2e-gcp
ci/prow/e2e-gcp-ovn-etcd-scaling 454e5b4 link false /test e2e-gcp-ovn-etcd-scaling
ci/prow/e2e-gcp-fips-serial-1of2 454e5b4 link false /test e2e-gcp-fips-serial-1of2
ci/prow/e2e-gcp-disruptive 454e5b4 link false /test e2e-gcp-disruptive
ci/prow/e2e-azure 01212f3 link false /test e2e-azure
ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout 01212f3 link false /test e2e-metal-ipi-ovn-kube-apiserver-rollout
ci/prow/e2e-metal-ipi-ovn 01212f3 link false /test e2e-metal-ipi-ovn
ci/prow/e2e-aws-disruptive 01212f3 link false /test e2e-aws-disruptive
ci/prow/okd-scos-e2e-aws-ovn 01212f3 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-openstack-ovn 01212f3 link false /test e2e-openstack-ovn
ci/prow/e2e-metal-ipi-ovn-dualstack 01212f3 link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-metal-ipi-serial-2of2 01212f3 link false /test e2e-metal-ipi-serial-2of2
ci/prow/e2e-aws-proxy 01212f3 link false /test e2e-aws-proxy
ci/prow/e2e-aws-ovn-single-node-upgrade 01212f3 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-kube-apiserver-rollout 01212f3 link false /test e2e-aws-ovn-kube-apiserver-rollout
ci/prow/e2e-metal-ipi-ovn-dualstack-local-gateway 01212f3 link false /test e2e-metal-ipi-ovn-dualstack-local-gateway
ci/prow/e2e-metal-ipi-serial-ovn-ipv6-2of2 01212f3 link false /test e2e-metal-ipi-serial-ovn-ipv6-2of2
ci/prow/e2e-agnostic-ovn-cmd 01212f3 link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-gcp-ovn-techpreview-serial-2of2 01212f3 link false /test e2e-gcp-ovn-techpreview-serial-2of2
ci/prow/e2e-gcp-ovn-techpreview 01212f3 link false /test e2e-gcp-ovn-techpreview
ci/prow/e2e-aws-ovn-single-node 01212f3 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-metal-ipi-serial-ovn-ipv6-1of2 01212f3 link false /test e2e-metal-ipi-serial-ovn-ipv6-1of2
ci/prow/e2e-aws-ovn-single-node-serial 01212f3 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-metal-ipi-virtualmedia 01212f3 link false /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-metal-ipi-serial-1of2 01212f3 link false /test e2e-metal-ipi-serial-1of2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

openshift-trt bot commented Aug 6, 2025

Job Failure Risk Analysis for sha: 01212f3

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-edge-zones Medium
[sig-node] Pods Extended Pod Container lifecycle evicted pods should be terminal [Suite:openshift/conformance/parallel] [Suite:k8s]
This test has passed 95.25% of 2064 runs on release 4.20 [Overall] in the last week.

Open Bugs
Evicted pods should be terminal test flakes too often

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c60cd38 and 2 for PR HEAD 01212f3 in total

@stbenjam
Copy link
Member Author

stbenjam commented Aug 6, 2025

/override ci/prow/e2e-aws-ovn-edge-zones

Copy link
Contributor

openshift-ci bot commented Aug 6, 2025

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-aws-ovn-edge-zones

In response to this:

/override ci/prow/e2e-aws-ovn-edge-zones

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stbenjam
Copy link
Member Author

stbenjam commented Aug 6, 2025

/override ci/prow/e2e-aws-ovn-edge-zones
/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/e2e-aws-ovn-microshift
/override ci/prow/e2e-aws-ovn-microshift-serial
/override ci/prow/e2e-aws-ovn-serial-1of2
/override ci/prow/e2e-aws-ovn-serial-2of2
/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-gcp-ovn-upgrade
/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-vsphere-ovn
/override ci/prow/e2e-vsphere-ovn-upi

Stuck in Tide re-test loops but code has been validated as working many times.

@stbenjam
Copy link
Member Author

stbenjam commented Aug 6, 2025

/skip

Copy link
Contributor

openshift-ci bot commented Aug 6, 2025

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-aws-ovn-edge-zones, ci/prow/e2e-aws-ovn-fips, ci/prow/e2e-aws-ovn-microshift, ci/prow/e2e-aws-ovn-microshift-serial, ci/prow/e2e-aws-ovn-serial-1of2, ci/prow/e2e-aws-ovn-serial-2of2, ci/prow/e2e-gcp-ovn, ci/prow/e2e-gcp-ovn-upgrade, ci/prow/e2e-metal-ipi-ovn-ipv6, ci/prow/e2e-vsphere-ovn, ci/prow/e2e-vsphere-ovn-upi

In response to this:

/override ci/prow/e2e-aws-ovn-edge-zones
/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/e2e-aws-ovn-microshift
/override ci/prow/e2e-aws-ovn-microshift-serial
/override ci/prow/e2e-aws-ovn-serial-1of2
/override ci/prow/e2e-aws-ovn-serial-2of2
/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-gcp-ovn-upgrade
/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-vsphere-ovn
/override ci/prow/e2e-vsphere-ovn-upi

Stuck in Tide re-test loops but code has been validated as working many times.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 05eeb94 into openshift:main Aug 6, 2025
47 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests
This PR has been included in build openshift-enterprise-tests-container-v4.20.0-202508062319.p0.g05eeb94.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants