Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "NO-JIRA: use quay.io/openshift/origin-cli:latest directly" #29543

Merged

Conversation

jupierce
Copy link
Contributor

The DNF wrapper should no longer fail when it is not connected to the VPN after openshift-eng/ocp-build-data#6019

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 15, 2025
@openshift-ci-robot
Copy link

@jupierce: This pull request explicitly references no jira issue.

In response to this:

The DNF wrapper should no longer fail when it is not connected to the VPN after openshift-eng/ocp-build-data#6019

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from deads2k and sjenning February 15, 2025 14:12
@sdodson
Copy link
Member

sdodson commented Feb 15, 2025

/lgtm
/Approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2025
Copy link
Contributor

openshift-ci bot commented Feb 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jupierce, sdodson
Once this PR has been reviewed and has the lgtm label, please assign bertinatto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdodson
Copy link
Member

sdodson commented Feb 15, 2025

/label approved

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2025
@sdodson
Copy link
Member

sdodson commented Feb 15, 2025

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Feb 15, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 097dfb1 and 2 for PR HEAD 2c270e6 in total

@joepvd
Copy link
Contributor

joepvd commented Feb 15, 2025

/retest-required

1 similar comment
@joepvd
Copy link
Contributor

joepvd commented Feb 16, 2025

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 097dfb1 and 2 for PR HEAD 2c270e6 in total

Copy link

openshift-trt bot commented Feb 17, 2025

Job Failure Risk Analysis for sha: 2c270e6

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-gcp-ovn-upgrade IncompleteTests
Tests for this run (2) are below the historical average (1775): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-gcp-ovn IncompleteTests
Tests for this run (2) are below the historical average (2912): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@jupierce
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 097dfb1 and 2 for PR HEAD 2c270e6 in total

Copy link
Contributor

openshift-ci bot commented Feb 18, 2025

@jupierce: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit ff988fb into master Feb 18, 2025
31 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests
This PR has been included in build openshift-enterprise-tests-container-v4.19.0-202502180538.p0.gff988fb.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants