Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.18] OCPBUGS-48389: only provision workloads when network creation has started #29413

Open
wants to merge 6 commits into
base: release-4.18
Choose a base branch
from
Open

[release-4.18] OCPBUGS-48389: only provision workloads when network creation has started #29413

wants to merge 6 commits into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #29348

/assign jluhrsen

maiqueb added 6 commits January 9, 2025 02:58
@maiqueb
virt: remove redundant parenthesis
7796e94 
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
@maiqueb
virt: assert network is ready in each node before starting workloads
126d575 
Otherwise, we risk facing a situation where the primary UDN will not be
plumbed into the worlkload.

Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
@maiqueb
virt, persistent ips: print out the HTTP server pod IPs
72ad54a 
This way, we can better debug when things go wrong.

Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
@maiqueb
virt, persistent ips: figure out provisioned network name
5fbeeec 
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
@maiqueb
ovn-k: extract ovnkubePodInfo per node to a func
3a54873 
This way, we can re-use this logic in other places without duplicating
code

Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
@maiqueb
virt, udn: add a primary UDN smoke test that ensures the UDN/workload…
88eadb5 
… race is avoided

Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 9, 2025
Merged
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 9, 2025 •
edited by openshift-ci bot
Loading

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: SDN-5568

In response to this:

This is an automated cherry-pick of #29348

/assign jluhrsen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from deads2k and jparrill January 9, 2025 02:59
maiqueb
maiqueb approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@maiqueb maiqueb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2025
@maiqueb
Copy link
Contributor

maiqueb commented Jan 14, 2025

/retitle [release-4.18] OCPBUGS-48389: only provision workloads when network creation has started

@openshift-ci openshift-ci bot changed the title [release-4.18] SDN-5568: only provision workloads when network creation has started [release-4.18] OCPBUGS-48389: only provision workloads when network creation has started Jan 14, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 14, 2025
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-48389, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-48391 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-48391 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
  • bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #29348

/assign jluhrsen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jan 14, 2025
@maiqueb
Copy link
Contributor

maiqueb commented Jan 14, 2025

@stbenjam could you please set the backport-risk-assessed label on this PR ?

@knobunc
Copy link
Contributor

knobunc commented Jan 16, 2025

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 16, 2025
@anuragthehatter
Copy link

/label cherry-pick-approved

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 16, 2025

@anuragthehatter: Can not set label cherry-pick-approved: Must be member in one of these teams: [openshift-staff-engineers]

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knobunc
Copy link
Contributor

knobunc commented Jan 21, 2025

/approve

@knobunc
Copy link
Contributor

knobunc commented Jan 21, 2025

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 21, 2025
@maiqueb
Copy link
Contributor

maiqueb commented Jan 21, 2025

@dgoodwin could you please approve ? :)

@dgoodwin
Copy link
Contributor

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, knobunc, maiqueb, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1187d3a and 2 for PR HEAD 88eadb5 in total

@openshift-ci-robot openshift-ci-robot mentioned this pull request Jan 21, 2025
Merged
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2774b2b and 2 for PR HEAD 88eadb5 in total

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 22, 2025
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 22, 2025

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade 88eadb5 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-kube-apiserver-rollout 88eadb5 link false /test e2e-aws-ovn-kube-apiserver-rollout
ci/prow/e2e-aws-ovn-single-node 88eadb5 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-gcp-csi 88eadb5 link false /test e2e-gcp-csi
ci/prow/e2e-aws-ovn-fips 88eadb5 link unknown /test e2e-aws-ovn-fips
ci/prow/e2e-aws-ovn-serial 88eadb5 link unknown /test e2e-aws-ovn-serial
ci/prow/e2e-aws-ovn-edge-zones 88eadb5 link unknown /test e2e-aws-ovn-edge-zones
ci/prow/unit 88eadb5 link unknown /test unit
ci/prow/e2e-metal-ipi-ovn-ipv6 88eadb5 link unknown /test e2e-metal-ipi-ovn-ipv6
ci/prow/verify 88eadb5 link unknown /test verify
ci/prow/e2e-aws-ovn-microshift-serial 88eadb5 link unknown /test e2e-aws-ovn-microshift-serial
ci/prow/e2e-gcp-ovn-upgrade 88eadb5 link unknown /test e2e-gcp-ovn-upgrade
ci/prow/e2e-aws-ovn-microshift 88eadb5 link unknown /test e2e-aws-ovn-microshift
ci/prow/lint 88eadb5 link unknown /test lint
ci/prow/okd-scos-images 88eadb5 link unknown /test okd-scos-images
ci/prow/e2e-gcp-ovn 88eadb5 link unknown /test e2e-gcp-ovn
ci/prow/images 88eadb5 link unknown /test images
ci/prow/verify-deps 88eadb5 link unknown /test verify-deps

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Jan 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maiqueb maiqueb maiqueb approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@jparrill jparrill Awaiting requested review from jparrill

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

Assignees

@dgoodwin dgoodwin

@adambkaplan adambkaplan

@jluhrsen jluhrsen

@kasturinarra kasturinarra

@Moebasim Moebasim

@jadhaj jadhaj

@maiqueb maiqueb

@pamoedom pamoedom

@gangwgr gangwgr

@prabhapa prabhapa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.