Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPRUN-3606: Add diagnostics to olmv1 tests #29316

Merged
merged 1 commit into from
Nov 22, 2024
Merged

OPRUN-3606: Add diagnostics to olmv1 tests #29316

merged 1 commit into from
Nov 22, 2024

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Nov 21, 2024

  • Add diagnostics to figure out what happened when context timeout occurs
  • Remove [Serial] requirements, the install tests can now happen in parallel

@openshift-ci openshift-ci bot requested review from grokspawn and hasbro17 November 21, 2024 18:32
everettraven
everettraven reviewed Nov 21, 2024
View reviewed changes
test/extended/olm/olmv1.go Outdated Show resolved Hide resolved
test/extended/olm/olmv1.go Outdated Show resolved Hide resolved
test/extended/olm/olmv1.go Outdated Show resolved Hide resolved
@tmshort
Add diagnostics to olmv1 tests
6c3e7ea 
* Add diagnostics to figure out what happened when context timeout occurs
* Remove [Serial] requirements, the install tests can now happen in parallel

Signed-off-by: Todd Short <todd.short@me.com>
@tmshort tmshort changed the title Add diagnostics to olmv1 tests NO-ISSUE: Add diagnostics to olmv1 tests Nov 22, 2024
@openshift-ci-robot
Copy link

@tmshort: This pull request explicitly references no jira issue.

In response to this:

  • Add diagnostics to figure out what happened when context timeout occurs
  • Remove [Serial] requirements, the install tests can now happen in parallel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 22, 2024
everettraven
everettraven approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2024
@dgoodwin
Copy link
Contributor

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, everettraven, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2024
@LalatenduMohanty
Copy link
Member

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Nov 22, 2024
@grokspawn
Copy link

grokspawn commented Nov 22, 2024 •
edited by openshift-ci bot
Loading

/retitle OPRUN-3606: Add diagnostics to olmv1 tests

@openshift-ci openshift-ci bot changed the title NO-ISSUE: Add diagnostics to olmv1 tests OPRUN-3606: Add diagnostics to olmv1 tests Nov 22, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 22, 2024 •
edited by openshift-ci bot
Loading

@tmshort: This pull request references OPRUN-3606 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

  • Add diagnostics to figure out what happened when context timeout occurs
  • Remove [Serial] requirements, the install tests can now happen in parallel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 22, 2024

@tmshort: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade 6c3e7ea link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-single-node-serial 6c3e7ea link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout 6c3e7ea link false /test e2e-metal-ipi-ovn-kube-apiserver-rollout
ci/prow/e2e-gcp-ovn-rt-upgrade 6c3e7ea link false /test e2e-gcp-ovn-rt-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit f65121e into openshift:master Nov 22, 2024
24 of 28 checks passed
@tmshort tmshort deleted the additional-logging branch November 22, 2024 21:26
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests
This PR has been included in build openshift-enterprise-tests-container-v4.18.0-202411222306.p0.gf65121e.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@everettraven everettraven everettraven approved these changes

@grokspawn grokspawn Awaiting requested review from grokspawn

@hasbro17 hasbro17 Awaiting requested review from hasbro17

Assignees

@everettraven everettraven

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tmshort @openshift-ci-robot @dgoodwin @LalatenduMohanty @grokspawn @openshift-bot @everettraven