OCPBUGS-42618: Replace RunHostCmd with Exec function to censor bearer token being ex… #29176
Conversation
Shilpa-Gokul
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@Shilpa-Gokul: This pull request references Jira Issue OCPBUGS-42618, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/payload-job periodic-ci-openshift-multiarch-master-nightly-4.17-ocp-e2e-ovn-remote-libvirt-ppc64le |
|
@Shilpa-Gokul: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4c62cca0-86e9-11ef-8776-9b0b0a8473a1-0 |
|
/lgtm |
|
/payload-job periodic-ci-openshift-multiarch-master-nightly-4.17-ocp-e2e-ovn-remote-libvirt-ppc64le |
|
@Shilpa-Gokul: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/98746b80-8798-11ef-9280-4f3665830d61-0 |
|
/payload-job periodic-ci-openshift-multiarch-master-nightly-4.17-ocp-e2e-ovn-remote-libvirt-ppc64le |
|
@Shilpa-Gokul: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b3caf260-87bf-11ef-88bd-22b7b001175f-0 |
|
/payload-job periodic-ci-openshift-multiarch-master-nightly-4.17-ocp-e2e-ovn-remote-libvirt-ppc64le |
|
@Shilpa-Gokul: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c5a5d310-87c9-11ef-9995-4d9c6ebc2f1a-0 |
|
/payload-job periodic-ci-openshift-multiarch-master-nightly-4.17-ocp-e2e-ovn-remote-libvirt-ppc64le |
|
@Shilpa-Gokul: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3d315c90-8aba-11ef-94b7-bb30450ae71b-0 |
|
/payload-job periodic-ci-openshift-multiarch-master-nightly-4.17-ocp-e2e-ovn-remote-libvirt-ppc64le |
|
@Shilpa-Gokul: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7fa4ac50-8aef-11ef-814a-6b867f01fde7-0 |
|
/payload-job periodic-ci-openshift-multiarch-master-nightly-4.18-ocp-e2e-ovn-remote-libvirt-ppc64le |
|
@Shilpa-Gokul: An error was encountered. No known errors were detected, please see the full error message for details. Full error message.
could not create PullRequestPayloadQualificationRun: client rate limiter Wait returned an error: context canceled
Please contact an administrator to resolve this issue. |
|
/payload-job periodic-ci-openshift-multiarch-master-nightly-4.17-ocp-e2e-ovn-remote-libvirt-ppc64le |
|
@Shilpa-Gokul: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d7d60bf0-8b92-11ef-8433-3c241ccd8260-0 |
|
/payload-job periodic-ci-openshift-multiarch-master-nightly-4.16-ocp-e2e-ovn-remote-libvirt-ppc64le |
|
@Shilpa-Gokul: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/89e74130-8baa-11ef-9fcc-ef3b641fe46e-0 |
|
/payload-job periodic-ci-openshift-multiarch-master-nightly-4.18-ocp-e2e-ovn-remote-libvirt-ppc64le |
|
@Shilpa-Gokul: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/91de2250-8baa-11ef-811f-f52c13701662-0 |
Shilpa-Gokul
force-pushed
the
censor_token
branch
from
14b5e3c to
4783356
Compare
|
@candita I have made all the changes as per your comments, could you please take a look now? |
|
Job Failure Risk Analysis for sha: 4783356
|
|
Job Failure Risk Analysis for sha: 4783356
|
|
/retest-required |
|
/retest required |
|
@candita: The The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest-required |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: candita, neisw, Shilpa-Gokul, tvardema The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Job Failure Risk Analysis for sha: 4783356
|
|
Job Failure Risk Analysis for sha: 4783356
|
|
I noticed some microshift install failures in required tests, not related to this PR. |
|
Job Failure Risk Analysis for sha: 4783356
|
|
/retest-required |
|
/test okd-scos-e2e-aws-ovn |
|
Job Failure Risk Analysis for sha: 4783356
|
|
@Shilpa-Gokul: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit d97e9ab
into
openshift:master
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-tests |
|
/cherry-pick release-4.18 |
|
@Shilpa-Gokul: new pull request created: #29377 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/jira cherrypick OCPBUGS-42618 |
RunHostCmd function from getBearerTokenURLViaPod function was invoking the kubectl exec to execute a command from within a pod which eventually led to printing this line containing the bearer token. As a result the CI logs was removed as it contained sensitive information exposure.
Since it was difficult to make the changes upstream to avoid printing the token, replaced the RunHostCmd function with the oc exec command and redacted the token thats printed.
Redacted output will be as shown below
I1209 01:20:21.410430 3464561 client.go:936] Running 'oc --namespace=e2e-test-router-metrics-n8qsz --kubeconfig=/home/shilpa/libvirt-config/upi-install/upi/auth/kubeconfig exec execpod -- curl -s -k -H Authorization: Bearer <redacted>https://prometheus-k8s.openshift-monitoring.svc:9091/api/v1/targets?state=active'