Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-42435: Enforce the required-scc monitor test and validate usage of non-standard OCP SCCs #29135

Merged
merged 2 commits into from
Nov 23, 2024
Merged

OCPBUGS-42435: Enforce the required-scc monitor test and validate usage of non-standard OCP SCCs #29135

merged 2 commits into from
Nov 23, 2024

Conversation

kramaranya
Copy link
Contributor

@kramaranya kramaranya commented Sep 26, 2024 •
edited
Loading

Enforced required-scc monitor test for fixed namespaces. Extended the required-scc monitor test to validate non-standard SCCs and ensure they are only used in allowed namespaces.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 26, 2024
@openshift-ci-robot
Copy link

@kramaranya: This pull request references Jira Issue OCPBUGS-42435, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 26, 2024
@kramaranya
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 26, 2024
@openshift-ci-robot
Copy link

@kramaranya: This pull request references Jira Issue OCPBUGS-42435, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@kramaranya: This pull request references Jira Issue OCPBUGS-42435, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

Extended the required-scc monitor test to validate non-standard SCCs and ensure they are only used in allowed namespaces. If a non-standard SCC is used in a disallowed namespace, the test will report a failure.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

liouk
liouk suggested changes Sep 26, 2024
View reviewed changes
Copy link
Member

@liouk liouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we have already pinned a non-standard SCC to a namespace that's not allowed?

pkg/monitortests/authentication/requiredsccmonitortests/monitortest.go Outdated Show resolved Hide resolved
pkg/monitortests/authentication/requiredsccmonitortests/monitortest.go Outdated Show resolved Hide resolved
@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: c4489d2

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-kube-apiserver-rollout IncompleteTests
Tests for this run (101) are below the historical average (1073): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-gcp-ovn-upgrade IncompleteTests
Tests for this run (103) are below the historical average (1484): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-gcp-ovn IncompleteTests
Tests for this run (102) are below the historical average (2514): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-gcp-csi IncompleteTests
Tests for this run (102) are below the historical average (1481): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@kramaranya
Copy link
Contributor Author

/retest

@kramaranya
Copy link
Contributor Author

/retest-required

@liouk
Copy link
Member

liouk commented Nov 13, 2024

/retest

@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 9618001

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node IncompleteTests
Tests for this run (25) are below the historical average (2825): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@kramaranya kramaranya changed the title OCPBUGS-42435: Validate usage of non-standard OCP SCCs via the required-scc monitor test OCPBUGS-42435: Enforce the required-scc monitor test and validate usage of non-standard OCP SCCs Nov 20, 2024
@openshift-ci-robot
Copy link

@kramaranya: This pull request references Jira Issue OCPBUGS-42435, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Enforced required-scc monitor test for fixed namespaces. Extended the required-scc monitor test to validate non-standard SCCs and ensure they are only used in allowed namespaces.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kramaranya
Copy link
Contributor Author

/retest-required

@openshift-trt openshift-trt
Copy link

openshift-trt bot commented Nov 21, 2024

Job Failure Risk Analysis for sha: 5bcbd93

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-kube-apiserver-rollout Medium
[sig-api-machinery] disruption/kube-api connection/reused should be available throughout the test
This test has passed 93.75% of 16 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-kube-apiserver-rollout' 'periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-kube-apiserver-rollout'] in the last 14 days.
---
[sig-api-machinery] disruption/oauth-api connection/reused should be available throughout the test
This test has passed 93.75% of 16 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-kube-apiserver-rollout' 'periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-kube-apiserver-rollout'] in the last 14 days.
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node Low
[sig-node] static pods should start after being created
This test has passed 67.61% of 71 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.19-e2e-aws-ovn-single-node' 'periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-single-node'] in the last 14 days.

@liouk
Copy link
Member

liouk commented Nov 21, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2024
@kramaranya
Copy link
Contributor Author

/retest

@kramaranya
Copy link
Contributor Author

/retest-required

1 similar comment
@kramaranya
Copy link
Contributor Author

/retest-required

@xueqzhan
Copy link
Contributor

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kramaranya, liouk, xueqzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2024
@kramaranya
Copy link
Contributor Author

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Nov 22, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e7a9cb1 and 2 for PR HEAD a31bc91 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 23, 2024

@kramaranya: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-ipsec-serial b2c9f6f link false /test e2e-aws-ovn-ipsec-serial
ci/prow/e2e-gcp-ovn-builds b2c9f6f link true /test e2e-gcp-ovn-builds
ci/prow/e2e-agnostic-ovn-cmd a31bc91 link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-aws-ovn-single-node-serial a31bc91 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-gcp-ovn-rt-upgrade a31bc91 link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout a31bc91 link false /test e2e-metal-ipi-ovn-kube-apiserver-rollout
ci/prow/e2e-metal-ipi-ovn a31bc91 link false /test e2e-metal-ipi-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 19cf936 into openshift:master Nov 23, 2024
22 of 28 checks passed
@openshift-ci-robot
Copy link

@kramaranya: Jira Issue OCPBUGS-42435: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-42435 has been moved to the MODIFIED state.

In response to this:

Enforced required-scc monitor test for fixed namespaces. Extended the required-scc monitor test to validate non-standard SCCs and ensure they are only used in allowed namespaces.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests
This PR has been included in build openshift-enterprise-tests-container-v4.19.0-202411230339.p0.g19cf936.assembly.stream.el9.
All builds following this will include this PR.

@neisw neisw mentioned this pull request Nov 24, 2024
Merged
@neisw
Copy link
Contributor

neisw commented Nov 24, 2024

/payload-job periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aws-ovn-conformance

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 24, 2024

@neisw: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aws-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/af313a60-aabb-11ef-89b5-5ddb94df616e-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liouk liouk liouk requested changes

@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@liouk liouk

@xueqzhan xueqzhan

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kramaranya @openshift-ci-robot @openshift-trt-bot @liouk @xueqzhan @openshift-bot @neisw