Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Improvements and fixes for Loki intervals uploader" #28268

Conversation

dgoodwin
Copy link
Contributor

Reverts #28053

Loki's having problems, They started 6-8 hours after this went in. Unclear if the use of json is suddenly pushing it too hard. Taking it out as an experiment.

@xueqzhan
Copy link
Contributor

/lgtm

@dgoodwin
Copy link
Contributor Author

/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/e2e-aws-ovn-serial
/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-gcp-ovn-upgrade

@dgoodwin
Copy link
Contributor Author

/override ci/prow/e2e-agnostic-ovn-cmd
/override ci/prow/e2e-aws-csi
/override ci/prow/e2e-aws-ovn-cgroupsv2
/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/e2e-aws-ovn-serial
/override ci/prow/e2e-aws-ovn-single-node
/override ci/prow/e2e-aws-ovn-single-node-serial
/override ci/prow/e2e-aws-ovn-single-node-upgrade
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-gcp-csi
/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-gcp-ovn-rt-upgrade
/override ci/prow/e2e-gcp-ovn-upgrade
/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-metal-ipi-sdn
/override ci/prow/e2e-openstack-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2023

@dgoodwin: Overrode contexts on behalf of dgoodwin: ci/prow/e2e-aws-ovn-fips, ci/prow/e2e-aws-ovn-serial, ci/prow/e2e-gcp-ovn, ci/prow/e2e-gcp-ovn-upgrade

In response to this:

/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/e2e-aws-ovn-serial
/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-gcp-ovn-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, xueqzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2023

@dgoodwin: Overrode contexts on behalf of dgoodwin: ci/prow/e2e-agnostic-ovn-cmd, ci/prow/e2e-aws-csi, ci/prow/e2e-aws-ovn-cgroupsv2, ci/prow/e2e-aws-ovn-fips, ci/prow/e2e-aws-ovn-serial, ci/prow/e2e-aws-ovn-single-node, ci/prow/e2e-aws-ovn-single-node-serial, ci/prow/e2e-aws-ovn-single-node-upgrade, ci/prow/e2e-aws-ovn-upgrade, ci/prow/e2e-gcp-csi, ci/prow/e2e-gcp-ovn, ci/prow/e2e-gcp-ovn-rt-upgrade, ci/prow/e2e-gcp-ovn-upgrade, ci/prow/e2e-metal-ipi-ovn-ipv6, ci/prow/e2e-metal-ipi-sdn, ci/prow/e2e-openstack-ovn

In response to this:

/override ci/prow/e2e-agnostic-ovn-cmd
/override ci/prow/e2e-aws-csi
/override ci/prow/e2e-aws-ovn-cgroupsv2
/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/e2e-aws-ovn-serial
/override ci/prow/e2e-aws-ovn-single-node
/override ci/prow/e2e-aws-ovn-single-node-serial
/override ci/prow/e2e-aws-ovn-single-node-upgrade
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-gcp-csi
/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-gcp-ovn-rt-upgrade
/override ci/prow/e2e-gcp-ovn-upgrade
/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-metal-ipi-sdn
/override ci/prow/e2e-openstack-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ffd16ac and 2 for PR HEAD a6e8d7f in total

@dgoodwin
Copy link
Contributor Author

/override ci/prow/e2e-agnostic-ovn-cmd
/override ci/prow/e2e-aws-csi
/override ci/prow/e2e-aws-ovn-cgroupsv2
/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/e2e-aws-ovn-serial
/override ci/prow/e2e-aws-ovn-single-node
/override ci/prow/e2e-aws-ovn-single-node-serial
/override ci/prow/e2e-aws-ovn-single-node-upgrade
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-gcp-csi
/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-gcp-ovn-rt-upgrade
/override ci/prow/e2e-gcp-ovn-upgrade
/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-metal-ipi-sdn
/override ci/prow/e2e-openstack-ovn

@openshift-merge-robot openshift-merge-robot merged commit 90bcab0 into openshift:master Sep 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2023

@dgoodwin: Overrode contexts on behalf of dgoodwin: ci/prow/e2e-agnostic-ovn-cmd, ci/prow/e2e-aws-csi, ci/prow/e2e-aws-ovn-cgroupsv2, ci/prow/e2e-aws-ovn-fips, ci/prow/e2e-aws-ovn-serial, ci/prow/e2e-aws-ovn-single-node, ci/prow/e2e-aws-ovn-single-node-serial, ci/prow/e2e-aws-ovn-single-node-upgrade, ci/prow/e2e-aws-ovn-upgrade, ci/prow/e2e-gcp-csi, ci/prow/e2e-gcp-ovn, ci/prow/e2e-gcp-ovn-rt-upgrade, ci/prow/e2e-gcp-ovn-upgrade, ci/prow/e2e-metal-ipi-ovn-ipv6, ci/prow/e2e-metal-ipi-sdn, ci/prow/e2e-openstack-ovn

In response to this:

/override ci/prow/e2e-agnostic-ovn-cmd
/override ci/prow/e2e-aws-csi
/override ci/prow/e2e-aws-ovn-cgroupsv2
/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/e2e-aws-ovn-serial
/override ci/prow/e2e-aws-ovn-single-node
/override ci/prow/e2e-aws-ovn-single-node-serial
/override ci/prow/e2e-aws-ovn-single-node-upgrade
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-gcp-csi
/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-gcp-ovn-rt-upgrade
/override ci/prow/e2e-gcp-ovn-upgrade
/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-metal-ipi-sdn
/override ci/prow/e2e-openstack-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2023

@dgoodwin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dgoodwin dgoodwin deleted the revert-28053-loki-interval-upload branch October 20, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants