add pod log streaming to monitor for etcd so we see all intervals #28243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
|
Job Failure Risk Analysis for sha: f44ee81
|
deads2k
force-pushed
the
invariant-63-stream-logs
branch
from
4648b43 to
f086693
Compare
hasbro17
reviewed
Sep 7, 2023
| c.watchers = map[podKey]*watcher{} | ||
| } | ||
|
|
||
| // Run starts the controller and blocks until stopCh is closed. |
There was a problem hiding this comment.
Nit: I realize this is probably boilerplate but stopCh here refers to ctx>Done() right? Thought it was finishedCleanup but that's just the signal for a clean shutdown I think.
Comment on lines
+226
to
+227
| // TODO set a timeout? | ||
| c.removeAllWatchers(context.TODO()) |
There was a problem hiding this comment.
10 seconds? Should be enough for all the pods in the etcd namespace?
ctx, cancel := context.WithTimeout(ctx, time.Duration(time.Second*10))
defer cancel()
c.removeAllWatchers(ctx)
Although the cluster is going away so it may not matter if we don't finish cleanup.
hasbro17
reviewed
Sep 10, 2023
|
|
||
| var ( | ||
| // "raft.node: 38360899e3c7337e elected leader d8a2c1adbed17efe at term 6" | ||
| electedLeaderRegex = regexp.MustCompile("elected leader (?P<CURR_LEADER>[a-z0-9.-]+) at term (?P<TERM>[0-9]+)") |
There was a problem hiding this comment.
TIL named capture groups.
hasbro17
approved these changes
Sep 10, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, hasbro17 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Job Failure Risk Analysis for sha: f086693
|
deads2k
force-pushed
the
invariant-63-stream-logs
branch
from
f086693 to
da60f02
Compare
|
New changes are detected. LGTM label has been removed. |
|
simple rebase, reapplying lgtm |
|
/retest-required |
|
@deads2k: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Job Failure Risk Analysis for sha: da60f02
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ought to handle