Skip to content

Conversation

@damemi
Copy link
Contributor

@damemi damemi commented Dec 17, 2021

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 17, 2021
@openshift-ci openshift-ci bot requested review from deads2k and sjenning December 17, 2021 15:21
@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Dec 17, 2021
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 18, 2021
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 20, 2021
@damemi damemi force-pushed the rebase-1.23 branch 2 times, most recently from d8dd022 to caa97ba Compare December 20, 2021 20:48
@damemi damemi changed the title [wip] Rebase 1.23.0 [wip] Bug 2033751: Rebase 1.23.0 Dec 20, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 20, 2021

@damemi: An error was encountered querying GitHub for users with public email (kewang@redhat.com) for bug 2033751 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: i/o timeout

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

[wip] Bug 2033751: Rebase 1.23.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the e2e-images-update Related to images used by e2e tests label Dec 20, 2021
@damemi
Copy link
Contributor Author

damemi commented Dec 21, 2021

/retest

@damemi damemi changed the title [wip] Bug 2033751: Rebase 1.23.0 Bug 2033751: Rebase 1.23.0 Jan 12, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 12, 2022
@deads2k
Copy link
Contributor

deads2k commented Jan 12, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi, deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 13, 2022
@jsafrane
Copy link
Contributor

/test e2e-gcp-csi
/test e2e-aws-csi

Trying with new CI images.

@vrutkovs
Copy link
Contributor

Rebase has landed, lets see if this brings new kapi/kubelet
/retest

@vrutkovs
Copy link
Contributor

kube-apiserver is now 1.23 (kubelet is still 1.22.1 from 6859754). All test failures in e2e-gcp are timeouts

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 13, 2022
@jsafrane
Copy link
Contributor

Lot of the timeouts of storage tests are caused by an Ephemeral container not getting started.

STEP: Repeating the test on an ephemeral container (if enabled)
...
fail [k8s.io/kubernetes@v1.23.0/test/e2e/framework/pods.go:173]: Unexpected error:
    <*errors.errorString | 0xc00033ec30>: {
        s: "timed out waiting for the condition",
    }
    timed out waiting for the condition
occurred

Test code: https://github.com/kubernetes/kubernetes/blob/0669da445fa8c1ae07c15c0827f0e83da11cbe58/test/e2e/framework/volume/fixtures.go#L605

Do we have Ephemeral containers enabled?

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@jsafrane
Copy link
Contributor

I can see that EphemeralContainers were enabled as beta in 1.23, so we may have API server + KCM that has the feature enabled and kubelet that has it disabled -> test failure.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@vrutkovs
Copy link
Contributor

/hold

let it pick up a new nightly for kubelet update

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 13, 2022
@deads2k
Copy link
Contributor

deads2k commented Jan 13, 2022

force accepted a payload

/test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 13, 2022

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2022
@vrutkovs
Copy link
Contributor

/hold cancel
/retest

kubelet 1.23 was picked up

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2022
@vrutkovs
Copy link
Contributor

CSI tests fail due to missing busybox image

Back-off pulling image "quay.io/openshift/community-e2e-images:e2e-k8s-gcr-io-e2e-test-images-busybox-1-29-1-4vRlLJlMSKkJ4csR"

We only list 1.29-2:

./test/extended/util/image/image.go
67:		"k8s.gcr.io/e2e-test-images/busybox:1.29-2": 7,

./test/extended/util/image/zz_generated.txt
8:k8s.gcr.io/e2e-test-images/busybox:1.29-2 quay.io/openshift/community-e2e-images:e2e-7-k8s-gcr-io-e2e-test-images-busybox-1-29-2-cqcP1Tnbm-JjJyUA

@soltysh
Copy link
Contributor

soltysh commented Jan 14, 2022

CSI tests fail due to missing busybox image

mirrored

/test e2e-gcp
/test e2e-aws-fips
/test e2e-gcp-upgrade

"k8s.gcr.io/sig-storage/snapshot-controller:v3.0.2": -1,
"k8s.gcr.io/sig-storage/snapshot-controller:v4.0.0": -1,

"k8s.gcr.io/e2e-test-images/busybox:1.29-1": -1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be easier to maintain if it were a few lines down with busybox:1.29-2

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nah, I prefer to have it next to sig-storage elements, b/c they are handled differently than that other busybox image, it's complicated 😓

@vrutkovs
Copy link
Contributor

Retesting to include #26745 for better error message

@vrutkovs
Copy link
Contributor

/retest

1 similar comment
@vrutkovs
Copy link
Contributor

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 15, 2022

@damemi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-fips dfc3923 link true /test e2e-aws-fips
ci/prow/e2e-gcp dfc3923 link true /test e2e-gcp
ci/prow/e2e-aws-cgroupsv2 dfc3923 link false /test e2e-aws-cgroupsv2
ci/prow/e2e-aws-csi dfc3923 link false /test e2e-aws-csi
ci/prow/e2e-gcp-csi dfc3923 link false /test e2e-gcp-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@soltysh
Copy link
Contributor

soltysh commented Jan 17, 2022

Replaced with #26753
/close

@openshift-ci openshift-ci bot closed this Jan 17, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 17, 2022

@soltysh: Closed this PR.

In response to this:

Replaced with #26753
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 17, 2022

@damemi: This pull request references Bugzilla bug 2033751. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

Bug 2033751: Rebase 1.23.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. e2e-images-update Related to images used by e2e tests vendor-update Touching vendor dir or related files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants