Skip to content

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Aug 13, 2020

OLM team tried to remove these in openshift/openshift-tests#67

This functionality is simply gone: operator-framework/operator-marketplace#323

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2020
@mfojtik
Copy link
Contributor

mfojtik commented Aug 13, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2020
@mfojtik
Copy link
Contributor

mfojtik commented Aug 13, 2020

This is unblocking 4.6 promotion jobs and merge queue, button merging approved.

@mfojtik mfojtik added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Aug 13, 2020
@kevinrizza
Copy link
Member

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, kevinrizza, mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k
Copy link
Contributor Author

deads2k commented Aug 13, 2020

verify passes, images pass. So it builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants