Skip to content

UPSTREAM: 89055: Remove wait.Until for running Kubelet Bootstrap #24686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Mar 16, 2020
Merged

UPSTREAM: 89055: Remove wait.Until for running Kubelet Bootstrap #24686

openshift-merge-robot merged 1 commit into from
Mar 16, 2020

Conversation

@tedyu
Copy link

@tedyu tedyu commented Mar 13, 2020

As @liggitt outlined in #88779 (comment) , there are two options in preventing multiple parallel Run goroutines.

This PR adopts option #1.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 13, 2020
@openshift-ci-robot openshift-ci-robot added the vendor-update Touching vendor dir or related files label Mar 13, 2020
@rphillips
Copy link
Contributor

rphillips commented Mar 13, 2020

holding for upstream merge

/lgtm
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2020
@sjenning
Copy link
Contributor

sjenning commented Mar 13, 2020

/approve
will merge after upstream merge hold is removed

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 13, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rphillips, sjenning, tedyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2020
@tedyu
Copy link
Author

tedyu commented Mar 13, 2020

/test e2e-gcp

@tedyu
Copy link
Author

tedyu commented Mar 13, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2020
@tedyu
Copy link
Author

tedyu commented Mar 14, 2020

/test e2e-gcp-upgrade

1 similar comment
@tedyu
Copy link
Author

tedyu commented Mar 14, 2020

/test e2e-gcp-upgrade

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2020
@tedyu
Copy link
Author

tedyu commented Mar 16, 2020

/hold cancel

@tedyu
Copy link
Author

tedyu commented Mar 16, 2020

/test e2e-gcp-upgrade

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 16, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 16, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 30bb963 into openshift:master Mar 16, 2020
@soltysh soltysh mentioned this pull request Jul 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjenning sjenning Awaiting requested review from sjenning

@timlnx timlnx Awaiting requested review from timlnx

Assignees

@rphillips rphillips

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. vendor-update Touching vendor dir or related files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tedyu @rphillips @sjenning @openshift-ci-robot @openshift-bot @openshift-merge-robot