Skip to content

UPSTREAM: Reduce reaper poll interval and wait while resizing #2442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2015
Merged

UPSTREAM: Reduce reaper poll interval and wait while resizing #2442

merged 2 commits into from
May 22, 2015

Conversation

0xmichalis
Copy link
Contributor

@smarterclayton
Copy link
Contributor

LGTM [merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/2066/) (Image: devenv-fedora_1602)

@0xmichalis
Copy link
Contributor Author

timed out waiting for the condition
timed out waiting for the condition
timed out waiting for the condition
!!! Error in hack/test-cmd.sh:572
'osc delete all --all' exited with status 1
Call stack:
1: hack/test-cmd.sh:572 main(...)

Expected this flake to happen since now the timeout is reduced from 5 minutes to 20 seconds....

@0xmichalis
Copy link
Contributor Author

I suggest either commenting that delete all out and adding a TODO for uncommenting when the replciationController manager will be faster or bumping the timeout back to 5 minutes. @smarterclayton thoughts?

@smarterclayton
Copy link
Contributor

Why did we need to lower the timeout?

On May 22, 2015, at 10:52 AM, Michail Kargakis notifications@github.com wrote:

I suggest either commenting that delete all out and adding a TODO for uncommenting when the replciationController manager will be faster or bumping the timeout back to 5 minutes. @smarterclayton thoughts?


Reply to this email directly or view it on GitHub.

@0xmichalis
Copy link
Contributor Author

Why did we need to lower the timeout?

We didnt' actually. It seems a reasonable time in an era of a fast rc manager...

@0xmichalis
Copy link
Contributor Author

[test]

@smarterclayton
Copy link
Contributor

[merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/2356/)

@openshift-bot
Copy link
Contributor

Evaluated for origin up to 7349fa9

openshift-bot pushed a commit that referenced this pull request May 22, 2015
@openshift-bot openshift-bot merged commit 5938ea6 into openshift:master May 22, 2015
@0xmichalis 0xmichalis deleted the wait-while-resizing branch May 22, 2015 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants