Skip to content

Add test-cmd test to validate that we can create using a stored template #2431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2015

Conversation

csrwng
Copy link
Contributor

@csrwng csrwng commented May 21, 2015

No description provided.

@csrwng
Copy link
Contributor Author

csrwng commented May 21, 2015

@bparees ptal

@csrwng
Copy link
Contributor Author

csrwng commented May 21, 2015

[test]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/2341/)

@@ -386,6 +386,8 @@ osc get template ruby-helloworld-sample
[ "$(osc new-app ruby-helloworld-sample -o yaml | grep MYSQL_PASSWORD)" ]
[ "$(osc new-app ruby-helloworld-sample -o yaml | grep ADMIN_USERNAME)" ]
[ "$(osc new-app ruby-helloworld-sample -o yaml | grep ADMIN_PASSWORD)" ]
# check that we can create from the template without errors
osc new-app ruby-helloworld-sample
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should do a delete after this to clean it up.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should do a delete after this to clean it up.

+1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete added

@csrwng csrwng force-pushed the new_app_template_test branch from 66e0cce to dc3ea16 Compare May 22, 2015 01:29
@bparees
Copy link
Contributor

bparees commented May 22, 2015

Lgtm. [merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/2054/) (Image: devenv-fedora_1596)

@openshift-bot
Copy link
Contributor

Evaluated for origin up to dc3ea16

openshift-bot pushed a commit that referenced this pull request May 22, 2015
@openshift-bot openshift-bot merged commit 06c3c24 into openshift:master May 22, 2015
@csrwng csrwng deleted the new_app_template_test branch July 20, 2015 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants