Avoid warning icon flicker for deployment configs #2419
Conversation
|
@liggitt PTAL. Passing |
| <overview-deployment | ||
| rc="deployment" | ||
| deployment-config-id="deploymentConfigId" | ||
| deployment-config="deploymentConfigs[deploymentConfigId]" | ||
| deployment-config-missing="deploymentConfigs && deploymentConfigs[deploymentConfigId] == null" |
There was a problem hiding this comment.
deploymentConfigs && !deploymentConfigs[deploymentConfigId]?
There was a problem hiding this comment.
The deploymentConfig == null check was previously in _overview-deployment.html. I wasn't sure if it was that way for a reason.
spadgett
force-pushed
the
overview-warning-flicker
branch
from
646528d to
d023677
Compare
|
@liggitt please take another look |
| deploymentConfigId: '=', | ||
| deploymentConfigMissing: '=', | ||
| differentService: '=', |
There was a problem hiding this comment.
just noticed this should be deploymentConfigDifferentService
spadgett
force-pushed
the
overview-warning-flicker
branch
from
d023677 to
0224307
Compare
spadgett
force-pushed
the
overview-warning-flicker
branch
from
0224307 to
1f116a9
Compare
| deployment-config="deploymentConfigs[deploymentConfigId]" | ||
| deployment-config-different-service="!deploymentConfigsByService[''][deploymentConfigId]" | ||
| deployment-config-missing="deploymentConfigs && !deploymentConfigs[deploymentConfigId]" | ||
| deployment-config-different-service="deploymentConfigs[deploymentConfigId] && !deploymentConfigsByService[serviceId][deploymentConfigId]" |
Don't show the missing deployment config warning until the deployment configs have finished loading to avoid flicker. Update the warning tooltip so that the raw Angular expression isn't visible. Fixes openshift#2411 Fixes openshift#2415
spadgett
force-pushed
the
overview-warning-flicker
branch
from
1f116a9 to
9853f58
Compare
|
LGTM [merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/2051/) (Image: devenv-fedora_1594) |
|
[Test]ing while waiting on the merge queue |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/2333/) |
|
Evaluated for origin up to 9853f58 |
Merged by openshift-bot
Don't show the missing deployment config warning until the deployment
configs have finished loading to avoid flicker.
Fixes #2411