Make link show up again and pass along token to openshift-jvm #2416
Conversation
| }; | ||
| }) | ||
| .run(function(ProxyPod, BaseHref, HawtioExtension, $templateCache, $compile) { | ||
| .run(function(ProxyPod, BaseHref, HawtioExtension, $templateCache, $compile, LocalStorageUserStore) { |
There was a problem hiding this comment.
can't assume this is the user store being used... can call $injector.get(AuthService.UserStore()) to get the configured user store
There was a problem hiding this comment.
Ah perfect, will change that, thanks.
gashcrumb
force-pushed
the
java-link-fixes
branch
from
7f14e1b to
7fc522d
Compare
|
@liggitt updated. Had to add UserStore() to AuthService, it wasn't exposed as a function. |
|
ah, I was thinking of |
|
|
||
| // Returns the configured user store | ||
| UserStore: function() { | ||
| return _userStore; |
There was a problem hiding this comment.
if we're exposing this, just return userStore so the caller doesn't have to use $injector.get()
gashcrumb
force-pushed
the
java-link-fixes
branch
from
7fc522d to
a8cbfcf
Compare
|
@liggitt good call, updated that, ready for your review again when you get a chance... |
| .query({ | ||
| jolokiaUrl: jolokiaUrl, | ||
| title: title, | ||
| returnTo: returnTo | ||
| returnTo: returnTo, |
Apply feedback More tweaks Remove trailing comma
gashcrumb
force-pushed
the
java-link-fixes
branch
from
a8cbfcf to
06d9806
Compare
|
@liggitt removed |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/2048/) (Image: devenv-fedora_1591) |
|
Evaluated for origin up to 06d9806 |
|
[Test]ing while waiting on the merge queue |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/2326/) |
Merged by openshift-bot
@liggitt, needed to fix issues found in bugzilla #1222764, whenever you get a chance to review. Thanks!