Setting max/default ActiveDeadlineSeconds on the deployer pod #2402
Conversation
|
What controls how long a LifecycleHook can run? My understanding is that that can also cause a new pod to be created. |
|
@derekwaynecarr Good catch! I am now setting the same value on the deployment hook pod as well. These would apply to the deployment strategies that we provide. Users can still go ahead and provide their own deployer pod image and we'd have no control over anything they do in there. But for the deployment strategies that we provide, we have added the attribute. |
| @@ -143,7 +146,8 @@ func buildContainer(hook *deployapi.ExecNewPodHook, deployment *kapi.Replication | |||
| Resources: resources, | |||
| }, | |||
| }, | |||
| RestartPolicy: kapi.RestartPolicyNever, | |||
| ActiveDeadlineSeconds: &maxDeploymentDurationSeconds, | |||
There was a problem hiding this comment.
test that verifies this?
|
Also, I'd like to keep these commits separate. |
|
@derekwaynecarr Please review/merge |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/2047/) (Image: devenv-fedora_1591) |
|
Evaluated for origin up to 20cf8b9 |
|
[Test]ing while waiting on the merge queue |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/2327/) |
Merged by openshift-bot
No description provided.