Move deployment config to etcdgeneric storage patterns #2377
Conversation
|
Related to #2104 |
|
|
||
| // PrepareForCreate clears fields that are not allowed to be set by end users on creation. | ||
| func (strategy) PrepareForCreate(obj runtime.Object) { | ||
| _ = obj.(*api.DeploymentConfig) |
There was a problem hiding this comment.
We need a follow up issue to determine whether PrepareForCreate/Update should prevent status.latestVersion from being set out of order. There are advantages and disadvantages. Maybe a todo.
|
Then builds have the same problem. Will update |
|
Is there any need to keep /deployments and the storage code laying around. It's confusing and would like to purge it as well. |
|
No, you can nuke it. ----- Original Message -----
|
|
Other than objectmeta update validation this is LGTM |
|
Got side tracked on doc stuff, will nuke deployments, fix update, and then look to merge. Sent from my iPhone
|
derekwaynecarr
force-pushed
the
deployment_registry_updates
branch
from
d3a2ce6 to
e23063c
Compare
derekwaynecarr
force-pushed
the
deployment_registry_updates
branch
from
e23063c to
cbbf48f
Compare
|
Fixed validation, will kill /deployments code in a later PR so I can keep this merge simpler. |
|
LGTM [merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/2044/) (Image: devenv-fedora_1590) |
|
Evaluated for origin up to cbbf48f |
|
[Test]ing while waiting on the merge queue |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/2325/) |
Merged by openshift-bot
This moves the storage of
DeploymentConfigobjects to follow latest upstream patterns./cc @ironcladlou @abhgupta @smarterclayton