Skip to content

Disable triggers while reaping a deploymentConfig #2374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2015
Merged

Disable triggers while reaping a deploymentConfig #2374

merged 1 commit into from
May 22, 2015

Conversation

0xmichalis
Copy link
Contributor

@smarterclayton
Copy link
Contributor

Can you add a quick test case for this?

@0xmichalis
Copy link
Contributor Author

Not sure on how I should go about testing this. The respective Kubernetes unit test doesn't seem to be doing anything noteworthy other than enumerating the HTTP calls...

@0xmichalis
Copy link
Contributor Author

@smarterclayton went ahead and added a simple test case, also made an api change to use interfaces for easy testing (eliminates the interface conversion in Stop), ptal

@0xmichalis
Copy link
Contributor Author

I've refactored the mock methods under testclient (#2440), will need to update this PR once that gets merged.

@smarterclayton
Copy link
Contributor

Changes look fine to me, let me know when rebased

@0xmichalis
Copy link
Contributor Author

rebased

@smarterclayton
Copy link
Contributor

LGTM [merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/2062/) (Image: devenv-fedora_1600)

@openshift-bot
Copy link
Contributor

Evaluated for origin up to 0a1312c

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/2357/)

openshift-bot pushed a commit that referenced this pull request May 22, 2015
Merge pull request #2374 from kargakis/disable-dc-triggers-when-reaping
978bd2c 
Merged by openshift-bot
@openshift-bot openshift-bot merged commit 978bd2c into openshift:master May 22, 2015
@0xmichalis 0xmichalis deleted the disable-dc-triggers-when-reaping branch May 22, 2015 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0xmichalis @smarterclayton @openshift-bot @Kargakis