check if the containers' image is downstream #23185

jianzhangbjz · 2019-06-16T12:25:59Z

For now, we have to check if these images are downstream for each sub-team. I have intended to check the image labels, but I didn't find the related options. So, I added related checks steps in here. I'm not sure if it's appropriate for upstream. @sosiouxme @vikaslaad Could you help take a review? Thanks! cc: @scolange @bandrade @cuipinghuo @chengzhang1016 @dongboyan77 @zihantang-rh @emmajiafan

jianzhangbjz · 2019-06-17T03:16:18Z

/test verify

jianzhangbjz · 2019-06-18T03:21:44Z

/test verify

bparees

couple nits, otherwise lgtm.

bparees · 2019-06-20T13:38:36Z

test/extended/operators/images.go

 		// log for debugging output before we ultimately fail
 		e2e.Logf("Pods found with invalid container images not present in release payload: %s", strings.Join(invalidPodContainerImages.List(), "\n"))
 		e2e.Logf("Pods found with invalid container image pull policy not equal to IfNotPresent: %s", strings.Join(invalidPodContainerImagePullPolicy.List(), "\n"))
+		e2e.Logf("Pods with invaild dowstream images: %s", strings.Join(invalidPodContainerDownstreamImages.List(), "\n"))


typo, invalid.

bparees · 2019-06-20T13:38:42Z

test/extended/operators/images.go

 			e2e.Failf("Pods found with invalid container image pull policy not equal to IfNotPresent: %s", strings.Join(invalidPodContainerImagePullPolicy.List(), "\n"))
 		}
+		if len(invalidPodContainerDownstreamImages) > 0 {
+			e2e.Failf("Pods with invaild dowstream images: %s", strings.Join(invalidPodContainerDownstreamImages.List(), "\n"))


typo, invalid

bparees · 2019-06-20T13:41:26Z

/approve

jianzhangbjz · 2019-06-21T03:09:03Z

@bparees Many thanks! I have fixed it and squash these commits into one. Please help take a review, thanks!
This PR will check all components' images of OCP whether is downstream. cc @openshift/team-qe

liangxia · 2019-06-21T03:41:22Z

test/extended/operators/images.go

+						continue
+					}
+					e2e.Logf("Image relase info:%s", result)
+					if !strings.Contains(result, "Red Hat Enterprise Linux Server") {


Not supporting RHEL CoreOS based images ?

Not for now, I guess the release images have not based on the RHCOS yet. Correct me if I'm wrong. What do you think?@vikaslaad

the images this would be checking are all UBI based and I'd expect them to continue to be.

Inferring from @smarterclayton - will this continue to be the case if we run OKD CI and with Fedora CoreOS as the base?

fedora coreos would be the base for the nodes, not the container images which i would expect to continue to be UBI based. I'm not aware of any plans for a fedora equivalent of the UBI.

@bparees I'm sorry, what're the checkpoints of UBI based images? Do we have any special label when running UBI images?

we only run ubi images, there are no other images.

@bparees I guess checking the output of $ cat /etc/redhat-release is enough for identifying the UBI images, what do you think?

@jianzhangbjz i think it's fine for now, if it becomes a problem we can always revisit it.

Ok, thanks!

bparees · 2019-06-21T13:43:47Z

test/extended/util/cli.go

 }

+// Run command without extra args
+func (c *CLI) RunWithoutGlobalArgs(commands ...string) *CLI {


did you have to introduce this because Run appends --config and --namespace after the other args? If so, why not fix Run to append commands after the --config and --namespace instead of introducing a new function?

The Run function will add the --config=xxx/--namespace=xxx on the end of the command. But, it inappropriate for some commands, for example, oc exec -n openshift-apiserver-operator openshift-apiserver-operator-59487cc4bf-7ws9q -c openshift-apiserver-operator -- cat /etc/redhat-release.
And, I also thought to change the Run function, but as you know, Golang doesn't support the default arguments. I worried the changes will impact other old invoking. So, I create a new one.
Or we can change the Run function to add --config=xxx/--namespace=xxx args at the begining of the commands. What do you suggest?

i would expect that adding it to the beginning should be fine and if it breaks a test it should be caught in CI as part of your PR.

Ok, thanks! I will modify the Run function instead of creating a new one.

@jianzhangbjz An aspect is the ubi base image have enabled some ubi repo by default.
sh-4.2$ yum repolist
repo id repo name status
ubi-7/x86_64 Red Hat Universal Base Image 7 Server (RPMs) 832
ubi-7-optional/x86_64 Red Hat Universal Base Image 7 Server - Optional (RPMs) 18
ubi-7-rhah/x86_64 Red Hat Universal Base Image Atomic Host (RPMs) 3
ubi-7-rhscl/x86_64 Red Hat Software Collections for Red Hat Universal Base Image 7 Server (RPMs)

Thanks for your information! @anpingli Removed the RunWithoutGlobalArgs function. @bparees

sosiouxme · 2019-06-26T03:14:07Z

@jianzhangbjz @bparees I'm sorry, I'm lacking context for what this is trying to accomplish, and can't quickly infer it from the code. When would this run, and what is it comparing to determine there's a mismatch between upstream and downstream? (What is the source of truth?)

I'm not sure it's relevant but there's a much-delayed effort to ensure consistency between upstream and downstream config: openshift/ci-operator-prowgen#121

bparees · 2019-06-26T14:42:07Z

@jianzhangbjz @bparees I'm sorry, I'm lacking context for what this is trying to accomplish, and can't quickly infer it from the code. When would this run, and what is it comparing to determine there's a mismatch between upstream and downstream? (What is the source of truth?)

i don't think it's comparing up/downstream. My assumptoin is that it's just trying to ensure all our images are UBI-rhel based, which today they should be. (and even w/ OKD i'm anticipating this will still be true)

jianzhangbjz · 2019-06-28T11:29:33Z

@bparees I guess some images in OKD are based on centos, not rhel. What will trigger those tests which under test/extended/... folder? Or these extend tests will be run as default?

bparees · 2019-06-28T14:56:17Z

@bparees I guess some images in OKD are based on centos, not rhel. What will trigger those tests which under test/extended/... folder? Or these extend tests will be run as default?

Are you referring to things like the ruby/jenkins/python/mongodb/etc type images?

None of our product/infra images should be centos-based. so as long as you scope the pods you're checking to the openshift* type namespaces, it should not be a problem.

If you're seeing some failures due to containers using centos images, let's look at them specifically and decide the right approach.

jianzhangbjz · 2019-06-29T00:42:55Z

@bparees Got it, thanks! Could you help review this PR and add the lgtm label? Thanks!

jianzhangbjz · 2019-06-29T00:43:14Z

/retest

bparees · 2019-06-29T15:58:19Z

let's see if we can get passing tests first... (probably failed due to the CI issues, but i don't want to leave this retrying indefinitely if it's fundamentally broken).

/retest

bparees · 2019-06-29T20:52:35Z

failures look unrelated to this pr.
/lgtm

openshift-bot · 2019-06-29T21:07:07Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-06-29T23:56:06Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-06-30T02:58:06Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-06-30T06:00:09Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-06-30T07:57:06Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-06-30T10:33:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

bparees · 2019-06-30T13:17:25Z

/hold Ben Parees | OpenShift

…

On Sun, Jun 30, 2019, 06:34 OpenShift Bot ***@***.***> wrote: /retest Please review the full test history <https://openshift-gce-devel.appspot.com/pr/23185> for this PR and help us cut down flakes. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#23185?email_source=notifications&email_token=ABF6LXRKPDUTW4POWV3CR2DP5CD2PA5CNFSM4HYRCB6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY4JQKQ#issuecomment-507025450>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABF6LXRP3TSH235OINC2K63P5CD2PANCNFSM4HYRCB6A> .

bparees · 2019-06-30T18:18:34Z

appears to be failing due to https://bugzilla.redhat.com/show_bug.cgi?id=1725478

will unhold when that is resolved, until then this won't be able to merge.

bparees · 2019-07-01T01:09:10Z

/hold cancel
/retest

openshift-bot · 2019-07-01T07:21:11Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-07-01T10:36:07Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-07-01T16:53:09Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-07-01T20:34:09Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-07-01T21:13:09Z

/retest

Please review the full test history for this PR and help us cut down flakes.

jianzhangbjz · 2019-07-02T02:02:18Z

Rebase it to solve the conflicts, could you help add the lgtm label again? Thanks! @bparees

bparees · 2019-07-02T02:48:42Z

/lgtm

openshift-ci-robot · 2019-07-02T02:48:53Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, jianzhangbjz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~test/extended/OWNERS~~ [bparees]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

p0lyn0mial · 2019-12-17T15:48:24Z

FYI this test is extremely unstable (for example #24305). I am going to disable it.

bparees · 2019-12-17T15:50:50Z

@p0lyn0mial for any test you disable please create a BZ to track getting it re-enabled.

bparees · 2019-12-17T15:52:55Z

@p0lyn0mial also please link to the failing job, not your PR, to illustrate the issue.

openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 16, 2019

openshift-ci-robot requested review from adambkaplan and mfojtik June 16, 2019 12:26

bparees requested changes Jun 20, 2019

View reviewed changes

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2019

jianzhangbjz force-pushed the downstream-olm branch from 0bd6063 to 7f31f3d Compare June 21, 2019 03:01

liangxia reviewed Jun 21, 2019

View reviewed changes

bparees reviewed Jun 21, 2019

View reviewed changes

bparees self-assigned this Jun 29, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2019

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 30, 2019

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2019

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 1, 2019

jianzhangbjz added 2 commits July 2, 2019 09:44

check if the containers'image is downstream

e2f9c60

modify the Run function

e32900f

jianzhangbjz force-pushed the downstream-olm branch from eabe8b7 to e32900f Compare July 2, 2019 01:50

openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 2, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2019

openshift-merge-robot merged commit 29359bd into openshift:master Jul 2, 2019

jianzhangbjz deleted the downstream-olm branch July 2, 2019 09:42

check if the containers' image is downstream #23185

check if the containers' image is downstream #23185

Uh oh!

Conversation

jianzhangbjz commented Jun 16, 2019

Uh oh!

jianzhangbjz commented Jun 17, 2019

Uh oh!

jianzhangbjz commented Jun 18, 2019

Uh oh!

bparees left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bparees commented Jun 20, 2019

Uh oh!

jianzhangbjz commented Jun 21, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jianzhangbjz Jun 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anpingli Jun 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sosiouxme commented Jun 26, 2019

Uh oh!

bparees commented Jun 26, 2019

Uh oh!

jianzhangbjz commented Jun 28, 2019

Uh oh!

bparees commented Jun 28, 2019

Uh oh!

jianzhangbjz commented Jun 29, 2019

Uh oh!

jianzhangbjz commented Jun 29, 2019

Uh oh!

bparees commented Jun 29, 2019

Uh oh!

bparees commented Jun 29, 2019

Uh oh!

openshift-bot commented Jun 29, 2019

Uh oh!

openshift-bot commented Jun 29, 2019

Uh oh!

openshift-bot commented Jun 30, 2019

Uh oh!

openshift-bot commented Jun 30, 2019

jianzhangbjz Jun 23, 2019 •

edited

Loading

anpingli Jun 26, 2019 •

edited

Loading