Give the SDN permission to create Events #19818
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#16745 made the SDN log an event on startup, but the
system:sdn-reader
group doesn't actually have permission to create Events; it was just stealing it fromsystem:node
. Now that the SDN is running separately, it needs to explicitly have that permission.Current version of this PR just adds event create permission to
system:sdn-reader
, which is probably wrong I guess since "create" != "read". So do we need to create a newsystem:sdn
group for the SDN pod to run under? And deprecatesdn-reader
since it would no longer serve any purpose?Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1581538