Skip to content

Conversation

danwinship
Copy link
Contributor

#16745 made the SDN log an event on startup, but the system:sdn-reader group doesn't actually have permission to create Events; it was just stealing it from system:node. Now that the SDN is running separately, it needs to explicitly have that permission.

events is forbidden: User "system:serviceaccount:openshift-sdn:sdn" cannot create events in the namespace "default"

Current version of this PR just adds event create permission to system:sdn-reader, which is probably wrong I guess since "create" != "read". So do we need to create a new system:sdn group for the SDN pod to run under? And deprecate sdn-reader since it would no longer serve any purpose?

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1581538

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 23, 2018
Copy link
Contributor

@knobunc knobunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, knobunc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2018
@openshift-merge-robot openshift-merge-robot merged commit 46306da into openshift:master May 24, 2018
@danwinship danwinship deleted the sdn-event-permission branch June 11, 2018 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants