Skip to content

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented May 2, 2018

@sttts any reason we shouldn't enable the CRDs subresources by default? I made use of the status subresource to drive generations in my operator here: #19498 .

@openshift/api-review I'm going off now to find the flag that wires this on, but I figured I'd open a pull to debate whether we should just turn this one on.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 2, 2018
@deads2k
Copy link
Contributor Author

deads2k commented May 2, 2018

/hold

just so no one accidentally merges it.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 2, 2018
@sttts
Copy link
Contributor

sttts commented May 2, 2018

@deads2k there is an issue open to promote them to beta. We haven't heard anything negative and don't know any issues. So it is safe IMO to enable it by default.

@liggitt
Copy link
Contributor

liggitt commented May 2, 2018

I wouldn't want to enable this in a shipped version until it has actually shipped as beta in kube

@sttts
Copy link
Contributor

sttts commented May 2, 2018 via email

@openshift-ci-robot
Copy link

@deads2k: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/unit 00aede4 link /test unit
ci/openshift-jenkins/cmd 00aede4 link /test cmd
ci/openshift-jenkins/extended_conformance_install 00aede4 link /test extended_conformance_install
ci/openshift-jenkins/gcp 00aede4 link /test gcp

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k deads2k closed this May 4, 2018
@deads2k deads2k deleted the server-27-crd-subresoruces branch July 3, 2018 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants