Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1756230: Only load config map metadata on config maps page #3152

Conversation

spadgett
Copy link
Member

Only the metadata is needed to display the config map list. This greatly
improves performance on slow network connections since not all config
map data is loaded.

/assign @TheRealJon

Only the metadata is needed to display the config map list. This greatly
improves performance on slow network connections since not all config
map data is loaded.
@openshift-ci-robot
Copy link

@spadgett: This pull request references Bugzilla bug 1756230, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1756230: Only load config map metadata on config maps page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 14, 2019
@spadgett
Copy link
Member Author

/retest

Copy link
Member

@TheRealJon TheRealJon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2019
@dobbymoodge
Copy link

/retest

1 similar comment
@dobbymoodge
Copy link

/retest

@dobbymoodge
Copy link

/retest with changes from openshift-eng/aos-cd-jobs#1995

@dobbymoodge
Copy link

/retest because I think I clogged up the tubes 😛

@spadgett
Copy link
Member Author

/retest

1 similar comment
@spadgett
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link

@spadgett: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins 641e557 link /test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

@spadgett: spadgett unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file.

In response to this:

/override ci/openshift-jenkins

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jwforres
Copy link
Member

/override ci/openshift-jenkins

@openshift-ci-robot
Copy link

@jwforres: Overrode contexts on behalf of jwforres: ci/openshift-jenkins

In response to this:

/override ci/openshift-jenkins

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit a01c607 into openshift:enterprise-3.11 Oct 22, 2019
@openshift-ci-robot
Copy link

@spadgett: All pull requests linked via external trackers have merged. Bugzilla bug 1756230 has been moved to the MODIFIED state.

In response to this:

Bug 1756230: Only load config map metadata on config maps page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants